diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-09-15 15:54:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-09-16 08:30:26 +0000 |
| commit | a2b77b43685884fb4e9be04152a49294fa50db36 (patch) | |
| tree | 00d599e81a653dc5c663f9dd179970b3e6aa11f2 /compilerplugins | |
| parent | 389939b02bde4ea72268960310bbd1f2984200bf (diff) | |
loplugin:singlevalfields in basic..idl
Also fix obvious bug in the initialisation of the
connectivity::odbc::OConnection::m_bClosed field.
Probably closes some kind of connection leak there.
Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82
Reviewed-on: https://gerrit.libreoffice.org/28932
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
| -rwxr-xr-x | compilerplugins/clang/singlevalfields.py | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/compilerplugins/clang/singlevalfields.py b/compilerplugins/clang/singlevalfields.py index eb5a7b043efd..38fc119bbbe8 100755 --- a/compilerplugins/clang/singlevalfields.py +++ b/compilerplugins/clang/singlevalfields.py @@ -52,12 +52,20 @@ for fieldInfo, assignValues in fieldAssignDict.iteritems(): continue # ignore things which are representations of on-disk structures if containingClass in ["SEPr", "WW8Dop", "BmpInfoHeader", "BmpFileHeader", "Exif::ExifIFD", - "sw::WW8FFData", "FFDataHeader", "INetURLHistory_Impl::head_entry", "ImplPPTParaPropSet", "SvxSwAutoFormatFlags"]: + "sw::WW8FFData", "FFDataHeader", "INetURLHistory_Impl::head_entry", "ImplPPTParaPropSet", "SvxSwAutoFormatFlags", + "T602ImportFilter::T602ImportFilter::format602struct", "DataNode"]: + continue + if v2.startswith("hwpfilter/source"): + continue + # ignore things which are representations of structures from external code + if v2.startswith("desktop/unx/source/splashx.c"): continue # Windows-only - if containingClass in ["SfxAppData_Impl", "sfx2::ImplDdeItem", "SvFileStream", "DdeService", "DdeTopic", "DdeItem", "DdeConnection", "connectivity::sdbcx::OUser", "connectivity::sdbcx::OGroup", "connectivity::sdbcx::OCatalog"]: + if containingClass in ["SfxAppData_Impl", "sfx2::ImplDdeItem", "SvFileStream", + "DdeService", "DdeTopic", "DdeItem", "DdeConnection", "connectivity::sdbcx::OUser", "connectivity::sdbcx::OGroup", "connectivity::sdbcx::OCatalog", + "cairocanvas::SpriteHelper"]: continue - if v2.startswith("include/svl/svdde.hxx"): + if v2.startswith("include/svl/svdde.hxx") or v2.startswith("embeddedobj/source/inc/oleembobj.hxx"): continue # Some of our supported compilers don't do constexpr, which means o3tl::typed_flags can't be 'static const' if containingClass in ["WaitWindow_Impl"]: |