diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2020-10-26 09:35:27 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2020-10-26 11:39:45 +0100 |
commit | a9266c39cc71c6f23bfcad4ff6d33ccac53b5e52 (patch) | |
tree | 430977c299e4555585722a825f4d2966bc4930b4 /compilerplugins | |
parent | 6a10ea009ef590ac13d01d19fbfbc28c916ef1d4 (diff) |
loplugin:toolslong (--enable-online-update)
...but where
> ~/lo/core/extensions/source/update/check/download.cxx:297:17: error: VarDecl, use "tools::Long" instead of 'long' [loplugin:toolslong]
> long nError;
> ^~~~~~~~~~~
> ~/lo/core/extensions/source/update/check/download.cxx:153:9: error: VarDecl, use "tools::Long" instead of 'long' [loplugin:toolslong]
> long nCode;
> ^~~~~~~~~~
were false positives (the third argument to
curl_easy_getinfo(..., CURLINFO_RESPONSE_CODE, ...)
must be a pointer to long).
Change-Id: I9596ff32c32fddc7c1240d7fec3672d36265631a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104794
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins')
-rw-r--r-- | compilerplugins/clang/toolslong.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/compilerplugins/clang/toolslong.cxx b/compilerplugins/clang/toolslong.cxx index 1e808cf9daab..1f55fb76d1d6 100644 --- a/compilerplugins/clang/toolslong.cxx +++ b/compilerplugins/clang/toolslong.cxx @@ -123,7 +123,8 @@ void ToolsLong::run() StringRef fn(handler.getMainFileName()); // sberg says this is fine - if (loplugin::isSamePathname(fn, SRCDIR "/pyuno/source/module/pyuno.cxx")) + if (loplugin::isSamePathname(fn, SRCDIR "/extensions/source/update/check/download.cxx") + || loplugin::isSamePathname(fn, SRCDIR "/pyuno/source/module/pyuno.cxx")) return; TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); |