summaryrefslogtreecommitdiff
path: root/compilerplugins/clang/test
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2020-08-21 09:26:43 +0200
committerStephan Bergmann <sbergman@redhat.com>2020-08-21 12:07:30 +0200
commita8ab80c58a1330672d7a8eefd73b2eb9cb6c134c (patch)
treed6cd0d1af8068b8628485d691dbf499bf0b97ef4 /compilerplugins/clang/test
parent17798a503bc67f2a38f4b558e37447d1ea8f4623 (diff)
Silence some clang-cl loplugin:stringstatic
For one, do not warn about global declarations in included files, as generally not all uses of the variable are seen to decided whether it would be good to replace. That covers cases like > In file included from dtrans/source/win32/dtobj/DataFmtTransl.cxx:26: > dtrans/source/win32/dtobj/MimeAttrib.hxx(29,16): error: rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic] > const OUString CHARSET_UTF16 ("utf-16"); > ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ For another, do not warn about variables whose pData member is used. That covers cases like > sal/osl/w32/procimpl.cxx(347,20): error: rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic] > const OUString ENV_COMSPEC ("COMSPEC"); > ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I75c1048098b63164bdb583695951f73964cb24f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101134 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins/clang/test')
-rw-r--r--compilerplugins/clang/test/stringstatic.cxx6
-rw-r--r--compilerplugins/clang/test/stringstatic.hxx23
2 files changed, 29 insertions, 0 deletions
diff --git a/compilerplugins/clang/test/stringstatic.cxx b/compilerplugins/clang/test/stringstatic.cxx
index 7d8522ecd13b..3c26d961c6a8 100644
--- a/compilerplugins/clang/test/stringstatic.cxx
+++ b/compilerplugins/clang/test/stringstatic.cxx
@@ -9,9 +9,13 @@
#include <rtl/ustring.hxx>
+#include "stringstatic.hxx"
+
// expected-error@+1 {{rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic]}}
static const OUString TEST1 = "xxx";
+void f(rtl_uString const*);
+
void test2()
{
// expected-error@+1 {{rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic]}}
@@ -20,4 +24,6 @@ void test2()
static const OUString XXX2 = "xxx";
(void)XXX;
(void)XXX2;
+ static const OUString DATA = "xxx";
+ f(DATA.pData);
}
diff --git a/compilerplugins/clang/test/stringstatic.hxx b/compilerplugins/clang/test/stringstatic.hxx
new file mode 100644
index 000000000000..ec82a8bf5deb
--- /dev/null
+++ b/compilerplugins/clang/test/stringstatic.hxx
@@ -0,0 +1,23 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "sal/config.h"
+
+#include "rtl/ustring.hxx"
+
+OUString const INCLUDED = "xxx";
+
+inline void f()
+{
+ // expected-error@+1 {{rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic]}}
+ static OUString const XXX = "xxx";
+ (void)XXX;
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */