summaryrefslogtreecommitdiff
path: root/compilerplugins/clang/refcounting.cxx
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-01-31 17:26:29 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-02-01 11:39:55 +0100
commit62222b40973fa71eba6c77bdd85be30864350f3f (patch)
tree7728e082850540f6f3040e6656e3d2478bcd1c7c /compilerplugins/clang/refcounting.cxx
parent5acfb93c6461589bcb5b92ae363b0aed6424b9a2 (diff)
these TODOs have been done
Change-Id: I5457f38f4668175a8f3e1b0f24a90963ee9d585f Reviewed-on: https://gerrit.libreoffice.org/49076 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins/clang/refcounting.cxx')
-rw-r--r--compilerplugins/clang/refcounting.cxx7
1 files changed, 0 insertions, 7 deletions
diff --git a/compilerplugins/clang/refcounting.cxx b/compilerplugins/clang/refcounting.cxx
index 091ed20a0d12..8133e281d8aa 100644
--- a/compilerplugins/clang/refcounting.cxx
+++ b/compilerplugins/clang/refcounting.cxx
@@ -33,8 +33,6 @@ If you see another class:
this is a bug =) since aFooMember assumes heap allocated lifecycle and
not delete on last 'release'.
-TODO check that things that extend SvRefBase are managed by SvRef
-TODO fix the slideshow::internal::SlideView class (mentioned below)
*/
namespace {
@@ -133,11 +131,6 @@ bool containsXInterfaceSubclass(const clang::Type* pType0) {
if (isDerivedFrom(pRecordDecl, [](Decl const * decl) -> bool { return bool(loplugin::DeclCheck(decl).Class("OSbaWeakSubObject").Namespace("dbaui").GlobalNamespace()); })) { // module dbaccess
return false;
}
- // The actual problem child is SlideView, of which this is the parent.
- // Everything in the hierarchy above this wants to be managed via boost::shared_ptr
- if (isDerivedFrom(pRecordDecl, [](Decl const * decl) -> bool { return bool(loplugin::DeclCheck(decl).Class("UnoView").Namespace("internal").Namespace("slideshow").GlobalNamespace()); })) { // module slideshow
- return false;
- }
// FIXME This class has private operator new, and I cannot figure out how it can be dynamically instantiated
if (isDerivedFrom(pRecordDecl, [](Decl const * decl) -> bool { return bool(loplugin::DeclCheck(decl).Class("XPropertyList").GlobalNamespace()); })) { // module svx
return false;