diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 10:28:48 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 14:47:17 +0200 |
| commit | 7ceee0f1ec0e349d0df4980d7fdedbd13c7917c5 (patch) | |
| tree | 616ab419fe0f01e94740de7faacb393775420589 /comphelper | |
| parent | 664db0d945fbb23e115eeea8377e3a4e88541da1 (diff) | |
Extend loplugin:redundantinline to catch inline functions w/o external linkage
...where "inline" (in its meaning of "this function can be defined in multiple
translation units") thus doesn't make much sense. (As discussed in
compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions
in include files for now.)
All the rewriting has been done automatically by the plugin, except for one
instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus
some subsequent solenv/clang-format/reformat-formatted-files.
Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224
Reviewed-on: https://gerrit.libreoffice.org/61573
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'comphelper')
| -rw-r--r-- | comphelper/qa/unit/variadictemplates.cxx | 6 | ||||
| -rw-r--r-- | comphelper/source/misc/anytostring.cxx | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/comphelper/qa/unit/variadictemplates.cxx b/comphelper/qa/unit/variadictemplates.cxx index 1549177d78f4..20d47f89758a 100644 --- a/comphelper/qa/unit/variadictemplates.cxx +++ b/comphelper/qa/unit/variadictemplates.cxx @@ -32,7 +32,7 @@ namespace { namespace detail { template <typename T> -inline void extract( +void extract( ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any> const& seq, sal_Int32 nArg, T & v, ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface> @@ -54,7 +54,7 @@ inline void extract( } template <typename T> -inline void extract( +void extract( ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any> const& seq, sal_Int32 nArg, ::boost::optional<T> & v, ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface> @@ -70,7 +70,7 @@ inline void extract( } // namespace detail template < typename T0, typename T1, typename T2, typename T3, typename T4 > -inline void unwrapArgsBaseline( +void unwrapArgsBaseline( ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any > const& seq, T0& v0, T1& v1, T2& v2, T3& v3, T4& v4, ::com::sun::star::uno::Reference< diff --git a/comphelper/source/misc/anytostring.cxx b/comphelper/source/misc/anytostring.cxx index 51257fe3c414..37242356e12b 100644 --- a/comphelper/source/misc/anytostring.cxx +++ b/comphelper/source/misc/anytostring.cxx @@ -36,7 +36,7 @@ void appendTypeError( buf.append( '>' ); } -inline void appendChar( OUStringBuffer & buf, sal_Unicode c ) +void appendChar( OUStringBuffer & buf, sal_Unicode c ) { if (c < ' ' || c > '~') { buf.append( "\\X" ); |