loplugin:finalclasses in comphelper

convert ServiceInfoHelper to a namespace, since the only usage is to
call it's static method

Change-Id: I908bdbc06cbdb6b72ee1ae469ff207b2fca69963
Reviewed-on: https://gerrit.libreoffice.org/44533
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 2 insertions, 17 deletions

diff --git a/comphelper/source/misc/serviceinfohelper.cxx b/comphelper/source/misc/serviceinfohelper.cxx
index 87f4c343c3f9..8e70ebcc142d 100644
--- a/comphelper/source/misc/serviceinfohelper.cxx
+++ b/comphelper/source/misc/serviceinfohelper.cxx
@@ -25,19 +25,6 @@
 namespace comphelper
 {
 
-/** returns an empty UString(). most times sufficient */
-OUString SAL_CALL ServiceInfoHelper::getImplementationName()
-{
-    return OUString();
-}
-
-/** the base implementation has no supported services */
-css::uno::Sequence< OUString > ServiceInfoHelper::getSupportedServiceNames()
-{
-    css::uno::Sequence< OUString> aSeq(0);
-    return aSeq;
-}
-
 /** this method adds a variable number of OUString to a given Sequence
  */
 void ServiceInfoHelper::addToSequence( css::uno::Sequence< OUString >& rSeq, std::initializer_list<OUString> services ) throw()
diff --git a/comphelper/source/property/opropertybag.hxx b/comphelper/source/property/opropertybag.hxx
index 95736d7923db..956657a33910 100644
--- a/comphelper/source/property/opropertybag.hxx
+++ b/comphelper/source/property/opropertybag.hxx
@@ -66,7 +66,7 @@ namespace comphelper
                                         >   OPropertyBag_Base;
     typedef ::comphelper::OPropertyStateHelper  OPropertyBag_PBase;
 
-    class OPropertyBag  :public ::comphelper::OMutexAndBroadcastHelper  // must be before OPropertyBag_PBase
+    class OPropertyBag final : public ::comphelper::OMutexAndBroadcastHelper  // must be before OPropertyBag_PBase
                         ,public OPropertyBag_PBase
                         ,public OPropertyBag_Base
                         ,public ::cppu::IEventNotificationHook
@@ -94,7 +94,7 @@ namespace comphelper
         OPropertyBag();
         virtual ~OPropertyBag() override;
 
-    protected:
+    private:
         DECLARE_XINTERFACE()
         DECLARE_XTYPEPROVIDER()
 
@@ -177,7 +177,6 @@ namespace comphelper
         void SAL_CALL setModifiedImpl( bool bModified,
             bool bIgnoreRuntimeExceptionsWhileFiring);
 
-    private:
         /** finds a free property handle
             @precond
                 our mutex is locked
@@ -210,7 +209,6 @@ namespace comphelper
         */
         void impl_setPropertyValues_throw( const css::uno::Sequence< css::beans::PropertyValue >& _rProps );
 
-    protected:
         using ::cppu::OPropertySetHelper::getPropertyValues;
         using ::cppu::OPropertySetHelper::setPropertyValues;
         using ::cppu::OPropertySetHelper::getFastPropertyValue;