diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-02 10:40:26 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-03 10:51:57 +0200 |
commit | 054c0e7177cbef26942f8ca7cb7b1422ceea721c (patch) | |
tree | 7390a1be5ee0797b7f43d7d433822315fd75c6dd /comphelper | |
parent | 0f499af8c2c22ccc8f1c19edeeb2bdac8cbcb7f0 (diff) |
loplugin:simplifypointertobool improve
to look for the
x.get() != null
pattern, which can be simplified to
x
I'll do the
x.get() == nullptr
pattern in a separate patch, to reduce the chances of a mistake
Change-Id: I45e0d178e75359857cdf50d712039cb526016555
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'comphelper')
-rw-r--r-- | comphelper/source/misc/configuration.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/comphelper/source/misc/configuration.cxx b/comphelper/source/misc/configuration.cxx index 6c5b5c41dac3..24657ab011f5 100644 --- a/comphelper/source/misc/configuration.cxx +++ b/comphelper/source/misc/configuration.cxx @@ -140,7 +140,7 @@ void comphelper::detail::ConfigurationWrapper::setPropertyValue( std::shared_ptr< ConfigurationChanges > const & batch, OUString const & path, css::uno::Any const & value) { - assert(batch.get() != nullptr); + assert(batch); batch->setPropertyValue(path, value); } @@ -156,7 +156,7 @@ void comphelper::detail::ConfigurationWrapper::setLocalizedPropertyValue( std::shared_ptr< ConfigurationChanges > const & batch, OUString const & path, css::uno::Any const & value) { - assert(batch.get() != nullptr); + assert(batch); batch->setPropertyValue(path, value); } @@ -176,7 +176,7 @@ comphelper::detail::ConfigurationWrapper::getGroupReadWrite( std::shared_ptr< ConfigurationChanges > const & batch, OUString const & path) { - assert(batch.get() != nullptr); + assert(batch); return batch->getGroup(path); } @@ -196,7 +196,7 @@ comphelper::detail::ConfigurationWrapper::getSetReadWrite( std::shared_ptr< ConfigurationChanges > const & batch, OUString const & path) { - assert(batch.get() != nullptr); + assert(batch); return batch->getSet(path); } |