path: root/chart2
diff options
authorMichael Stahl <>2019-05-10 11:45:27 +0200
committerMichael Stahl <>2019-05-10 18:40:21 +0200
commiteb8e03006d588f2d953c4fba4e47ced9b53ba6aa (patch)
treec8286ed3c8d4c723ada21326401ba67a91d952e3 /chart2
parentc1486533818de626378ec67afa49845da164d00c (diff)
tdf#125164 sw: reimplement SwUndoTOXChange
SwUndoTOXChange was effectively dead code since commit 60732d715698108f9c3a8284bb3e00baaa4e8124 "#i42807# clear undo stack before changing of TOX properties, update TOX after changing properties" and was resurrected by commit 4f0b568ef35353b276ae560fb43502b6f6b2bfdb. * Calling Update() from Undo is wrong, as there is no guarantee that the index was up-to-date before the change * Calling Update() from Redo is pointless, as there will be a Redo of SwUndoUpdateIndex anyway, given that the only caller of ChangeTOX, namely, SwTOXMgr::UpdateOrInsertTOX(), does that * SwUndoTOXChange cannot retain a pointer to SwTOXBase as its life-time is tied to the SwSectionNode * Repeat applying the same attributes to the same ToX is utterly pointless Change-Id: I84a9de3176d1062d1a43acbc9270c547fde7936a Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
Diffstat (limited to 'chart2')
0 files changed, 0 insertions, 0 deletions