summaryrefslogtreecommitdiff
path: root/chart2
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2016-07-07 15:55:56 +0200
committerStephan Bergmann <sbergman@redhat.com>2016-07-07 18:59:55 +0200
commitd956a5d29e68a9d89d31459bc891cfb260daa0c8 (patch)
tree034ecde3f22f0e240f0aec9daff5b9282a370dae /chart2
parent0b424c25066cc9c9bc7f72ce56096933eee6feab (diff)
loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I5c973d41381f2bfd39e7a8cf48fd5807852bdc72
Diffstat (limited to 'chart2')
-rw-r--r--chart2/qa/extras/chart2export.cxx22
-rw-r--r--chart2/qa/extras/chart2import.cxx2
-rw-r--r--chart2/qa/extras/charttest.hxx14
-rw-r--r--chart2/source/controller/dialogs/DataBrowserModel.hxx4
-rw-r--r--chart2/source/controller/sidebar/ChartColorWrapper.cxx2
-rw-r--r--chart2/source/controller/sidebar/ChartColorWrapper.hxx2
-rw-r--r--chart2/source/view/inc/AbstractShapeFactory.hxx2
-rw-r--r--chart2/source/view/inc/ShapeFactory.hxx2
-rw-r--r--chart2/source/view/main/DummyXShape.cxx2
-rw-r--r--chart2/source/view/main/DummyXShape.hxx2
10 files changed, 27 insertions, 27 deletions
diff --git a/chart2/qa/extras/chart2export.cxx b/chart2/qa/extras/chart2export.cxx
index a10e8a89b3c7..846daa78b34d 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -200,7 +200,7 @@ public:
}
};
-OUString findChartFile(const OUString& rDir, uno::Reference< container::XNameAccess > xNames )
+OUString findChartFile(const OUString& rDir, uno::Reference< container::XNameAccess > const & xNames )
{
uno::Sequence<OUString> rNames = xNames->getElementNames();
OUString* pElement = std::find_if(rNames.begin(), rNames.end(), CheckForChartName(rDir));
@@ -253,7 +253,7 @@ void Chart2ExportTest::registerNamespaces(xmlXPathContextPtr& pXmlXPathCtx)
namespace {
-void testErrorBar( Reference< XPropertySet > xErrorBar )
+void testErrorBar( Reference< XPropertySet > const & xErrorBar )
{
sal_Int32 nErrorBarStyle;
CPPUNIT_ASSERT(
@@ -272,7 +272,7 @@ void testErrorBar( Reference< XPropertySet > xErrorBar )
}
void checkCommonTrendline(
- Reference<chart2::XRegressionCurve> xCurve,
+ Reference<chart2::XRegressionCurve> const & xCurve,
double aExpectedExtrapolateForward, double aExpectedExtrapolateBackward,
bool aExpectedForceIntercept, double aExpectedInterceptValue,
bool aExpectedShowEquation, bool aExpectedR2)
@@ -311,7 +311,7 @@ void checkCommonTrendline(
CPPUNIT_ASSERT_EQUAL(aExpectedR2, bShowCorrelationCoefficient);
}
-void checkNameAndType(Reference<XPropertySet> xProperties, const OUString& aExpectedName, const OUString& aExpectedServiceName)
+void checkNameAndType(Reference<XPropertySet> const & xProperties, const OUString& aExpectedName, const OUString& aExpectedServiceName)
{
Reference< lang::XServiceName > xServiceName( xProperties, UNO_QUERY );
CPPUNIT_ASSERT(xServiceName.is());
@@ -325,7 +325,7 @@ void checkNameAndType(Reference<XPropertySet> xProperties, const OUString& aExpe
}
void checkLinearTrendline(
- Reference<chart2::XRegressionCurve> xCurve, const OUString& aExpectedName,
+ Reference<chart2::XRegressionCurve> const & xCurve, const OUString& aExpectedName,
double aExpectedExtrapolateForward, double aExpectedExtrapolateBackward,
bool aExpectedForceIntercept, double aExpectedInterceptValue,
bool aExpectedShowEquation, bool aExpectedR2)
@@ -343,7 +343,7 @@ void checkLinearTrendline(
}
void checkPolynomialTrendline(
- Reference<chart2::XRegressionCurve> xCurve, const OUString& aExpectedName,
+ Reference<chart2::XRegressionCurve> const & xCurve, const OUString& aExpectedName,
sal_Int32 aExpectedDegree,
double aExpectedExtrapolateForward, double aExpectedExtrapolateBackward,
bool aExpectedForceIntercept, double aExpectedInterceptValue,
@@ -366,7 +366,7 @@ void checkPolynomialTrendline(
}
void checkMovingAverageTrendline(
- Reference<chart2::XRegressionCurve> xCurve, const OUString& aExpectedName, sal_Int32 aExpectedPeriod)
+ Reference<chart2::XRegressionCurve> const & xCurve, const OUString& aExpectedName, sal_Int32 aExpectedPeriod)
{
Reference<XPropertySet> xProperties( xCurve , uno::UNO_QUERY );
CPPUNIT_ASSERT(xProperties.is());
@@ -378,7 +378,7 @@ void checkMovingAverageTrendline(
CPPUNIT_ASSERT_EQUAL(aExpectedPeriod, aPeriod);
}
-void checkTrendlinesInChart(uno::Reference< chart2::XChartDocument > xChartDoc)
+void checkTrendlinesInChart(uno::Reference< chart2::XChartDocument > const & xChartDoc)
{
CPPUNIT_ASSERT(xChartDoc.is());
@@ -1148,7 +1148,7 @@ void Chart2ExportTest::testEmbeddingsOleObjectGrabBag()
namespace {
-void checkGapWidth(Reference<beans::XPropertySet> xPropSet, sal_Int32 nValue)
+void checkGapWidth(Reference<beans::XPropertySet> const & xPropSet, sal_Int32 nValue)
{
uno::Any aAny = xPropSet->getPropertyValue("GapwidthSequence");
CPPUNIT_ASSERT(aAny.hasValue());
@@ -1158,7 +1158,7 @@ void checkGapWidth(Reference<beans::XPropertySet> xPropSet, sal_Int32 nValue)
CPPUNIT_ASSERT_EQUAL(nValue, aSequence[0]);
}
-void checkOverlap(Reference<beans::XPropertySet> xPropSet, sal_Int32 nValue)
+void checkOverlap(Reference<beans::XPropertySet> const & xPropSet, sal_Int32 nValue)
{
uno::Any aAny = xPropSet->getPropertyValue("OverlapSequence");
CPPUNIT_ASSERT(aAny.hasValue());
@@ -1168,7 +1168,7 @@ void checkOverlap(Reference<beans::XPropertySet> xPropSet, sal_Int32 nValue)
CPPUNIT_ASSERT_EQUAL(nValue, aSequence[0]);
}
-void checkSheetForGapWidthAndOverlap(uno::Reference< chart2::XChartDocument > xChartDoc,
+void checkSheetForGapWidthAndOverlap(uno::Reference< chart2::XChartDocument > const & xChartDoc,
sal_Int32 nExpectedGapWidth, sal_Int32 nExpectedOverlap)
{
CPPUNIT_ASSERT(xChartDoc.is());
diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx
index 75b0f9c474c4..a97b228230e1 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -289,7 +289,7 @@ void Chart2ImportTest::testSteppedLines()
}
}
-uno::Sequence < OUString > getChartColumnDescriptions( uno::Reference< chart::XChartDocument > xChart1Doc)
+uno::Sequence < OUString > getChartColumnDescriptions( uno::Reference< chart::XChartDocument > const & xChart1Doc)
{
CPPUNIT_ASSERT(xChart1Doc.is());
uno::Reference< chart::XChartDataArray > xChartData ( xChart1Doc->getData(), UNO_QUERY_THROW);
diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx
index 6f944324e5d1..aaa46cb4fa79 100644
--- a/chart2/qa/extras/charttest.hxx
+++ b/chart2/qa/extras/charttest.hxx
@@ -175,7 +175,7 @@ void ChartTest::tearDown()
}
-Reference< lang::XComponent > getChartCompFromSheet( sal_Int32 nSheet, uno::Reference< lang::XComponent > xComponent )
+Reference< lang::XComponent > getChartCompFromSheet( sal_Int32 nSheet, uno::Reference< lang::XComponent > const & xComponent )
{
// let us assume that we only have one chart per sheet
@@ -205,14 +205,14 @@ Reference< lang::XComponent > getChartCompFromSheet( sal_Int32 nSheet, uno::Refe
}
-Reference< chart2::XChartDocument > getChartDocFromSheet( sal_Int32 nSheet, uno::Reference< lang::XComponent > xComponent )
+Reference< chart2::XChartDocument > getChartDocFromSheet( sal_Int32 nSheet, uno::Reference< lang::XComponent > const & xComponent )
{
uno::Reference< chart2::XChartDocument > xChartDoc ( getChartCompFromSheet(nSheet, xComponent), UNO_QUERY_THROW );
CPPUNIT_ASSERT(xChartDoc.is());
return xChartDoc;
}
-Reference< chart2::XChartType > getChartTypeFromDoc( Reference< chart2::XChartDocument > xChartDoc,
+Reference< chart2::XChartType > getChartTypeFromDoc( Reference< chart2::XChartDocument > const & xChartDoc,
sal_Int32 nChartType, sal_Int32 nCooSys = 0 )
{
CPPUNIT_ASSERT( xChartDoc.is() );
@@ -256,7 +256,7 @@ Reference<chart2::XAxis> getAxisFromDoc(
return xAxis;
}
-Reference< chart2::XDataSeries > getDataSeriesFromDoc( uno::Reference< chart2::XChartDocument > xChartDoc,
+Reference< chart2::XDataSeries > getDataSeriesFromDoc( uno::Reference< chart2::XChartDocument > const & xChartDoc,
sal_Int32 nDataSeries, sal_Int32 nChartType = 0, sal_Int32 nCooSys = 0 )
{
Reference< chart2::XChartType > xChartType = getChartTypeFromDoc( xChartDoc, nChartType, nCooSys );
@@ -272,7 +272,7 @@ Reference< chart2::XDataSeries > getDataSeriesFromDoc( uno::Reference< chart2::X
}
Reference< chart2::data::XDataSequence > getLabelDataSequenceFromDoc(
- Reference< chart2::XChartDocument > xChartDoc,
+ Reference< chart2::XChartDocument > const & xChartDoc,
sal_Int32 nDataSeries = 0, sal_Int32 nChartType = 0 )
{
Reference< chart2::XDataSeries > xDataSeries =
@@ -295,7 +295,7 @@ Reference< chart2::data::XDataSequence > getLabelDataSequenceFromDoc(
}
Reference< chart2::data::XDataSequence > getDataSequenceFromDocByRole(
- Reference< chart2::XChartDocument > xChartDoc, const OUString& rRole,
+ Reference< chart2::XChartDocument > const & xChartDoc, const OUString& rRole,
sal_Int32 nDataSeries = 0, sal_Int32 nChartType = 0 )
{
Reference< chart2::XDataSeries > xDataSeries =
@@ -321,7 +321,7 @@ Reference< chart2::data::XDataSequence > getDataSequenceFromDocByRole(
return Reference< chart2::data::XDataSequence > ();
}
-uno::Sequence < OUString > getWriterChartColumnDescriptions( Reference< lang::XComponent > mxComponent )
+uno::Sequence < OUString > getWriterChartColumnDescriptions( Reference< lang::XComponent > const & mxComponent )
{
uno::Reference<drawing::XDrawPageSupplier> xDrawPageSupplier(mxComponent, uno::UNO_QUERY);
uno::Reference<drawing::XDrawPage> xDrawPage = xDrawPageSupplier->getDrawPage();
diff --git a/chart2/source/controller/dialogs/DataBrowserModel.hxx b/chart2/source/controller/dialogs/DataBrowserModel.hxx
index 2f8137696ff4..c57d4ef320bf 100644
--- a/chart2/source/controller/dialogs/DataBrowserModel.hxx
+++ b/chart2/source/controller/dialogs/DataBrowserModel.hxx
@@ -109,8 +109,8 @@ public:
{}
// "full" CTOR
tDataHeader(
- css::uno::Reference< css::chart2::XDataSeries > xDataSeries,
- css::uno::Reference< css::chart2::XChartType > xChartType,
+ css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries,
+ css::uno::Reference< css::chart2::XChartType > const &xChartType,
bool bSwapXAndYAxis,
sal_Int32 nStartColumn,
sal_Int32 nEndColumn ) :
diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.cxx b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
index 6172939bf849..4b2c7694e14d 100644
--- a/chart2/source/controller/sidebar/ChartColorWrapper.cxx
+++ b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
@@ -60,7 +60,7 @@ css::uno::Reference<css::beans::XPropertySet> getPropSet(
}
ChartColorWrapper::ChartColorWrapper(
- css::uno::Reference<css::frame::XModel> xModel,
+ css::uno::Reference<css::frame::XModel> const & xModel,
SvxColorToolBoxControl* pControl,
const OUString& rName):
mxModel(xModel),
diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.hxx b/chart2/source/controller/sidebar/ChartColorWrapper.hxx
index 4fcfb7d96a0a..68fb5141b564 100644
--- a/chart2/source/controller/sidebar/ChartColorWrapper.hxx
+++ b/chart2/source/controller/sidebar/ChartColorWrapper.hxx
@@ -22,7 +22,7 @@ class ChartColorWrapper
private:
public:
- ChartColorWrapper(css::uno::Reference<css::frame::XModel> xModel,
+ ChartColorWrapper(css::uno::Reference<css::frame::XModel> const & xModel,
SvxColorToolBoxControl* pControl,
const OUString& rPropertyName);
diff --git a/chart2/source/view/inc/AbstractShapeFactory.hxx b/chart2/source/view/inc/AbstractShapeFactory.hxx
index c1a402c8955f..8d988bee27c0 100644
--- a/chart2/source/view/inc/AbstractShapeFactory.hxx
+++ b/chart2/source/view/inc/AbstractShapeFactory.hxx
@@ -64,7 +64,7 @@ protected:
public:
enum StackPosition { Top, Bottom };
- void setShapeFactory(css::uno::Reference< css::lang::XMultiServiceFactory> xFactory)
+ void setShapeFactory(css::uno::Reference< css::lang::XMultiServiceFactory> const & xFactory)
{ m_xShapeFactory = xFactory; }
static AbstractShapeFactory* getOrCreateShapeFactory(const css::uno::Reference< css::lang::XMultiServiceFactory>& xFactory);
diff --git a/chart2/source/view/inc/ShapeFactory.hxx b/chart2/source/view/inc/ShapeFactory.hxx
index 448515bcb277..8083411de00d 100644
--- a/chart2/source/view/inc/ShapeFactory.hxx
+++ b/chart2/source/view/inc/ShapeFactory.hxx
@@ -28,7 +28,7 @@ class ShapeFactory : public AbstractShapeFactory
{
friend class AbstractShapeFactory;
- ShapeFactory(css::uno::Reference< css::lang::XMultiServiceFactory> xFactory)
+ ShapeFactory(css::uno::Reference< css::lang::XMultiServiceFactory> const & xFactory)
{m_xShapeFactory = xFactory;}
public:
diff --git a/chart2/source/view/main/DummyXShape.cxx b/chart2/source/view/main/DummyXShape.cxx
index f3cc72c2a91f..e926557e3635 100644
--- a/chart2/source/view/main/DummyXShape.cxx
+++ b/chart2/source/view/main/DummyXShape.cxx
@@ -794,7 +794,7 @@ private:
}
DummyText::DummyText(const OUString& rText, const tNameSequence& rNames,
- const tAnySequence& rValues, const uno::Any& rTrans, uno::Reference< drawing::XShapes > xTarget, double nRotation ):
+ const tAnySequence& rValues, const uno::Any& rTrans, uno::Reference< drawing::XShapes > const & xTarget, double nRotation ):
maText(rText),
maTrans(rTrans),
mnRotation(nRotation)
diff --git a/chart2/source/view/main/DummyXShape.hxx b/chart2/source/view/main/DummyXShape.hxx
index 09a953ad9948..624a25c73870 100644
--- a/chart2/source/view/main/DummyXShape.hxx
+++ b/chart2/source/view/main/DummyXShape.hxx
@@ -307,7 +307,7 @@ class DummyText : public DummyXShape
public:
DummyText(const OUString& rText, const tNameSequence& rNames,
const tAnySequence& rValues, const css::uno::Any& rTrans, css::uno::Reference<
- css::drawing::XShapes > xTarget, double nRotation);
+ css::drawing::XShapes > const & xTarget, double nRotation);
virtual void render() override;