Resolves: tdf#121246 crash in chart dialogs

Change-Id: I3bc720e44f5ea15749e6bc0f0fada3a17a783e23
Reviewed-on: https://gerrit.libreoffice.org/63463
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1 files changed, 93 insertions, 75 deletions

diff --git a/chart2/uiconfig/ui/tp_Scale.ui b/chart2/uiconfig/ui/tp_Scale.ui
index 5257efc7cc7f..6b5b1cf195c1 100644
--- a/chart2/uiconfig/ui/tp_Scale.ui
+++ b/chart2/uiconfig/ui/tp_Scale.ui
@@ -1,34 +1,38 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!-- Generated with glade 3.22.1 -->
 <interface domain="chart">
   <requires lib="gtk+" version="3.18"/>
-  <requires lib="LibreOffice" version="1.0"/>
+  <object class="GtkAdjustment" id="adjustment1">
+    <property name="upper">100</property>
+    <property name="step_increment">1</property>
+    <property name="page_increment">10</property>
+  </object>
+  <object class="GtkAdjustment" id="adjustment2">
+    <property name="upper">100</property>
+    <property name="step_increment">1</property>
+    <property name="page_increment">10</property>
+  </object>
+  <object class="GtkAdjustment" id="adjustment3">
+    <property name="upper">100</property>
+    <property name="step_increment">1</property>
+    <property name="page_increment">10</property>
+  </object>
+  <object class="GtkAdjustment" id="adjustment4">
+    <property name="upper">100</property>
+    <property name="step_increment">1</property>
+    <property name="page_increment">10</property>
+  </object>
   <object class="GtkAdjustment" id="adjustmentINTERVAL">
     <property name="lower">1</property>
     <property name="upper">100</property>
     <property name="step_increment">1</property>
     <property name="page_increment">10</property>
   </object>
-  <object class="GtkListStore" id="liststoreDATE">
-    <columns>
-      <!-- column-name gchararray1 -->
-      <column type="gchararray"/>
-      <!-- column-name guint1 -->
-      <column type="guint"/>
-    </columns>
-    <data>
-      <row>
-        <col id="0" translatable="yes" context="tp_Scale|liststoreDATE">Days</col>
-        <col id="1">0</col>
-      </row>
-      <row>
-        <col id="0" translatable="yes" context="tp_Scale|liststoreDATE">Months</col>
-        <col id="1">1</col>
-      </row>
-      <row>
-        <col id="0" translatable="yes" context="tp_Scale|liststoreDATE">Years</col>
-        <col id="1">2</col>
-      </row>
-    </data>
+  <object class="GtkAdjustment" id="adjustmentINTERVAL1">
+    <property name="lower">1</property>
+    <property name="upper">100</property>
+    <property name="step_increment">1</property>
+    <property name="page_increment">10</property>
   </object>
   <object class="GtkFrame" id="tp_Scale">
     <property name="visible">True</property>
@@ -58,7 +62,7 @@
                   <object class="GtkCheckButton" id="CBX_REVERSE">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_REVERSE">_Reverse direction</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -74,7 +78,7 @@
                   <object class="GtkCheckButton" id="CBX_LOGARITHM">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_LOGARITHM">_Logarithmic scale</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -95,10 +99,10 @@
                       <object class="GtkLabel" id="TXT_AXIS_TYPE">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="xalign">0</property>
                         <property name="label" translatable="yes" context="tp_Scale|TXT_AXIS_TYPE">T_ype</property>
                         <property name="use_underline">True</property>
                         <property name="mnemonic_widget">LB_AXIS_TYPE</property>
+                        <property name="xalign">0</property>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -110,8 +114,6 @@
                       <object class="GtkComboBoxText" id="LB_AXIS_TYPE">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="entry_text_column">0</property>
-                        <property name="id_column">1</property>
                         <items>
                           <item translatable="yes" context="tp_Scale|LB_AXIS_TYPE">Automatic</item>
                           <item translatable="yes" context="tp_Scale|LB_AXIS_TYPE">Text</item>
@@ -148,39 +150,35 @@
                   <object class="GtkLabel" id="TXT_MIN">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <property name="xalign">0</property>
                     <property name="label" translatable="yes" context="tp_Scale|TXT_MIN">_Minimum</property>
                     <property name="use_underline">True</property>
                     <property name="mnemonic_widget">EDT_MIN</property>
+                    <property name="xalign">0</property>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
                     <property name="top_attach">0</property>
-                    <property name="width">1</property>
-                    <property name="height">1</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkLabel" id="TXT_MAX">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <property name="xalign">0</property>
                     <property name="label" translatable="yes" context="tp_Scale|TXT_MAX">Ma_ximum</property>
                     <property name="use_underline">True</property>
                     <property name="mnemonic_widget">EDT_MAX</property>
+                    <property name="xalign">0</property>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
                     <property name="top_attach">1</property>
-                    <property name="width">1</property>
-                    <property name="height">1</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkCheckButton" id="CBX_AUTO_MIN">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_AUTO_MIN">_Automatic</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -189,15 +187,13 @@
                   <packing>
                     <property name="left_attach">2</property>
                     <property name="top_attach">0</property>
-                    <property name="width">1</property>
-                    <property name="height">1</property>
                   </packing>
                 </child>
                 <child>
                   <object class="GtkCheckButton" id="CBX_AUTO_MAX">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_AUTO_MAX">A_utomatic</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -206,32 +202,32 @@
                   <packing>
                     <property name="left_attach">2</property>
                     <property name="top_attach">1</property>
-                    <property name="width">1</property>
-                    <property name="height">1</property>
                   </packing>
                 </child>
                 <child>
-                  <object class="svtlo-FormattedField" id="EDT_MIN">
+                  <object class="GtkSpinButton" id="EDT_MIN">
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
+                    <property name="activates_default">True</property>
+                    <property name="width_chars">10</property>
+                    <property name="adjustment">adjustment1</property>
                   </object>
                   <packing>
                     <property name="left_attach">1</property>
                     <property name="top_attach">0</property>
-                    <property name="width">1</property>
-                    <property name="height">1</property>
                   </packing>
                 </child>
                 <child>
-                  <object class="svtlo-FormattedField" id="EDT_MAX">
+                  <object class="GtkSpinButton" id="EDT_MAX">
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
+                    <property name="activates_default">True</property>
+                    <property name="width_chars">10</property>
+                    <property name="adjustment">adjustment2</property>
                   </object>
                   <packing>
                     <property name="left_attach">1</property>
                     <property name="top_attach">1</property>
-                    <property name="width">1</property>
-                    <property name="height">1</property>
                   </packing>
                 </child>
               </object>
@@ -250,10 +246,10 @@
                   <object class="GtkLabel" id="TXT_TIME_RESOLUTION">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <property name="xalign">0</property>
                     <property name="label" translatable="yes" context="tp_Scale|TXT_TIME_RESOLUTION">R_esolution</property>
                     <property name="use_underline">True</property>
                     <property name="mnemonic_widget">LB_TIME_RESOLUTION</property>
+                    <property name="xalign">0</property>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -262,10 +258,14 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="GtkComboBox" id="LB_TIME_RESOLUTION">
+                  <object class="GtkComboBoxText" id="LB_TIME_RESOLUTION">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <property name="model">liststoreDATE</property>
+                    <items>
+                      <item id="0" translatable="yes" context="tp_Scale|liststoreDATE">Days</item>
+                      <item id="1" translatable="yes" context="tp_Scale|liststoreDATE">Months</item>
+                      <item id="2" translatable="yes" context="tp_Scale|liststoreDATE">Years</item>
+                    </items>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -277,7 +277,7 @@
                   <object class="GtkCheckButton" id="CBX_AUTO_TIME_RESOLUTION">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_AUTO_TIME_RESOLUTION">Automat_ic</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -305,9 +305,9 @@
                   <object class="GtkLabel" id="TXT_STEP_MAIN">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <property name="xalign">0</property>
                     <property name="label" translatable="yes" context="tp_Scale|TXT_STEP_MAIN">Ma_jor interval</property>
                     <property name="use_underline">True</property>
+                    <property name="xalign">0</property>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -326,9 +326,11 @@
                         <property name="can_focus">False</property>
                         <property name="spacing">12</property>
                         <child>
-                          <object class="GtkSpinButton" id="MT_MAIN_DATE_STEP:0">
+                          <object class="GtkSpinButton" id="MT_MAIN_DATE_STEP">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
+                            <property name="can_focus">True</property>
+                            <property name="activates_default">True</property>
+                            <property name="width_chars">10</property>
                             <property name="adjustment">adjustmentINTERVAL</property>
                           </object>
                           <packing>
@@ -338,10 +340,14 @@
                           </packing>
                         </child>
                         <child>
-                          <object class="GtkComboBox" id="LB_MAIN_TIME_UNIT">
+                          <object class="GtkComboBoxText" id="LB_MAIN_TIME_UNIT">
                             <property name="visible">True</property>
                             <property name="can_focus">False</property>
-                            <property name="model">liststoreDATE</property>
+                            <items>
+                              <item id="0" translatable="yes" context="tp_Scale|liststoreDATE">Days</item>
+                              <item id="1" translatable="yes" context="tp_Scale|liststoreDATE">Months</item>
+                              <item id="2" translatable="yes" context="tp_Scale|liststoreDATE">Years</item>
+                            </items>
                           </object>
                           <packing>
                             <property name="expand">False</property>
@@ -357,9 +363,12 @@
                       </packing>
                     </child>
                     <child>
-                      <object class="svtlo-FormattedField" id="EDT_STEP_MAIN">
+                      <object class="GtkSpinButton" id="EDT_STEP_MAIN">
                         <property name="visible">True</property>
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
+                        <property name="activates_default">True</property>
+                        <property name="width_chars">10</property>
+                        <property name="adjustment">adjustment4</property>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -378,7 +387,7 @@
                   <object class="GtkCheckButton" id="CBX_AUTO_STEP_MAIN">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_AUTO_STEP_MAIN">Au_tomatic</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -411,9 +420,9 @@
                       <object class="GtkLabel" id="TXT_STEP_HELP">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="xalign">0</property>
                         <property name="label" translatable="yes" context="tp_Scale|TXT_STEP_HELP">Minor inter_val</property>
                         <property name="use_underline">True</property>
+                        <property name="xalign">0</property>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -425,9 +434,9 @@
                       <object class="GtkLabel" id="TXT_STEP_HELP_COUNT">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="xalign">0</property>
                         <property name="label" translatable="yes" context="tp_Scale|TXT_STEP_HELP_COUNT">Minor inter_val count</property>
                         <property name="use_underline">True</property>
+                        <property name="xalign">0</property>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -443,10 +452,12 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="GtkSpinButton" id="MT_STEPHELP:0">
+                  <object class="GtkSpinButton" id="MT_STEPHELP">
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
-                    <property name="adjustment">adjustmentINTERVAL</property>
+                    <property name="can_focus">True</property>
+                    <property name="activates_default">True</property>
+                    <property name="width_chars">10</property>
+                    <property name="adjustment">adjustmentINTERVAL1</property>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -455,10 +466,14 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="GtkComboBox" id="LB_HELP_TIME_UNIT">
+                  <object class="GtkComboBoxText" id="LB_HELP_TIME_UNIT">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <property name="model">liststoreDATE</property>
+                    <items>
+                      <item id="0" translatable="yes" context="tp_Scale|liststoreDATE">Days</item>
+                      <item id="1" translatable="yes" context="tp_Scale|liststoreDATE">Months</item>
+                      <item id="2" translatable="yes" context="tp_Scale|liststoreDATE">Years</item>
+                    </items>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -470,7 +485,7 @@
                   <object class="GtkCheckButton" id="CBX_AUTO_STEP_HELP">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_AUTO_STEP_HELP">Aut_omatic</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -498,9 +513,9 @@
                   <object class="GtkLabel" id="TXT_ORIGIN">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
-                    <property name="xalign">0</property>
                     <property name="label" translatable="yes" context="tp_Scale|TXT_ORIGIN">Re_ference value</property>
                     <property name="use_underline">True</property>
+                    <property name="xalign">0</property>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -509,9 +524,12 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="svtlo-FormattedField" id="EDT_ORIGIN:0">
+                  <object class="GtkSpinButton" id="EDT_ORIGIN">
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
+                    <property name="activates_default">True</property>
+                    <property name="width_chars">10</property>
+                    <property name="adjustment">adjustment3</property>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -523,7 +541,7 @@
                   <object class="GtkCheckButton" id="CBX_AUTO_ORIGIN">
                     <property name="label" translatable="yes" context="tp_Scale|CBX_AUTO_ORIGIN">Automat_ic</property>
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="receives_default">False</property>
                     <property name="use_underline">True</property>
                     <property name="xalign">0</property>
@@ -550,8 +568,8 @@
       <object class="GtkLabel" id="FL_SCALE">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
-        <property name="xalign">0</property>
         <property name="label" translatable="yes" context="tp_Scale|FL_SCALE">Scale</property>
+        <property name="xalign">0</property>
         <attributes>
           <attribute name="weight" value="bold"/>
         </attributes>
@@ -563,10 +581,10 @@
       <widget name="LB_AXIS_TYPE"/>
       <widget name="EDT_MIN"/>
       <widget name="EDT_MAX"/>
-      <widget name="MT_MAIN_DATE_STEP:0"/>
+      <widget name="MT_MAIN_DATE_STEP"/>
       <widget name="EDT_STEP_MAIN"/>
-      <widget name="MT_STEPHELP:0"/>
-      <widget name="EDT_ORIGIN:0"/>
+      <widget name="MT_STEPHELP"/>
+      <widget name="EDT_ORIGIN"/>
       <widget name="LB_TIME_RESOLUTION"/>
       <widget name="LB_MAIN_TIME_UNIT"/>
       <widget name="LB_HELP_TIME_UNIT"/>