summaryrefslogtreecommitdiff
path: root/canvas/source/tools
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-12-25 19:21:12 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-12-26 07:16:07 +0100
commitc54d34f70819c5928fe30585e86d744eda4a254a (patch)
tree81672bb2fd4c95cb09a6ed14197c8a0a8655dcb5 /canvas/source/tools
parent09895ae4963850c05d7a315599195dd177f13b06 (diff)
loplugin:passstuffbyref improved return in canvas and svtools
and for now, ignore methods with params so we don't fall into the trap of thinking that calls to methods like: Bar& foo(Bar &p) { return p; } can be converted from Bar f() { return foo(Bar()); } to Bar const & f() { return foo(Bar()); } Change-Id: Ia3795eb2baf353cb6bec4ebf40451f2789d66ad7 Reviewed-on: https://gerrit.libreoffice.org/47034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'canvas/source/tools')
-rw-r--r--canvas/source/tools/canvastools.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/canvas/source/tools/canvastools.cxx b/canvas/source/tools/canvastools.cxx
index d1155243275c..477ba03b3703 100644
--- a/canvas/source/tools/canvastools.cxx
+++ b/canvas/source/tools/canvastools.cxx
@@ -863,12 +863,12 @@ namespace canvas
};
}
- uno::Reference<rendering::XIntegerBitmapColorSpace> getStdColorSpace()
+ uno::Reference<rendering::XIntegerBitmapColorSpace> const & getStdColorSpace()
{
return StandardColorSpaceHolder::get();
}
- uno::Reference<rendering::XIntegerBitmapColorSpace> getStdColorSpaceWithoutAlpha()
+ uno::Reference<rendering::XIntegerBitmapColorSpace> const & getStdColorSpaceWithoutAlpha()
{
return StandardNoAlphaColorSpaceHolder::get();
}