summaryrefslogtreecommitdiff
path: root/binaryurp
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2012-03-08 14:22:25 +0100
committerStephan Bergmann <sbergman@redhat.com>2012-03-08 14:22:54 +0100
commit672ad9493a484a606df2f546caf98a7a7355fe31 (patch)
tree789685e8906b9fe38246eb7b5b7f446541c4d726 /binaryurp
parentee67c55260ec7723c39606955ccdbd3e2934935a (diff)
Clarifying comment added
Diffstat (limited to 'binaryurp')
-rw-r--r--binaryurp/source/bridge.cxx6
1 files changed, 6 insertions, 0 deletions
diff --git a/binaryurp/source/bridge.cxx b/binaryurp/source/bridge.cxx
index fec485d7a33f..7718c53a8266 100644
--- a/binaryurp/source/bridge.cxx
+++ b/binaryurp/source/bridge.cxx
@@ -242,6 +242,12 @@ void Bridge::start() {
writer_->launch();
reader_.set(new Reader(this));
reader_->launch();
+ // it is important to call reader_->launch() last here; both
+ // Writer::execute and Reader::execute can call Bridge::terminate, but
+ // Writer::execute is initially blocked in unblocked_.wait() until
+ // Reader::execute has called bridge_->sendRequestChangeRequest(), so
+ // effectively only reader_->launch() can lead to an early call to
+ // Bridge::terminate
}
void Bridge::terminate() {