Replace fallthrough comments with new SAL_FALLTHROUGH macro

...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca

2 files changed, 2 insertions, 2 deletions

diff --git a/binaryurp/source/incomingrequest.cxx b/binaryurp/source/incomingrequest.cxx
index 009e473c64b4..2413b6894f6f 100644
--- a/binaryurp/source/incomingrequest.cxx
+++ b/binaryurp/source/incomingrequest.cxx
@@ -171,7 +171,7 @@ bool IncomingRequest::execute_throw(
             }
             break;
         }
-        // fall through
+        SAL_FALLTHROUGH;
     default:
         {
             OSL_ASSERT(object_.is());
diff --git a/binaryurp/source/marshal.cxx b/binaryurp/source/marshal.cxx
index a45d1c639d0c..b2251e9ca6a8 100644
--- a/binaryurp/source/marshal.cxx
+++ b/binaryurp/source/marshal.cxx
@@ -194,7 +194,7 @@ void Marshal::writeValue(
         break;
     case typelib_TypeClass_BOOLEAN:
         assert(*static_cast< sal_uInt8 const * >(value) <= 1);
-        // fall through
+        SAL_FALLTHROUGH;
     case typelib_TypeClass_BYTE:
         write8(buffer, *static_cast< sal_uInt8 const * >(value));
         break;