diff options
| author | Noel Grandin <noel@peralex.com> | 2016-02-02 16:15:51 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-02-08 06:08:14 +0000 |
| commit | b14224fe97b8a44232c9c1401d3a49771f46582e (patch) | |
| tree | 8f9cf31cf4b51a0edbb43022499a6acd17d0945d /basic | |
| parent | c474e610e453d0f38f7cc6cb9559ad7e7b5d69ca (diff) | |
loplugin:unusedmethods
using an idea from dtardon:
<dtardon> noelgrandin, hi. could you try to run the unusedmethods clang
plugin with "make build-nocheck"? that would catch functions that are
only used in tests. e.g., i just removed the whole o3tl::range class,
which has not been used in many years, but htere was a test for it...
<noelgrandin> dtardon, interesting idea! Sure, I can do that.
Change-Id: I5653953a426a2186a1e43017212d87ffce520387
Reviewed-on: https://gerrit.libreoffice.org/22041
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/qa/cppunit/test_scanner.cxx | 2 | ||||
| -rw-r--r-- | basic/source/comp/buffer.cxx | 12 | ||||
| -rw-r--r-- | basic/source/inc/buffer.hxx | 1 | ||||
| -rw-r--r-- | basic/source/inc/scanner.hxx | 1 |
4 files changed, 0 insertions, 16 deletions
diff --git a/basic/qa/cppunit/test_scanner.cxx b/basic/qa/cppunit/test_scanner.cxx index ba1320b196b4..509a793f175a 100644 --- a/basic/qa/cppunit/test_scanner.cxx +++ b/basic/qa/cppunit/test_scanner.cxx @@ -25,7 +25,6 @@ namespace { sal_uInt16 line; sal_uInt16 col1; - sal_uInt16 col2; OUString text; double number; SbxDataType type; @@ -85,7 +84,6 @@ namespace Symbol symbol; symbol.line = scanner.GetLine(); symbol.col1 = scanner.GetCol1(); - symbol.col2 = scanner.GetCol2(); symbol.text = scanner.GetSym(); symbol.number = scanner.GetDbl(); symbol.type = scanner.GetType(); diff --git a/basic/source/comp/buffer.cxx b/basic/source/comp/buffer.cxx index bb1be6e142b1..89543950e4c3 100644 --- a/basic/source/comp/buffer.cxx +++ b/basic/source/comp/buffer.cxx @@ -220,16 +220,4 @@ void SbiBuffer::operator +=( sal_Int32 n ) } -void SbiBuffer::operator +=( const OUString& n ) -{ - sal_uInt32 len = n.getLength() + 1; - if( Check( len ) ) - { - OString aByteStr(OUStringToOString(n, osl_getThreadTextEncoding())); - memcpy( pCur, aByteStr.getStr(), len ); - pCur += len; - nOff += len; - } -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/basic/source/inc/buffer.hxx b/basic/source/inc/buffer.hxx index 2faeb2b8a0ea..3b1b5a8b555e 100644 --- a/basic/source/inc/buffer.hxx +++ b/basic/source/inc/buffer.hxx @@ -37,7 +37,6 @@ public: ~SbiBuffer(); void Patch( sal_uInt32, sal_uInt32 ); void Chain( sal_uInt32 ); - void operator += (const OUString&); // save basic-string void operator += (sal_Int8); // save character void operator += (sal_Int16); // save integer bool operator += (sal_uInt8); // save character diff --git a/basic/source/inc/scanner.hxx b/basic/source/inc/scanner.hxx index e939bbc23c54..d17337ea30c6 100644 --- a/basic/source/inc/scanner.hxx +++ b/basic/source/inc/scanner.hxx @@ -78,7 +78,6 @@ public: sal_Int32 GetErrors() { return nErrors; } sal_Int32 GetLine() { return nLine; } sal_Int32 GetCol1() { return nCol1; } - sal_Int32 GetCol2() { return nCol2; } void SetCol1( sal_Int32 n ) { nCol1 = n; } StarBASIC* GetBasic() { return pBasic; } void SaveLine() { pSaveLine = pLine; } |