diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-08-04 11:54:42 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-08-04 15:00:24 +0200 |
| commit | 16a3a548d4e8e1132689de5615e025d0d4b3d564 (patch) | |
| tree | f50195d819c023da78d47766393d0faf9a9797bc /basic | |
| parent | adb901ca11afa5a153ecd433375b9ab1dfc2fd03 (diff) | |
Remove dead code
As discussed at <https://gerrit.libreoffice.org/c/core/+/99724> "fix shutdown
crash in basic" the code was added in error, and at least clang-cl with latest
MSVC standard library and C++20 mode gives a helpful
> basic/source/sbx/sbxbase.cxx(53,5): error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result]
> std::move(m_Factories);
> ^~~~~~~~~ ~~~~~~~~~~~
now.
Change-Id: I052efe51d4415838b50de06bb308692fa937b7b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100076
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/source/sbx/sbxbase.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/basic/source/sbx/sbxbase.cxx b/basic/source/sbx/sbxbase.cxx index f62949ada7ec..0e057540c8bc 100644 --- a/basic/source/sbx/sbxbase.cxx +++ b/basic/source/sbx/sbxbase.cxx @@ -48,9 +48,6 @@ SbxAppData::~SbxAppData() pBasicFormater.reset(); // basic manager repository must be destroyed before factories mrImplRepository.clear(); - // we need to move stuff out otherwise the destruction of the factories - // calls back into SbxBase::RemoveFactory and sees partially destructed data - std::move(m_Factories); } SbxBase::SbxBase() |