diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 08:37:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 11:20:07 +0200 |
| commit | c0cc59adca23580864a2e5cdadf66212246cbfcc (patch) | |
| tree | 57413c8efb3ca4a59f3699592353da1c575e345d /basic | |
| parent | 4bf2052e9dbdfcd32a749747c918f2d714010633 (diff) | |
loplugin:singlevalfields improvement
look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr
Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/source/inc/scriptcont.hxx | 1 | ||||
| -rw-r--r-- | basic/source/uno/scriptcont.cxx | 4 |
2 files changed, 1 insertions, 4 deletions
diff --git a/basic/source/inc/scriptcont.hxx b/basic/source/inc/scriptcont.hxx index 29d9a83cf89b..bdf0a0248ad3 100644 --- a/basic/source/inc/scriptcont.hxx +++ b/basic/source/inc/scriptcont.hxx @@ -32,7 +32,6 @@ namespace basic class SfxScriptLibraryContainer : public SfxLibraryContainer, public OldBasicPassword { - OUString maScriptLanguage; css::uno::Reference< css::container::XNameAccess > mxCodeNameAccess; // Methods to distinguish between different library types diff --git a/basic/source/uno/scriptcont.cxx b/basic/source/uno/scriptcont.cxx index 520318c92e54..e31b7ee27550 100644 --- a/basic/source/uno/scriptcont.cxx +++ b/basic/source/uno/scriptcont.cxx @@ -105,14 +105,12 @@ void SfxScriptLibraryContainer::setLibraryPassword( const OUString& rLibraryName // Ctor for service SfxScriptLibraryContainer::SfxScriptLibraryContainer() - :maScriptLanguage( "StarBasic" ) { // all initialisation has to be done // by calling XInitialization::initialize } SfxScriptLibraryContainer::SfxScriptLibraryContainer( const uno::Reference< embed::XStorage >& xStorage ) - :maScriptLanguage( "StarBasic" ) { init( OUString(), xStorage ); } @@ -163,7 +161,7 @@ void SfxScriptLibraryContainer::writeLibraryElement( const Reference < XNameCont xmlscript::ModuleDescriptor aMod; aMod.aName = aElementName; - aMod.aLanguage = maScriptLanguage; + aMod.aLanguage = "StarBasic"; Any aElement = xLib->getByName( aElementName ); aElement >>= aMod.aCode; |