diff options
| author | Noel Grandin <noel@peralex.com> | 2016-09-14 09:01:06 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-09-14 08:47:06 +0000 |
| commit | 20a9e101d909cb1953101e5962b74731e1265400 (patch) | |
| tree | 4e2516dcb7a5e19efb36fc4c2560b9211af83ce9 /basic | |
| parent | 0761f97525b3f3ce2cd73f8db28bf389a3c44f57 (diff) | |
loplugin:constantparam
clean up the plugin a little, and try to catch params which are default
constructed, which doesn't seem to be working yet
Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12
Reviewed-on: https://gerrit.libreoffice.org/28861
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/source/classes/sb.cxx | 2 | ||||
| -rw-r--r-- | basic/source/classes/sbxmod.cxx | 4 | ||||
| -rw-r--r-- | basic/source/inc/sbjsmeth.hxx | 2 | ||||
| -rw-r--r-- | basic/source/sbx/sbxvar.cxx | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx index 1696e66eebf4..58e683438814 100644 --- a/basic/source/classes/sb.cxx +++ b/basic/source/classes/sb.cxx @@ -427,7 +427,7 @@ SbxBase* SbiFactory::Create( sal_uInt16 nSbxId, sal_uInt32 nCreator ) case SBXID_JSCRIPTMOD: return new SbJScriptModule( "" ); case SBXID_JSCRIPTMETH: - return new SbJScriptMethod( "", SbxVARIANT, nullptr ); + return new SbJScriptMethod( "", SbxVARIANT ); } } return nullptr; diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx index 0082d9f15d1b..d4b7e3750b5b 100644 --- a/basic/source/classes/sbxmod.cxx +++ b/basic/source/classes/sbxmod.cxx @@ -2168,8 +2168,8 @@ void SbMethod::Broadcast( sal_uInt32 nHintId ) // Implementation of SbJScriptMethod (method class as a wrapper for JavaScript-functions) -SbJScriptMethod::SbJScriptMethod( const OUString& r, SbxDataType t, SbModule* p ) - : SbMethod( r, t, p ) +SbJScriptMethod::SbJScriptMethod( const OUString& r, SbxDataType t ) + : SbMethod( r, t, nullptr ) { } diff --git a/basic/source/inc/sbjsmeth.hxx b/basic/source/inc/sbjsmeth.hxx index 0c7ce3432b51..3403b392986d 100644 --- a/basic/source/inc/sbjsmeth.hxx +++ b/basic/source/inc/sbjsmeth.hxx @@ -30,7 +30,7 @@ class SbJScriptMethod : public SbMethod { public: - SbJScriptMethod( const OUString&, SbxDataType, SbModule* ); + SbJScriptMethod( const OUString&, SbxDataType ); virtual ~SbJScriptMethod() override; SBX_DECL_PERSIST_NODATA(SBXID_JSCRIPTMETH,2); diff --git a/basic/source/sbx/sbxvar.cxx b/basic/source/sbx/sbxvar.cxx index 784e9d11aa36..908c88f4d2c4 100644 --- a/basic/source/sbx/sbxvar.cxx +++ b/basic/source/sbx/sbxvar.cxx @@ -116,7 +116,7 @@ void SbxEnsureParentVariable::SetParent(SbxObject* p) assert(GetParent() == xParent.get()); } -SbxVariable::SbxVariable( SbxDataType t, void* p ) : SbxValue( t, p ) +SbxVariable::SbxVariable( SbxDataType t ) : SbxValue( t, nullptr ) { pCst = nullptr; pParent = nullptr; |