diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-06 13:32:43 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-14 18:03:06 +0200 |
| commit | e67657d5211f6e95ddf8bd621108608573b00d5d (patch) | |
| tree | 66724101dbd95721714bd40fcb4861663432774c /basctl | |
| parent | 186def8f48e273c3a3b4d23b3ab2efd0d8664731 (diff) | |
loplugin:simplifybool more
look for expressions like
!(a && !b)
which can be expanded out
Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basctl')
| -rw-r--r-- | basctl/source/basicide/baside2.cxx | 4 | ||||
| -rw-r--r-- | basctl/source/basicide/basidesh.cxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx index f8964c96c3b8..a114332e42b2 100644 --- a/basctl/source/basicide/baside2.cxx +++ b/basctl/source/basicide/baside2.cxx @@ -278,7 +278,7 @@ void ModulWindow::CheckCompileBasic() bool const bModified = ( !m_xModule->IsCompiled() || ( GetEditEngine() && GetEditEngine()->IsModified() ) ); - if ( !(!bRunning && bModified) ) + if ( bRunning || !bModified ) return; bool bDone = false; @@ -325,7 +325,7 @@ void ModulWindow::BasicExecute() CheckCompileBasic(); - if ( !(XModule().is() && m_xModule->IsCompiled() && !m_aStatus.bError) ) + if ( !XModule().is() || !m_xModule->IsCompiled() || m_aStatus.bError ) return; if ( GetBreakPoints().size() ) diff --git a/basctl/source/basicide/basidesh.cxx b/basctl/source/basicide/basidesh.cxx index 3a2259bf40ac..a2f9023e8147 100644 --- a/basctl/source/basicide/basidesh.cxx +++ b/basctl/source/basicide/basidesh.cxx @@ -900,7 +900,7 @@ void Shell::EnableScrollbars( bool bEnable ) void Shell::SetCurLib( const ScriptDocument& rDocument, const OUString& aLibName, bool bUpdateWindows, bool bCheck ) { - if ( !(!bCheck || ( rDocument != m_aCurDocument || aLibName != m_aCurLibName )) ) + if ( bCheck && rDocument == m_aCurDocument && aLibName == m_aCurLibName ) return; ContainerListenerImpl* pListener = static_cast< ContainerListenerImpl* >( m_xLibListener.get() ); |