diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-19 09:13:03 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-19 13:26:27 +0100 |
| commit | be8c414567f49242164b1fdfb12764b16be355c1 (patch) | |
| tree | c1f505272ec27e5e069f5d6964dc4f7b20150a5a /avmedia | |
| parent | be94207ecb88a9005ee6624e354d70c9613d7653 (diff) | |
loplugin:unusedmethods also check for functions returning bool
we were previously excluding them
Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'avmedia')
| -rw-r--r-- | avmedia/source/vlc/inc/wrapper/Player.hxx | 5 | ||||
| -rw-r--r-- | avmedia/source/vlc/wrapper/Player.cxx | 18 |
2 files changed, 3 insertions, 20 deletions
diff --git a/avmedia/source/vlc/inc/wrapper/Player.hxx b/avmedia/source/vlc/inc/wrapper/Player.hxx index 740390080d63..84b064493d61 100644 --- a/avmedia/source/vlc/inc/wrapper/Player.hxx +++ b/avmedia/source/vlc/inc/wrapper/Player.hxx @@ -51,16 +51,13 @@ namespace wrapper void setWindow( intptr_t id ); - bool takeSnapshot(const rtl::OUString& file); + void takeSnapshot(const rtl::OUString& file); bool hasVout() const; void setScale( float factor ); void setVideoSize( unsigned width, unsigned height ); - unsigned getWidth() const; - unsigned getHeight() const; - operator libvlc_media_player_t*() { return mPlayer; diff --git a/avmedia/source/vlc/wrapper/Player.cxx b/avmedia/source/vlc/wrapper/Player.cxx index 44eed54fca8e..7eb33440e24d 100644 --- a/avmedia/source/vlc/wrapper/Player.cxx +++ b/avmedia/source/vlc/wrapper/Player.cxx @@ -180,20 +180,6 @@ namespace wrapper libvlc_video_set_scale( mPlayer, factor ); } - unsigned Player::getWidth() const - { - unsigned width, height; - libvlc_video_get_size( mPlayer, 0, &width, &height ); - return width; - } - - unsigned Player::getHeight() const - { - unsigned width, height; - libvlc_video_get_size( mPlayer, 0, &width, &height ); - return height; - } - void Player::setMouseHandling(bool flag) { libvlc_video_set_mouse_input( mPlayer, flag ); @@ -243,11 +229,11 @@ namespace wrapper #endif } - bool Player::takeSnapshot( const rtl::OUString& file ) + void Player::takeSnapshot( const rtl::OUString& file ) { rtl::OString dest; file.convertToString( &dest, RTL_TEXTENCODING_UTF8, 0 ); - return libvlc_video_take_snapshot( mPlayer, 0, dest.getStr(), 480, 360 ) == 0; + libvlc_video_take_snapshot( mPlayer, 0, dest.getStr(), 480, 360 ); } bool Player::hasVout() const |