Find places where OUString and OString are passed by value.

It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361

1 files changed, 2 insertions, 2 deletions

diff --git a/accessibility/inc/accessibility/standard/vclxaccessiblelist.hxx b/accessibility/inc/accessibility/standard/vclxaccessiblelist.hxx
index 49a7602a31c2..a90d88dd18e0 100644
--- a/accessibility/inc/accessibility/standard/vclxaccessiblelist.hxx
+++ b/accessibility/inc/accessibility/standard/vclxaccessiblelist.hxx
@@ -79,7 +79,7 @@ public:
             This string contains the text of the currently selected
             item.  It is used to retrieve the index of that item.
     */
-    void UpdateSelection (OUString sTextOfSelectedItem);
+    void UpdateSelection (const OUString& sTextOfSelectedItem);
 
     // XInterface
     DECLARE_XINTERFACE()
@@ -139,7 +139,7 @@ public:
     sal_Bool    IsInDropDown();
     void        HandleDropOpen();
     virtual void ProcessWindowEvent (const VclWindowEvent& rVclWindowEvent, bool b_IsDropDownList);
-    void UpdateSelection_Acc (::rtl::OUString sTextOfSelectedItem, bool b_IsDropDownList);
+    void UpdateSelection_Acc (const ::rtl::OUString& sTextOfSelectedItem, bool b_IsDropDownList);
     void UpdateSelection_Impl_Acc (bool b_IsDropDownList);
 
     void UpdateFocus_Impl_Acc ( sal_uInt16 nPos, bool b_IsDropDownList) ;