diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
| commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
| tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /UnoControls/source | |
| parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) | |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'UnoControls/source')
| -rw-r--r-- | UnoControls/source/controls/progressmonitor.cxx | 12 | ||||
| -rw-r--r-- | UnoControls/source/inc/progressmonitor.hxx | 4 |
2 files changed, 8 insertions, 8 deletions
diff --git a/UnoControls/source/controls/progressmonitor.cxx b/UnoControls/source/controls/progressmonitor.cxx index 905213b1e8e5..cabbdc1e4204 100644 --- a/UnoControls/source/controls/progressmonitor.cxx +++ b/UnoControls/source/controls/progressmonitor.cxx @@ -831,21 +831,21 @@ IMPL_TextlistItem* ProgressMonitor::impl_searchTopic ( const OUString& rTopic, b // addText, updateText bool ProgressMonitor::impl_debug_checkParameter ( - const OUString& rTopic, - const OUString& rText + std::u16string_view rTopic, + std::u16string_view rText ) { - if ( rTopic.isEmpty() ) return false; // "" + if ( rTopic.empty() ) return false; // "" - if ( rText.isEmpty() ) return false; // "" + if ( rText.empty() ) return false; // "" // Parameter OK ... return true. return true; } // removeText -bool ProgressMonitor::impl_debug_checkParameter ( const OUString& rTopic ) +bool ProgressMonitor::impl_debug_checkParameter ( std::u16string_view rTopic ) { - if ( rTopic.isEmpty() ) return false; // "" + if ( rTopic.empty() ) return false; // "" // Parameter OK ... return true. return true; diff --git a/UnoControls/source/inc/progressmonitor.hxx b/UnoControls/source/inc/progressmonitor.hxx index 4f407eeda2e6..ad4accba562d 100644 --- a/UnoControls/source/inc/progressmonitor.hxx +++ b/UnoControls/source/inc/progressmonitor.hxx @@ -223,8 +223,8 @@ private: // debug methods - static bool impl_debug_checkParameter( const OUString& sTopic, const OUString& sText ); // addText, updateText - static bool impl_debug_checkParameter( const OUString& rTopic ); // removeText + static bool impl_debug_checkParameter( std::u16string_view sTopic, std::u16string_view sText ); // addText, updateText + static bool impl_debug_checkParameter( std::u16string_view rTopic ); // removeText // private variables |