path: root/
diff options
authorStephan Bergmann <>2018-09-22 17:30:36 +0200
committerStephan Bergmann <>2018-09-22 20:55:16 +0200
commit0a5542438320ee81bbf285b11d0996796c8a9830 (patch)
tree23fe5730504bb528b9d3f786d7e3c5e3fb9564f5 /
parent5372962696ba4271ffb6b2b230fab5261108af6b (diff)
external/harfbuzz's libharfbuzz.a links against icuuc library
buovjaga reported on IRC that his build (implicitly --without-system-harfbuzz --without-system-icu) failed to link e.g. Library_vclplug_gtk3 due to harfbuzz missing symbols from ICU, like > /usr/bin/ld: /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/.libs/libharfbuzz.a(libharfbuzz_la-hb-icu.o): in function `hb_icu_unicode_decompose_compatibility(hb_unicode_funcs_t*, unsigned int, unsigned int*, void*)': > /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/ undefined reference to `unorm2_getNFKDInstance_62' [...] It is not clear to me why Library_vclplug_gtk3 would actually use libharfbuzz.a's hb_icu_unicode_decompose_compatibility (and for e.g. my builds, it apparently doesn't), but in general libharfbuzz.a does depend on some symbols from icuuc, so it is correct to add icuuc to the link when linking against harfbuzz. (And "gb_LinkTarget_use_external,...,icuuc" conveniently only adds libs for linking, and does not add C/C++ include file paths, which would not be wanted here.) (<> "Revert 'Add more more dependencies to VCL makefiles'" was a false start trying to address the above issue.) Change-Id: Ic8bcfa2aab185f8a9487d7787b4f22068e7cb481 Reviewed-on: Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <> Reviewed-by: Stephan Bergmann <>
Diffstat (limited to '')
1 files changed, 1 insertions, 0 deletions
diff --git a/ b/
index f172765a84f8..9312d0b7ab2a 100644
--- a/
+++ b/
@@ -1505,6 +1505,7 @@ $(call gb_LinkTarget_set_include,$(1),\
$(call gb_LinkTarget_add_libs,$(1),$(HARFBUZZ_LIBS))
+$(call gb_LinkTarget_use_external,$(1),icuuc)
$(call gb_LinkTarget_use_external_project,$(1),harfbuzz)