summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2018-10-19 14:11:56 +0100
committerCaolán McNamara <caolanm@redhat.com>2018-10-20 21:51:46 +0200
commitcc21f1ab22328ddf2bd82a77d81dbee69c847e5e (patch)
treee1ff5ac4db7d76ffd80b9701d7a889edd2c7690c
parent9f8f804f089a40fc2fc0b43690a4b9d529217d32 (diff)
dubious SysAllocString check
Change-Id: I1aece8321b12351b5e8a2d5c33e513531cbc95a1 Reviewed-on: https://gerrit.libreoffice.org/62007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r--winaccessibility/source/UAccCOM/AccTable.cxx7
1 files changed, 3 insertions, 4 deletions
diff --git a/winaccessibility/source/UAccCOM/AccTable.cxx b/winaccessibility/source/UAccCOM/AccTable.cxx
index dcd4ad2d65d7..6a872b277dc0 100644
--- a/winaccessibility/source/UAccCOM/AccTable.cxx
+++ b/winaccessibility/source/UAccCOM/AccTable.cxx
@@ -132,9 +132,9 @@ STDMETHODIMP CAccTable::get_columnDescription(long column, BSTR * description)
const ::rtl::OUString& ouStr = GetXInterface()->getAccessibleColumnDescription(column);
// #CHECK#
- SAFE_SYSFREESTRING(*description);//??
+ SAFE_SYSFREESTRING(*description);
*description = SysAllocString(o3tl::toW(ouStr.getStr()));
- if(description==nullptr)
+ if (*description==nullptr)
return E_FAIL;
return S_OK;
@@ -353,9 +353,8 @@ STDMETHODIMP CAccTable::get_rowDescription(long row, BSTR * description)
SAFE_SYSFREESTRING(*description);
*description = SysAllocString(o3tl::toW(ouStr.getStr()));
- if(description==nullptr)
+ if (*description==nullptr)
return E_FAIL;
-
return S_OK;
LEAVE_PROTECTED_BLOCK