diff options
author | Xisco Fauli <xiscofauli@libreoffice.org> | 2018-07-14 20:37:56 +0200 |
---|---|---|
committer | Xisco FaulĂ <xiscofauli@libreoffice.org> | 2018-07-27 13:09:06 +0200 |
commit | c57f10b67fceef47d304d74dce93be7389a7720c (patch) | |
tree | 528be49a244a7643fb8e2603ac0159a9b79ead4c | |
parent | 228b9801f1ec440cf3090a6f2ff24722c5bc26d0 (diff) |
tdf#111306: Hide background widget in sidebar in master and notes view
Background is lost if it's changed from the sidebar in master or
notes view, thus hide the widget for now, until the real issue is fixed.
Keep the insert image button visible as it works.
The background can be changed from the page properties dialog
Change-Id: Ic3f6116cb0997024096343cb20ec40ac07307918
Reviewed-on: https://gerrit.libreoffice.org/57440
Tested-by: Jenkins
Reviewed-by: Xisco FaulĂ <xiscofauli@libreoffice.org>
-rw-r--r-- | sd/source/ui/sidebar/SlideBackground.cxx | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/sd/source/ui/sidebar/SlideBackground.cxx b/sd/source/ui/sidebar/SlideBackground.cxx index 08042defd663..f4e4d045e174 100644 --- a/sd/source/ui/sidebar/SlideBackground.cxx +++ b/sd/source/ui/sidebar/SlideBackground.cxx @@ -244,11 +244,11 @@ void SlideBackground::HandleContextChange( mpMasterSlide->Disable(); mpDspMasterBackground->Disable(); mpDspMasterObjects->Disable(); - mpFillStyle->Show(); - mpBackgroundLabel->Show(); + mpFillStyle->Hide(); + mpBackgroundLabel->Hide(); mpInsertImage->Show(); } - else if ( maContext == maImpressHandoutContext ) + else if ( maContext == maImpressHandoutContext || maContext == maImpressNotesContext ) { mpCloseMaster->Hide(); mpEditMaster->Hide(); @@ -270,17 +270,7 @@ void SlideBackground::HandleContextChange( mpBackgroundLabel->Show(); mpInsertImage->Show(); } - else if (maContext == maImpressNotesContext) - { - mpCloseMaster->Hide(); - mpEditMaster->Hide(); - mpMasterSlide->Disable(); - mpDspMasterBackground->Disable(); - mpDspMasterObjects->Disable(); - mpFillStyle->Show(); - mpBackgroundLabel->Show(); - mpInsertImage->Hide(); - } + // Need to do a relayouting, otherwise the panel size is not updated after show / hide controls sfx2::sidebar::Panel* pPanel = dynamic_cast<sfx2::sidebar::Panel*>(GetParent()); if(pPanel) @@ -296,7 +286,7 @@ void SlideBackground::Update() { eFillStyle nPos = static_cast<eFillStyle>(mpFillStyle->GetSelectedEntryPos()); - if(maContext == maImpressHandoutContext) + if(maContext != maImpressOtherContext) nPos = NONE; SfxObjectShell* pSh = SfxObjectShell::Current(); |