fdo#68959: sw: fix painting of tab fill characters in small caps text

The member SwDrawTextInfo::pPos was changed from a pointer to some
externally provided Point to a real object; unfortunately there were
some functions which hold backups of the current pPos as a
reference/pointer and then restore it, and the restore is a no-op now.
So use real Points as backups.

(regression from f22006dc6ac34a35a060e15466cf6b2d2058617d)

Change-Id: I8470143ec494cb194a88ddcbd12d96867974278f
(cherry picked from commit c445d40da8daa2f6ec0ae9930a06f50ab80cc85d)
Reviewed-on: https://gerrit.libreoffice.org/7566
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

3 files changed, 9 insertions, 9 deletions

diff --git a/sw/source/core/text/txtfly.cxx b/sw/source/core/text/txtfly.cxx
index 1e6641275c59..9f7d970e1ff9 100644
--- a/sw/source/core/text/txtfly.cxx
+++ b/sw/source/core/text/txtfly.cxx
@@ -568,7 +568,7 @@ sal_Bool SwTxtFly::DrawTextOpaque( SwDrawTextInfo &rInf )
     }
 
     Point aPos( rInf.GetPos().X(), rInf.GetPos().Y() + rInf.GetAscent() );
-    const Point &rOld = rInf.GetPos();
+    const Point aOldPos(rInf.GetPos());
     rInf.SetPos( aPos );
 
     if( !bOpaque )
@@ -577,7 +577,7 @@ sal_Bool SwTxtFly::DrawTextOpaque( SwDrawTextInfo &rInf )
             rInf.GetFont()->_DrawStretchText( rInf );
         else
             rInf.GetFont()->_DrawText( rInf );
-        rInf.SetPos( rOld );
+        rInf.SetPos(aOldPos);
         return sal_False;
     }
     else if( !aRegion.empty() )
@@ -595,7 +595,7 @@ sal_Bool SwTxtFly::DrawTextOpaque( SwDrawTextInfo &rInf )
                 rInf.GetFont()->_DrawText( rInf );
         }
     }
-    rInf.SetPos( rOld );
+    rInf.SetPos(aOldPos);
     return sal_True;
 }
 
diff --git a/sw/source/core/txtnode/fntcap.cxx b/sw/source/core/txtnode/fntcap.cxx
index 0c31695acebf..c435eda085ee 100644
--- a/sw/source/core/txtnode/fntcap.cxx
+++ b/sw/source/core/txtnode/fntcap.cxx
@@ -523,9 +523,9 @@ void SwSubFont::DrawStretchCapital( SwDrawTextInfo &rInf )
     if( rInf.GetLen() == STRING_LEN )
         rInf.SetLen( rInf.GetText().getLength() );
 
-    const Point& rOldPos = rInf.GetPos();
+    const Point aOldPos = rInf.GetPos();
     const sal_uInt16 nCapWidth = (sal_uInt16)( GetCapitalSize( rInf ).Width() );
-    rInf.SetPos( rOldPos );
+    rInf.SetPos(aOldPos);
 
     rInf.SetDrawSpace( GetUnderline() != UNDERLINE_NONE ||
                        GetOverline()  != UNDERLINE_NONE ||
diff --git a/sw/source/core/txtnode/swfont.cxx b/sw/source/core/txtnode/swfont.cxx
index 2269f248e48e..21c6601e3601 100644
--- a/sw/source/core/txtnode/swfont.cxx
+++ b/sw/source/core/txtnode/swfont.cxx
@@ -1195,12 +1195,12 @@ void SwSubFont::_DrawText( SwDrawTextInfo &rInf, const sal_Bool bGrey )
 
     SwDigitModeModifier aDigitModeModifier( rInf.GetOut(), rInf.GetFont()->GetLanguage() );
 
+    const Point aOldPos(rInf.GetPos());
     Point aPos( rInf.GetPos() );
 
     if( GetEscapement() )
         CalcEsc( rInf, aPos );
 
-    const Point &rOld = rInf.GetPos();
     rInf.SetPos( aPos );
     rInf.SetKern( CheckKerning() + rInf.GetSperren() / SPACING_PRECISION_FACTOR );
 
@@ -1300,7 +1300,7 @@ void SwSubFont::_DrawText( SwDrawTextInfo &rInf, const sal_Bool bGrey )
         rInf.SetLen( nOldLen );
     }
 
-    rInf.SetPos( rOld );
+    rInf.SetPos(aOldPos);
 }
 
 void SwSubFont::_DrawStretchText( SwDrawTextInfo &rInf )
@@ -1325,13 +1325,13 @@ void SwSubFont::_DrawStretchText( SwDrawTextInfo &rInf )
 
     rInf.ApplyAutoColor();
 
+    const Point aOldPos(rInf.GetPos());
     Point aPos( rInf.GetPos() );
 
     if( GetEscapement() )
         CalcEsc( rInf, aPos );
 
     rInf.SetKern( CheckKerning() + rInf.GetSperren() / SPACING_PRECISION_FACTOR );
-    const Point &rOld = rInf.GetPos();
     rInf.SetPos( aPos );
 
     if( IsCapital() )
@@ -1382,7 +1382,7 @@ void SwSubFont::_DrawStretchText( SwDrawTextInfo &rInf )
         rInf.SetLen( nOldLen );
     }
 
-    rInf.SetPos( rOld );
+    rInf.SetPos(aOldPos);
 }
 
 xub_StrLen SwSubFont::_GetCrsrOfst( SwDrawTextInfo& rInf )