diff options
author | Chris Sherlock <chris.sherlock79@gmail.com> | 2014-04-02 00:43:01 +1100 |
---|---|---|
committer | Chris Sherlock <chris.sherlock79@gmail.com> | 2014-04-02 00:45:29 +1100 |
commit | 65b3a78058e9d8a0e7c62ac9591c3b9e5c25eed7 (patch) | |
tree | 6d56dc9d254bee5fbdcb876f72d0fa566d990e48 | |
parent | 04e08fa4aa419b8d89d80a39e6904bc4cd8883be (diff) |
fdo#74702 update bad advise in comment in DrawTransparentNatively()
We really do *not* want to introduce the horror that is meOutDevType
into our code. If we need to stop the Printer class from drawing a
PolyPolygon then we should let Printer do this, not make OutputDevice
make this decision on Printer's behalf!
Change-Id: If74eccdf34688ce1164da2bb705ea48eefc18800
-rw-r--r-- | vcl/source/gdi/outdev6.cxx | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/vcl/source/gdi/outdev6.cxx b/vcl/source/gdi/outdev6.cxx index d96e59fa9ef5..ea606450fea3 100644 --- a/vcl/source/gdi/outdev6.cxx +++ b/vcl/source/gdi/outdev6.cxx @@ -296,10 +296,11 @@ bool OutputDevice::DrawTransparentNatively ( const PolyPolygon& rPolyPoly, // CAUTION: Only non printing (pixel-renderer) VCL commands from OutputDevices // should be used when printing. Normally this is avoided by the printer being // non-AAed and thus e.g. on WIN GdiPlus calls are not used. It may be necessary - // to add (OUTDEV_PRINTER != meOutDevType) to the entering if statement, thus - // using the fallbacl some lines below (which is not very good, though). For - // now, WinSalGraphics::drawPolyPolygon will detect printer usage and correct - // the wrong mapping (see there for details) + // to figure out a way of moving this code to it's own function that is + // overriden by the Print class, which will mean we deliberately override the + // functionality and we use the fallback some lines below (which is not very good, + // though. For now, WinSalGraphics::drawPolyPolygon will detect printer usage and + // correct the wrong mapping (see there for details) bDrawn = mpGraphics->DrawPolyPolygon( aB2DPolyPolygon, fTransparency, this ); } |