diff options
| author | Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> | 2016-06-02 17:48:03 +0900 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2016-06-07 08:50:49 +0000 |
| commit | 4902c5c831cbed7b5e086e49e95abcd93c08e39d (patch) | |
| tree | 987f14d1b502adca0f74f6b677ac20150b4a4bc4 | |
| parent | 7ae8c5e0d0e19659ccd4cafcf6ec2d2dd5b0d850 (diff) | |
tdf#100187 fix division by zero in comboFragmentShader
When feather is 0.0 (used when anti-aliasing is disabled) then
we get a "division by zero" situation. As per OpenGL secs. the
shader should not fail in this situation however the result is
undetermined. Most GPUs handled this correctly but on some the
lines didn't draw at all. This should fix this issue.
Change-Id: I56ca2f10c393491807321969c72085ef7690d16a
(cherry picked from commit 7aae883b90850af3f3a0aaada5704682f77c3d02)
Reviewed-on: https://gerrit.libreoffice.org/25811
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
| -rw-r--r-- | vcl/opengl/combinedFragmentShader.glsl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcl/opengl/combinedFragmentShader.glsl b/vcl/opengl/combinedFragmentShader.glsl index c44e75c09373..8d73d0861f87 100644 --- a/vcl/opengl/combinedFragmentShader.glsl +++ b/vcl/opengl/combinedFragmentShader.glsl @@ -29,7 +29,7 @@ void main() // Calculate the multiplier so we can transform the 0->1 fade factor // to take feather and line width into account. - float multiplied = 1.0 / (1.0 - (start / end)); + float multiplied = start == end ? 1.0 : 1.0 / (1.0 - (start / end)); float dist = (1.0 - abs(fade_factor)) * multiplied; |