diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2017-08-04 16:53:23 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2017-08-05 17:26:30 +0200 |
| commit | 30f384b5bd2d8ec7f50ad0c85c43611313044f8c (patch) | |
| tree | d48b6f5a36c1827edd8389a50ea607535796dfe3 | |
| parent | 39a6524625a3a682cf53128b5544cd7f2f75f3f1 (diff) | |
coverity#1416135 Dereference after null check
and
coverity#1416137 Dereference after null check
since...
commit 04461743d75f8cffb5906ab52d772089c44a7780
Date: Fri Jul 21 13:12:20 2017 +0530
tdf#108887 : Move the code of ScDrawView::CheckOle()...
maybe this check is simply reversed seeing as
bool bCalcSourceRanges = pRanges && pDoc;
and after this line pRanges and pDoc are unconditionally
dereferenced
Change-Id: Ie3ed3054d2f31ddbc70895a4e6997395ca7de8b5
Reviewed-on: https://gerrit.libreoffice.org/40772
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | sc/source/ui/view/drawvie4.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/source/ui/view/drawvie4.cxx b/sc/source/ui/view/drawvie4.cxx index a0a54b98383a..355b3a8f404d 100644 --- a/sc/source/ui/view/drawvie4.cxx +++ b/sc/source/ui/view/drawvie4.cxx @@ -245,7 +245,7 @@ void getOleSourceRanges(const SdrMarkList& rMarkList, bool& rAnyOle, bool& rOneO } } - if( bCalcSourceRanges ) + if (!bCalcSourceRanges) return; // Compile all range representation strings into ranges. |