diff options
author | Miklos Vajna <vmiklos@collabora.co.uk> | 2015-12-16 09:49:18 +0100 |
---|---|---|
committer | Miklos Vajna <vmiklos@collabora.co.uk> | 2015-12-16 10:09:12 +0100 |
commit | 2c23d4ee1e1370b20560e47db7efaeaac1d94b26 (patch) | |
tree | 9ba748d213897efe935bb4493e9dacd6325784f2 | |
parent | d0cf72f253a3cb8335601ebf2c5b1b99ab63e6b1 (diff) |
tdf#96515 sw Hide Whitespace: avoid creating unneeded page frames
Change-Id: I9b273543ccf2eaa87116c6e1475860e9e872c445
-rw-r--r-- | sw/qa/extras/uiwriter/uiwriter.cxx | 21 | ||||
-rw-r--r-- | sw/source/core/layout/calcmove.cxx | 29 |
2 files changed, 49 insertions, 1 deletions
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 6ce9814e20da..675e6cc1530b 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -176,6 +176,7 @@ public: void testTdf87922(); void testTdf77014(); void testTdf92648(); + void testTdf96515(); CPPUNIT_TEST_SUITE(SwUiWriterTest); CPPUNIT_TEST(testReplaceForward); @@ -258,6 +259,7 @@ public: CPPUNIT_TEST(testTdf87922); CPPUNIT_TEST(testTdf77014); CPPUNIT_TEST(testTdf92648); + CPPUNIT_TEST(testTdf96515); CPPUNIT_TEST_SUITE_END(); private: @@ -2920,6 +2922,25 @@ void SwUiWriterTest::testTdf92648() } } +void SwUiWriterTest::testTdf96515() +{ + // Enable hide whitespace mode. + SwDoc* pDoc = createDoc(); + SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell(); + SwViewOption aViewOptions(*pWrtShell->GetViewOptions()); + aViewOptions.SetHideWhitespaceMode(true); + pWrtShell->ApplyViewOptions(aViewOptions); + + // Insert a new paragraph at the end of the document. + uno::Reference<text::XTextDocument> xTextDocument(mxComponent, uno::UNO_QUERY); + uno::Reference<text::XParagraphAppend> xParagraphAppend(xTextDocument->getText(), uno::UNO_QUERY); + xParagraphAppend->finishParagraph(uno::Sequence<beans::PropertyValue>()); + calcLayout(); + + // This was 2, a new page was created for the new paragraph. + CPPUNIT_ASSERT_EQUAL(1, getPages()); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/core/layout/calcmove.cxx b/sw/source/core/layout/calcmove.cxx index cac6574158d9..922041702f1e 100644 --- a/sw/source/core/layout/calcmove.cxx +++ b/sw/source/core/layout/calcmove.cxx @@ -1520,7 +1520,34 @@ void SwContentFrame::MakeAll(vcl::RenderContext* /*pRenderContext*/) // Bottom(). This might happen with undersized TextFrames on the lower edge of a // multi-column section const long nPrtBottom = (GetUpper()->*fnRect->fnGetPrtBottom)(); - const long nBottomDist = (Frame().*fnRect->fnBottomDist)( nPrtBottom ); + long nBottomDist = (Frame().*fnRect->fnBottomDist)(nPrtBottom); + + if (getRootFrame()->GetCurrShell()->GetViewOptions()->IsWhitespaceHidden()) + { + // When whitespace is hidden, the page frame has two heights: the + // nominal (defined by the frame format), and the actual (which is + // at most the nominal height, but can be smaller in case there is + // no content for the whole page). + // The layout size is the actual one, but we want to move the + // content frame to a new page only in case it doesn't fit the + // nominal size. + if (nBottomDist < 0) + { + // Content frame doesn't fit the actual size, check if it fits the nominal one. + SwPageFrame* pPageFrame = FindPageFrame(); + const SwFrameFormat* pPageFormat = static_cast<const SwFrameFormat*>(pPageFrame->GetRegisteredIn()); + const Size& rPageSize = pPageFormat->GetFrameSize().GetSize(); + long nWhitespace = rPageSize.getHeight() - pPageFrame->Frame().Height(); + if (nWhitespace > -nBottomDist) + { + // It does: don't move it and invalidate our page frame so + // that it gets a larger height. + nBottomDist = 0; + pPageFrame->InvalidateSize(); + } + } + } + if( nBottomDist >= 0 ) { if ( bKeep && bMoveable ) |