diff options
author | Petr Mladek <pmladek@suse.cz> | 2013-08-02 16:24:23 +0200 |
---|---|---|
committer | Miklos Vajna <vmiklos@suse.cz> | 2013-08-06 08:11:36 +0000 |
commit | 1a97f10084629df98606746da6401fdff3996914 (patch) | |
tree | 4f37c2de958adac84ba459b8c8b94756cf729817 | |
parent | 88d95183839b9100cb1dc2f93156f31bf1fd0e31 (diff) |
let's own the packaged stuff by root:root again (fdo#67388)
We have started to use -fvisibility=hidden globally with GCC.
The hacky libgetuid.so does not work if the symbols are hidden.
In addition, the library was renamed from getuid.so to libgetuid.so
during gbuildisation; There was more location where it was not fixed;
The result was that the packages and files in the Linux download tarballs
were owned by some "ugly" user and group.
Change-Id: I22f62b861c373f2553dcccc85a84dddabaf1f418
Reviewed-on: https://gerrit.libreoffice.org/5251
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
-rw-r--r-- | setup_native/Library_getuid.mk | 8 | ||||
-rw-r--r-- | solenv/bin/modules/installer/download.pm | 2 |
2 files changed, 9 insertions, 1 deletions
diff --git a/setup_native/Library_getuid.mk b/setup_native/Library_getuid.mk index 764128dcb96a..fa98773f4d06 100644 --- a/setup_native/Library_getuid.mk +++ b/setup_native/Library_getuid.mk @@ -14,6 +14,14 @@ $(eval $(call gb_Library_add_defs,getuid,\ -D_GNU_SOURCE \ )) endif + +# the library is used by LD_PRELOAD; make sure that we see the symbols ;-) +ifeq ($(COM),GCC) +$(eval $(call gb_Library_add_cflags,getuid,\ + -fvisibility=default \ +)) +endif + $(eval $(call gb_Library_add_cobjects,getuid,\ setup_native/scripts/source/getuid \ )) diff --git a/solenv/bin/modules/installer/download.pm b/solenv/bin/modules/installer/download.pm index 9c4dde69caaf..ec54049eb3b7 100644 --- a/solenv/bin/modules/installer/download.pm +++ b/solenv/bin/modules/installer/download.pm @@ -194,7 +194,7 @@ sub get_path_for_library { my ($includepatharrayref) = @_; - my $getuidlibraryname = "getuid.so"; + my $getuidlibraryname = "libgetuid.so"; my $getuidlibraryref = ""; |