fdo#43460 framework,i18npool,accessibility: use isEmpty()

Change-Id: I4cd9841127b1d4a294d7f001b646259c61eb1172
Reviewed-on: https://gerrit.libreoffice.org/4443
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

5 files changed, 20 insertions, 20 deletions

diff --git a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
index bcaec362b102..3c601c67ab8e 100644
--- a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
+++ b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
@@ -120,7 +120,7 @@ namespace accessibility
 
         // TODO: localize this!
         OUStringBuffer sName(mpBrowseBox->GetColumnDescription( ::sal::static_int_cast< sal_uInt16 >( getColumnPos() ) ));
-        if ( 0 == sName.getLength() )
+        if ( sName.isEmpty() )
         {
             sName.appendAscii("Column ");
             sName.append(getColumnPos());
diff --git a/framework/source/fwe/helper/titlehelper.cxx b/framework/source/fwe/helper/titlehelper.cxx
index 07bf13d60cc6..dd301e6ad653 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -521,7 +521,7 @@ void TitleHelper::impl_appendProductName (OUStringBuffer& sTitle)
     OUString name(utl::ConfigManager::getProductName());
     if (!name.isEmpty())
     {
-        if (sTitle.getLength() != 0)
+        if (!sTitle.isEmpty())
             sTitle.appendAscii(RTL_CONSTASCII_STRINGPARAM(" - "));
         sTitle.append(name);
     }
diff --git a/framework/source/recording/dispatchrecorder.cxx b/framework/source/recording/dispatchrecorder.cxx
index 708b4cdd2dbf..a50407799871 100644
--- a/framework/source/recording/dispatchrecorder.cxx
+++ b/framework/source/recording/dispatchrecorder.cxx
@@ -356,7 +356,7 @@ void SAL_CALL DispatchRecorder::implts_recordMacro( const OUString& aURL,
         {
             sValBuffer.setLength(0);
         }
-        if (!sValBuffer.getLength())
+        if (sValBuffer.isEmpty())
             continue;
 
         {
diff --git a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
index 4e962c8edccd..d8b85cc14b16 100644
--- a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
+++ b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
@@ -411,7 +411,7 @@ void lcl_formatPersianWord( sal_Int32 nNumber, OUString& rsResult )
 
         if ((nDigit = nPart % 100) < 20)
         {
-            if (aTemp.getLength())
+            if (!aTemp.isEmpty())
                 aTemp.insert( 0, sal_Unicode(0x0020));
             aTemp.insert( 0, table_PersianWord_decade1[nDigit]);
         }
@@ -419,13 +419,13 @@ void lcl_formatPersianWord( sal_Int32 nNumber, OUString& rsResult )
         {
             if ((nDigit = nPart % 10) != 0)
             {
-                if (aTemp.getLength())
+                if (!aTemp.isEmpty())
                     aTemp.insert( 0, asPersianWord_conjunction);
                 aTemp.insert( 0, table_PersianWord_decade1[nDigit]);
             }
             if ((nDigit = (nPart / 10) % 10) != 0)
             {
-                if (aTemp.getLength())
+                if (!aTemp.isEmpty())
                     aTemp.insert( 0, asPersianWord_conjunction);
                 aTemp.insert( 0, table_PersianWord_decade2[nDigit-2]);
             }
@@ -433,7 +433,7 @@ void lcl_formatPersianWord( sal_Int32 nNumber, OUString& rsResult )
 
         if ((nDigit = nPart / 100) != 0)
         {
-            if (aTemp.getLength())
+            if (!aTemp.isEmpty())
                 aTemp.insert( 0, asPersianWord_conjunction);
             aTemp.insert( 0, table_PersianWord_decade3[nDigit-1]);
         }
diff --git a/i18npool/source/localedata/LocaleNode.cxx b/i18npool/source/localedata/LocaleNode.cxx
index fc211343fe41..35c7ff42e7c9 100644
--- a/i18npool/source/localedata/LocaleNode.cxx
+++ b/i18npool/source/localedata/LocaleNode.cxx
@@ -1022,7 +1022,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     if (!(nDetected & 4))
                     {
                         aPatternBuf.append( 'Y');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'Y');
                         nDetected |= 4;
                     }
@@ -1032,7 +1032,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     if (!(nDetected & 2))
                     {
                         aPatternBuf.append( 'M');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'M');
                         nDetected |= 2;
                     }
@@ -1042,7 +1042,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     if (!(nDetected & 1))
                     {
                         aPatternBuf.append( 'D');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'D');
                         nDetected |= 1;
                     }
@@ -1076,7 +1076,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                         aPatternBuf2 = aPatternBuf;
                     if (cChar == cDateSep || cChar == cDateSep2)
                         aPatternBuf.append( OUString( &cDateSep, 1));   // always the defined separator
-                    if (cChar == cDateSep2 && aPatternBuf2.getLength() > 0)
+                    if (cChar == cDateSep2 && !aPatternBuf2.isEmpty())
                         aPatternBuf2.append( OUString( &cDateSep2, 1)); // always the format's separator
                     break;
                 // The localized legacy:
@@ -1088,7 +1088,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                         // it GG/MM/AAAA
                         // fr_CA AAAA-MM-JJ
                         aPatternBuf.append( 'Y');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'Y');
                         nDetected |= 4;
                     }
@@ -1099,7 +1099,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                         // fr JJ.MM.AAAA
                         // fr_CA AAAA-MM-JJ
                         aPatternBuf.append( 'D');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'D');
                         nDetected |= 1;
                     }
@@ -1108,7 +1108,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                         // nl DD-MM-JJJJ
                         // de TT.MM.JJJJ
                         aPatternBuf.append( 'Y');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'Y');
                         nDetected |= 4;
                     }
@@ -1118,7 +1118,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     {
                         // de TT.MM.JJJJ
                         aPatternBuf.append( 'D');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'D');
                         nDetected |= 1;
                     }
@@ -1128,7 +1128,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     {
                         // it GG/MM/AAAA
                         aPatternBuf.append( 'D');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'D');
                         nDetected |= 1;
                     }
@@ -1138,7 +1138,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     {
                         // fi PP.KK.VVVV
                         aPatternBuf.append( 'D');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'D');
                         nDetected |= 1;
                     }
@@ -1148,7 +1148,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     {
                         // fi PP.KK.VVVV
                         aPatternBuf.append( 'M');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'M');
                         nDetected |= 2;
                     }
@@ -1158,7 +1158,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
                     {
                         // fi PP.KK.VVVV
                         aPatternBuf.append( 'Y');
-                        if (aPatternBuf2.getLength() > 0)
+                        if (!aPatternBuf2.isEmpty())
                             aPatternBuf2.append( 'Y');
                         nDetected |= 4;
                     }
@@ -1182,7 +1182,7 @@ void LCFormatNode::generateCode (const OFileWriter &of) const
             // Insert at front so full date pattern is first in checks.
             theDateAcceptancePatterns.insert( theDateAcceptancePatterns.begin(), aPattern);
         }
-        if (aPatternBuf2.getLength() > 0)
+        if (!aPatternBuf2.isEmpty())
         {
             OUString aPattern2( aPatternBuf2.makeStringAndClear());
             if (aPattern2.getLength() < 5)