summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2014-01-29 16:32:06 +0000
committerCaolán McNamara <caolanm@redhat.com>2014-01-29 16:41:38 +0000
commit29aa5166e56e32f6a5471d375fd5fe9aac084d30 (patch)
tree29812c13d03c8acdd52b9a10e160659e12809e3c
parentc651ac080b6cb7dced52ad098fb6b66e875f467a (diff)
revert coverity#1158232 Resource leak
coverity doesn't seem to understand auto_ptr wrt to sc/source/core/tool/dbdata.cxx noescape: "ScDBCollection::NamedDBs::insert(ScDBData *)" does not free or save its pointer parameter "p". bool ScDBCollection::NamedDBs::insert(ScDBData* p) then again, neither did I Change-Id: I7113b909afb96b518cf0d9321ad5541e16cacfa7
-rw-r--r--sc/qa/unit/ucalc_formula.cxx4
1 files changed, 1 insertions, 3 deletions
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 565c576dace8..b19afdceb03f 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -101,9 +101,7 @@ void Test::testFormulaCreateStringFromTokens()
ScDBData* pData = new ScDBData(
OUString::createFromAscii(
aDBs[i].pName), aDBs[i].nTab, aDBs[i].nCol1, aDBs[i].nRow1, aDBs[i].nCol2,aDBs[i].nRow2);
- bool bInserted = pDBs->getNamedDBs().insert(pData);
- if (!bInserted)
- delete pData;
+ pDBs->getNamedDBs().insert(pData);
}
const char* aTests[] = {