summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Stahl <mstahl@redhat.com>2015-09-14 12:50:55 +0200
committerMichael Stahl <mstahl@redhat.com>2015-09-14 12:51:45 +0200
commite6ae8ce99566f59b2011f614160f6bdd4d5034cc (patch)
treefbbe92a884c5b493a47a033d9285e7a5849b93e4
parentc3b4f7b55e87edb56ae0d08e1902269f0b2e8c9a (diff)
gbuild: add a comment why C4589 is disabled
Change-Id: I25f03d64b44c4bf8c913d0be77f1f4919355998a
-rw-r--r--solenv/gbuild/platform/com_MSC_defs.mk3
1 files changed, 3 insertions, 0 deletions
diff --git a/solenv/gbuild/platform/com_MSC_defs.mk b/solenv/gbuild/platform/com_MSC_defs.mk
index 6b1de35267e3..ab67e64b89cb 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -120,6 +120,9 @@ gb_AFLAGS := $(AFLAGS)
# C4512: 'class' : assignment operator could not be generated
+# C4589: Constructor of abstract class 'Derived' ignores initializer for
+# virtual base class 'Base' https://codereview.chromium.org/1234253003
+
# C4611: interaction between 'function' and C++ object destruction is
# non-portable