diff options
| author | Noel Grandin <noel@peralex.com> | 2016-03-22 15:56:13 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2016-03-23 09:13:14 +0200 |
| commit | 26012ae8f65ca16e584b3688b0f1f9e76e97db84 (patch) | |
| tree | 6c16a437f7aabbc36b60d162b0899cb2c657229e | |
| parent | 50b39947cb23ec6a9de3845da4aea9ae53fd3cfa (diff) | |
loplugin:constantparam in sc
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
130 files changed, 544 insertions, 734 deletions
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx index 856d938f7d8a..20775a5d5814 100644 --- a/sc/inc/dociter.hxx +++ b/sc/inc/dociter.hxx @@ -470,8 +470,7 @@ private: public: ScHorizontalValueIterator( ScDocument* pDocument, - const ScRange& rRange, - bool bTextAsZero = false ); + const ScRange& rRange ); ~ScHorizontalValueIterator(); /// Does NOT reset rValue if no value found! bool GetNext( double& rValue, sal_uInt16& rErr ); diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 825e511a0c07..6153a2b6d07a 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -912,8 +912,7 @@ public: const ScMarkData& rMark, const OUString& rFormula, const ScTokenArray* p = nullptr, - const formula::FormulaGrammar::Grammar = formula::FormulaGrammar::GRAM_DEFAULT, - bool bDirtyFlag=true ); + const formula::FormulaGrammar::Grammar = formula::FormulaGrammar::GRAM_DEFAULT ); SC_DLLPUBLIC void InsertTableOp(const ScTabOpParam& rParam, // multi-operation SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, const ScMarkData& rMark); @@ -1513,7 +1512,7 @@ public: double nPPTX, double nPPTY, const Fraction& rZoomX, const Fraction& rZoomY ); - bool IsStyleSheetUsed( const ScStyleSheet& rStyle, bool bGatherAllStyles ) const; + bool IsStyleSheetUsed( const ScStyleSheet& rStyle ) const; SC_DLLPUBLIC bool ApplyFlagsTab( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, SCROW nEndRow, @@ -1522,10 +1521,8 @@ public: SCCOL nEndCol, SCROW nEndRow, SCTAB nTab, sal_Int16 nFlags ); - SC_DLLPUBLIC void SetPattern( const ScAddress&, const ScPatternAttr& rAttr, - bool bPutToPool = false ); - SC_DLLPUBLIC void SetPattern( SCCOL nCol, SCROW nRow, SCTAB nTab, const ScPatternAttr& rAttr, - bool bPutToPool = false ); + SC_DLLPUBLIC void SetPattern( const ScAddress&, const ScPatternAttr& rAttr ); + SC_DLLPUBLIC void SetPattern( SCCOL nCol, SCROW nRow, SCTAB nTab, const ScPatternAttr& rAttr ); void AutoFormat( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, SCROW nEndRow, sal_uInt16 nFormatNo, const ScMarkData& rMark ); @@ -1654,11 +1651,7 @@ public: SCCOL GetNextDifferentChangedCol( SCTAB nTab, SCCOL nStart) const; - // if bCareManualSize is set then the row - // heights are compared only if the manual size flag for - // the row is set. If the bCareManualSize is not set then - // the row heights are always compared. - SCROW GetNextDifferentChangedRow( SCTAB nTab, SCROW nStart, bool bCareManualSize = true) const; + SCROW GetNextDifferentChangedRow( SCTAB nTab, SCROW nStart) const; // returns whether to export a Default style for this col or not // nDefault is setted to one position in the current row where the Default style is @@ -1756,7 +1749,7 @@ public: * database range that contains the specified cell position. */ void GetFilterEntries( - SCCOL nCol, SCROW nRow, SCTAB nTab, bool bFilter, std::vector<ScTypedStrData>& rStrings, bool& rHasDates); + SCCOL nCol, SCROW nRow, SCTAB nTab, std::vector<ScTypedStrData>& rStrings, bool& rHasDates); SC_DLLPUBLIC void GetFilterEntriesArea( SCCOL nCol, SCROW nStartRow, SCROW nEndRow, SCTAB nTab, bool bCaseSens, @@ -1958,7 +1951,7 @@ public: * recalculated. */ SC_DLLPUBLIC void CalcFormulaTree( - bool bOnlyForced = false, bool bProgressBar = true, bool bSetAllDirty = true ); + bool bOnlyForced = false, bool bProgressBar = true, bool bSetAllDirty = true ); void ClearFormulaTree(); void AppendToFormulaTrack( ScFormulaCell* pCell ); void RemoveFromFormulaTrack( ScFormulaCell* pCell ); @@ -2204,7 +2197,7 @@ private: void DeleteDrawLayer(); SC_DLLPUBLIC bool DrawGetPrintArea( ScRange& rRange, bool bSetHor, bool bSetVer ) const; void DrawMovePage( sal_uInt16 nOldPos, sal_uInt16 nNewPos ); - void DrawCopyPage( sal_uInt16 nOldPos, sal_uInt16 nNewPos, bool bSkipNotes = false ); + void DrawCopyPage( sal_uInt16 nOldPos, sal_uInt16 nNewPos ); void UpdateDrawPrinter(); void UpdateDrawLanguages(); diff --git a/sc/inc/dptabres.hxx b/sc/inc/dptabres.hxx index d2e0b99fcbc6..900fa3e03121 100644 --- a/sc/inc/dptabres.hxx +++ b/sc/inc/dptabres.hxx @@ -260,7 +260,7 @@ private: bool mbAllChildren:1; public: LateInitParams( const ::std::vector<ScDPDimension*>& ppDim, const ::std::vector<ScDPLevel*>& ppLev, - bool bRow, bool bInitChild = true, bool bAllChildren = false); + bool bRow); ~LateInitParams(); void SetInitChild( bool b ) { mbInitChild = b; } @@ -350,7 +350,7 @@ private: sal_uInt16 nMemberStep; // step to show details public: ScDPResultMember( - const ScDPResultData* pData, const ScDPParentDimData& rParentDimData, bool bForceSub ); //! Ref + const ScDPResultData* pData, const ScDPParentDimData& rParentDimData ); //! Ref ScDPResultMember( const ScDPResultData* pData, bool bForceSub ); ~ScDPResultMember(); diff --git a/sc/inc/editutil.hxx b/sc/inc/editutil.hxx index 340d579247a0..5eee49f4d672 100644 --- a/sc/inc/editutil.hxx +++ b/sc/inc/editutil.hxx @@ -224,7 +224,7 @@ private: ScHeaderFieldData aData; public: - ScHeaderEditEngine( SfxItemPool* pEnginePool, bool bDeleteEnginePool = false ); + ScHeaderEditEngine( SfxItemPool* pEnginePool ); virtual OUString CalcFieldValue( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos, Color*& rTxtColor, Color*& rFldColor ) override; void SetNumType(SvxNumType eNew) { aData.eNumType = eNew; } @@ -237,8 +237,7 @@ class ScNoteEditEngine : public ScEditEngineDefaulter public: ScNoteEditEngine( SfxItemPool* pEnginePool, - SfxItemPool* pTextObjectPool = nullptr, - bool bDeleteEnginePool = false ); + SfxItemPool* pTextObjectPool = nullptr ); }; diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx index 14f2a2b83faa..ff00b47d08b9 100644 --- a/sc/inc/externalrefmgr.hxx +++ b/sc/inc/externalrefmgr.hxx @@ -266,7 +266,7 @@ public: * Set a table as referenced, used only during store-to-file. * @returns <TRUE/> if ALL tables of ALL documents are marked. */ - bool setCacheTableReferenced( sal_uInt16 nFileId, const OUString& rTabName, size_t nSheets, bool bPermanent ); + bool setCacheTableReferenced( sal_uInt16 nFileId, const OUString& rTabName, size_t nSheets ); void setAllCacheTableReferencedStati( bool bReferenced ); bool areAllCacheTablesReferenced() const { return maReferenced.mbAllReferenced;} diff --git a/sc/inc/filter.hxx b/sc/inc/filter.hxx index 4f93743eb0b6..8ea69de84f71 100644 --- a/sc/inc/filter.hxx +++ b/sc/inc/filter.hxx @@ -98,7 +98,7 @@ class SAL_DLLPUBLIC_RTTI ScFormatFilterPlugin { // various import helpers virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) = 0; - virtual ScEEAbsImport *CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange, bool bCalcWidthHeight ) = 0; + virtual ScEEAbsImport *CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange ) = 0; virtual OUString GetHTMLRangeNameList( ScDocument* pDoc, const OUString& rOrigName ) = 0; // various export filters diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx index 2d4c0476d230..7f93444fc759 100644 --- a/sc/inc/formulacell.hxx +++ b/sc/inc/formulacell.hxx @@ -158,7 +158,7 @@ public: virtual ~ScFormulaCell(); ScFormulaCell* Clone() const; - ScFormulaCell* Clone( const ScAddress& rPos, int nCloneFlags ) const; + ScFormulaCell* Clone( const ScAddress& rPos ) const; ScFormulaCell( ScDocument* pDoc, const ScAddress& rPos ); diff --git a/sc/inc/olinetab.hxx b/sc/inc/olinetab.hxx index 27ec0d365375..6b4824402a1f 100644 --- a/sc/inc/olinetab.hxx +++ b/sc/inc/olinetab.hxx @@ -111,7 +111,7 @@ public: SCCOLROW nBlockStart, SCCOLROW nBlockEnd, size_t& rFindLevel) const; bool Insert( SCCOLROW nStartPos, SCCOLROW nEndPos, bool& rSizeChanged, - bool bHidden = false, bool bVisible = true ); + bool bHidden = false ); bool Remove( SCCOLROW nBlockStart, SCCOLROW nBlockEnd, bool& rSizeChanged ); ScOutlineEntry* GetEntry(size_t nLevel, size_t nIndex); @@ -136,7 +136,7 @@ public: bool ManualAction( SCCOLROW nStartPos, SCCOLROW nEndPos, bool bShow, const ScTable& rTable, bool bCol); - void finalizeImport(ScTable& rTable, bool bCol); + void finalizeImport(ScTable& rTable); void RemoveAll(); }; diff --git a/sc/inc/pivot.hxx b/sc/inc/pivot.hxx index f0dd99b94de0..c0c21cca1860 100644 --- a/sc/inc/pivot.hxx +++ b/sc/inc/pivot.hxx @@ -120,7 +120,7 @@ struct ScPivotField css::sheet::DataPilotFieldReference maFieldRef; - explicit ScPivotField( SCCOL nNewCol = 0, sal_uInt16 nNewFuncMask = PIVOT_FUNC_NONE ); + explicit ScPivotField( SCCOL nNewCol = 0 ); ScPivotField( const ScPivotField& r ); long getOriginalDim() const; diff --git a/sc/inc/postit.hxx b/sc/inc/postit.hxx index 5b111c404217..8a7dec86a792 100644 --- a/sc/inc/postit.hxx +++ b/sc/inc/postit.hxx @@ -60,7 +60,7 @@ public: /** Creates an empty note and its caption object and places it according to the passed cell position. */ - explicit ScPostIt( ScDocument& rDoc, const ScAddress& rPos, bool bShown ); + explicit ScPostIt( ScDocument& rDoc, const ScAddress& rPos ); /** Copy constructor. Clones the note and its caption to a new document. */ explicit ScPostIt( ScDocument& rDoc, const ScAddress& rPos, const ScPostIt& rNote ); diff --git a/sc/inc/rechead.hxx b/sc/inc/rechead.hxx index b5e5cb78da25..9d2ac1291353 100644 --- a/sc/inc/rechead.hxx +++ b/sc/inc/rechead.hxx @@ -70,12 +70,12 @@ class ScMultipleWriteHeader private: SvStream& rStream; SvMemoryStream aMemStream; - sal_uLong nDataPos; + sal_uLong nDataPos; sal_uInt32 nDataSize; - sal_uLong nEntryStart; + sal_uLong nEntryStart; public: - ScMultipleWriteHeader(SvStream& rNewStream, sal_uInt32 nDefault = 0); + ScMultipleWriteHeader(SvStream& rNewStream); ~ScMultipleWriteHeader(); void StartEntry(); diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx index c515d5bf2722..8b46a097edf0 100644 --- a/sc/inc/scabstdlg.hxx +++ b/sc/inc/scabstdlg.hxx @@ -372,15 +372,13 @@ public: sal_uInt16 nPossDir) = 0; virtual AbstractScGroupDlg * CreateAbstractScGroupDlg( vcl::Window* pParent, - bool bUnGroup = false, - bool bRows = true ) = 0; + bool bUnGroup = false ) = 0; virtual AbstractScInsertCellDlg * CreateScInsertCellDlg( vcl::Window* pParent, int nId, bool bDisallowCellMove = false ) = 0; virtual AbstractScInsertContentsDlg * CreateScInsertContentsDlg( vcl::Window* pParent, - InsertDeleteFlags nCheckDefaults = InsertDeleteFlags::NONE, const OUString* pStrTitle = nullptr ) = 0; virtual AbstractScInsertTableDlg * CreateScInsertTableDlg(vcl::Window* pParent, ScViewData& rViewData, @@ -421,8 +419,7 @@ public: ScDPObject& rDPObj, const ScDPLabelData& rLabelData, const ScPivotFuncData& rFuncData, - const ScDPNameVec& rDataFields, - bool bEnableLayout ) = 0; + const ScDPNameVec& rDataFields ) = 0; virtual AbstractScDPNumGroupDlg * CreateScDPNumGroupDlg( vcl::Window* pParent, int nId, diff --git a/sc/inc/segmenttree.hxx b/sc/inc/segmenttree.hxx index 7e8025c88c38..25eecec120f2 100644 --- a/sc/inc/segmenttree.hxx +++ b/sc/inc/segmenttree.hxx @@ -71,7 +71,7 @@ public: bool getRangeData(SCROW nRow, RangeData& rData) const; bool getRangeDataLeaf(SCROW nRow, RangeData& rData); void removeSegment(SCROW nRow1, SCROW nRow2); - void insertSegment(SCROW nRow, SCROW nSize, bool bSkipStartBoundary); + void insertSegment(SCROW nRow, SCROW nSize); SCROW findLastTrue() const; @@ -96,7 +96,7 @@ public: bool setFalse(SCCOL nCol1, SCCOL nCol2); bool getRangeData(SCCOL nCol, RangeData& rData); void removeSegment(SCCOL nCol1, SCCOL nCol2); - void insertSegment(SCCOL nCol, SCCOL nSize, bool bSkipStartBoundary); + void insertSegment(SCCOL nCol, SCCOL nSize); private: ::std::unique_ptr<ScFlatBoolSegmentsImpl> mpImpl; @@ -139,7 +139,7 @@ public: sal_uInt32 getSumValue(SCROW nRow1, SCROW nRow2); bool getRangeData(SCROW nRow, RangeData& rData); void removeSegment(SCROW nRow1, SCROW nRow2); - void insertSegment(SCROW nRow, SCROW nSize, bool bSkipStartBoundary); + void insertSegment(SCROW nRow, SCROW nSize); SCROW findLastTrue(sal_uInt16 nValue) const; diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 77a42e6a8731..5dba406d3c85 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -4184,7 +4184,7 @@ void Test::testCopyPasteRepeatOneFormula() } // Delete row at row 1 to shift the cells up. - rFunc.DeleteCells(aRowOne, &aMark, DEL_DELROWS, true, true); + rFunc.DeleteCells(aRowOne, &aMark, DEL_DELROWS, true); // Check the formula results again. for (SCROW i = 0; i < 10; ++i) @@ -4637,7 +4637,7 @@ void Test::testAutoFill() m_pDoc->SetValue(ScAddress(0,0,0), 1.0); ScRange aRange(0,0,0,0,5,0); aMarkData.SetMarkArea(aRange); - rFunc.FillSeries(aRange, &aMarkData, FILL_TO_BOTTOM, FILL_AUTO, FILL_DAY, MAXDOUBLE, 1.0, MAXDOUBLE, true, true); + rFunc.FillSeries(aRange, &aMarkData, FILL_TO_BOTTOM, FILL_AUTO, FILL_DAY, MAXDOUBLE, 1.0, MAXDOUBLE, true); CPPUNIT_ASSERT_EQUAL(1.0, m_pDoc->GetValue(ScAddress(0,0,0))); CPPUNIT_ASSERT_EQUAL(2.0, m_pDoc->GetValue(ScAddress(0,1,0))); CPPUNIT_ASSERT_EQUAL(3.0, m_pDoc->GetValue(ScAddress(0,2,0))); @@ -5092,7 +5092,7 @@ void Test::testNoteDeleteRow() ScDocFunc& rDocFunc = getDocShell().GetDocFunc(); ScMarkData aMark; aMark.SelectOneTable(0); - rDocFunc.DeleteCells(ScRange(0,1,0,MAXCOL,1,0), &aMark, DEL_CELLSUP, true, true); + rDocFunc.DeleteCells(ScRange(0,1,0,MAXCOL,1,0), &aMark, DEL_CELLSUP, true); // Check to make sure the notes have shifted upward. pNote = m_pDoc->GetNote(ScAddress(1,1,0)); @@ -5121,7 +5121,7 @@ void Test::testNoteDeleteRow() CPPUNIT_ASSERT_EQUAL(OUString("Second Note"), pNote->GetText()); // Delete row 3. - rDocFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true, true); + rDocFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true); pNote = m_pDoc->GetNote(ScAddress(1,2,0)); CPPUNIT_ASSERT_MESSAGE("B3 should have a note.", pNote); @@ -5767,7 +5767,7 @@ void Test::testTransliterateText() aMark.SetMarkArea(ScRange(0,0,0,0,2,0)); ScDocFunc& rFunc = getDocShell().GetDocFunc(); rFunc.TransliterateText( - aMark, i18n::TransliterationModules_LOWERCASE_UPPERCASE, true, true); + aMark, i18n::TransliterationModules_LOWERCASE_UPPERCASE, true); CPPUNIT_ASSERT_EQUAL(OUString("MIKE"), m_pDoc->GetString(ScAddress(0,0,0))); CPPUNIT_ASSERT_EQUAL(OUString("NOAH"), m_pDoc->GetString(ScAddress(0,1,0))); @@ -5828,7 +5828,7 @@ void Test::testFormulaToValue() // Convert B5:C6 to static values, and check the result. ScDocFunc& rFunc = getDocShell().GetDocFunc(); ScRange aConvRange(1,4,0,2,5,0); // B5:C6 - rFunc.ConvertFormulaToValue(aConvRange, true, false); + rFunc.ConvertFormulaToValue(aConvRange, false); { // Expected output table content. 0 = empty cell @@ -5987,7 +5987,7 @@ void Test::testFormulaToValue2() // Convert B3:B5 to a value. ScDocFunc& rFunc = getDocShell().GetDocFunc(); ScRange aConvRange(1,2,0,1,4,0); // B3:B5 - rFunc.ConvertFormulaToValue(aConvRange, true, false); + rFunc.ConvertFormulaToValue(aConvRange, false); { // Expected output table content. 0 = empty cell diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index e8ff482a4100..2282fdaadc5c 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -2474,7 +2474,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftLeft() ScMarkData aMark; aMark.SelectOneTable(0); ScDocFunc& rFunc = getDocShell().GetDocFunc(); - bool bDeleted = rFunc.DeleteCells(ScRange(3,0,0,4,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + bool bDeleted = rFunc.DeleteCells(ScRange(3,0,0,4,MAXROW,0), &aMark, DEL_CELLSLEFT, true); CPPUNIT_ASSERT(bDeleted); aPos.IncCol(-2); @@ -2493,7 +2493,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftLeft() CPPUNIT_FAIL("Wrong formula!"); // Delete columns C:D (left end of the reference). - bDeleted = rFunc.DeleteCells(ScRange(2,0,0,3,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + bDeleted = rFunc.DeleteCells(ScRange(2,0,0,3,MAXROW,0), &aMark, DEL_CELLSLEFT, true); CPPUNIT_ASSERT(bDeleted); aPos.IncCol(-2); @@ -2509,7 +2509,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftLeft() CPPUNIT_FAIL("Wrong formula!"); // Delete columns B:E (overlaps on the left). - bDeleted = rFunc.DeleteCells(ScRange(1,0,0,4,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + bDeleted = rFunc.DeleteCells(ScRange(1,0,0,4,MAXROW,0), &aMark, DEL_CELLSLEFT, true); CPPUNIT_ASSERT(bDeleted); aPos.IncCol(-4); @@ -2537,7 +2537,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftLeft() CPPUNIT_ASSERT_EQUAL(21.0, m_pDoc->GetValue(aPos)); // Delete columns F:H (right end of the reference). - bDeleted = rFunc.DeleteCells(ScRange(5,0,0,7,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + bDeleted = rFunc.DeleteCells(ScRange(5,0,0,7,MAXROW,0), &aMark, DEL_CELLSLEFT, true); CPPUNIT_ASSERT(bDeleted); CPPUNIT_ASSERT_EQUAL(6.0, m_pDoc->GetValue(aPos)); @@ -2551,7 +2551,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftLeft() CPPUNIT_FAIL("Wrong formula!"); // Delete columns G:I (overlaps on the right). - bDeleted = rFunc.DeleteCells(ScRange(6,0,0,8,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + bDeleted = rFunc.DeleteCells(ScRange(6,0,0,8,MAXROW,0), &aMark, DEL_CELLSLEFT, true); CPPUNIT_ASSERT(bDeleted); CPPUNIT_ASSERT_EQUAL(10.0, m_pDoc->GetValue(aPos)); @@ -2587,7 +2587,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftUp() ScMarkData aMark; aMark.SelectOneTable(0); ScDocFunc& rFunc = getDocShell().GetDocFunc(); - bool bDeleted = rFunc.DeleteCells(ScRange(0,3,0,MAXCOL,4,0), &aMark, DEL_CELLSUP, true, true); + bool bDeleted = rFunc.DeleteCells(ScRange(0,3,0,MAXCOL,4,0), &aMark, DEL_CELLSUP, true); CPPUNIT_ASSERT(bDeleted); aPos.IncRow(-2); @@ -2606,7 +2606,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftUp() CPPUNIT_FAIL("Wrong formula!"); // Delete rows 3:4 (top end of the reference). - bDeleted = rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,3,0), &aMark, DEL_CELLSUP, true, true); + bDeleted = rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,3,0), &aMark, DEL_CELLSUP, true); CPPUNIT_ASSERT(bDeleted); aPos.IncRow(-2); @@ -2622,7 +2622,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftUp() CPPUNIT_FAIL("Wrong formula!"); // Delete rows 2:5 (overlaps on the top). - bDeleted = rFunc.DeleteCells(ScRange(0,1,0,MAXCOL,4,0), &aMark, DEL_CELLSUP, true, true); + bDeleted = rFunc.DeleteCells(ScRange(0,1,0,MAXCOL,4,0), &aMark, DEL_CELLSUP, true); CPPUNIT_ASSERT(bDeleted); aPos.IncRow(-4); @@ -2650,7 +2650,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftUp() CPPUNIT_ASSERT_EQUAL(21.0, m_pDoc->GetValue(aPos)); // Delete rows 6:8 (bottom end of the reference). - bDeleted = rFunc.DeleteCells(ScRange(0,5,0,MAXCOL,7,0), &aMark, DEL_CELLSUP, true, true); + bDeleted = rFunc.DeleteCells(ScRange(0,5,0,MAXCOL,7,0), &aMark, DEL_CELLSUP, true); CPPUNIT_ASSERT(bDeleted); CPPUNIT_ASSERT_EQUAL(6.0, m_pDoc->GetValue(aPos)); @@ -2664,7 +2664,7 @@ void Test::testFormulaRefUpdateDeleteAndShiftUp() CPPUNIT_FAIL("Wrong formula!"); // Delete rows 7:9 (overlaps on the bottom). - bDeleted = rFunc.DeleteCells(ScRange(0,6,0,MAXCOL,8,0), &aMark, DEL_CELLSUP, true, true); + bDeleted = rFunc.DeleteCells(ScRange(0,6,0,MAXCOL,8,0), &aMark, DEL_CELLSUP, true); CPPUNIT_ASSERT(bDeleted); CPPUNIT_ASSERT_EQUAL(10.0, m_pDoc->GetValue(aPos)); @@ -3043,14 +3043,14 @@ void Test::testFormulaRefUpdateNameDeleteRow() // Delete row 3. ScMarkData aMark; aMark.SelectOneTable(0); - rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true, true); + rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true); // The reference in the name should get updated to B2:B3. aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$3"), aExpr); // Delete row 3 again. - rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true, true); + rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true); aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$2"), aExpr); @@ -3078,7 +3078,7 @@ void Test::testFormulaRefUpdateNameDeleteRow() CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$4"), aExpr); // Delete row 2-3. - rFunc.DeleteCells(ScRange(0,1,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true, true); + rFunc.DeleteCells(ScRange(0,1,0,MAXCOL,2,0), &aMark, DEL_CELLSUP, true); aExpr = pCode->CreateString(aCxt, ScAddress(0,0,0)); CPPUNIT_ASSERT_EQUAL(OUString("$B$2:$B$2"), aExpr); @@ -3097,7 +3097,7 @@ void Test::testFormulaRefUpdateNameDeleteRow() ScMarkData aMark2; aMark2.SelectOneTable(1); - rFunc.DeleteCells(ScRange(0,2,1,MAXCOL,2,1), &aMark2, DEL_CELLSUP, true, true); + rFunc.DeleteCells(ScRange(0,2,1,MAXCOL,2,1), &aMark2, DEL_CELLSUP, true); pName = m_pDoc->GetRangeName()->findByUpperName("MYRANGE"); CPPUNIT_ASSERT(pName); @@ -5118,7 +5118,7 @@ void Test::testFormulaDepTrackingDeleteRow() ScDocFunc& rFunc = getDocShell().GetDocFunc(); ScMarkData aMark; aMark.SelectOneTable(0); - rFunc.DeleteCells(ScRange(0,1,0,MAXCOL,1,0), &aMark, DEL_CELLSUP, true, true); + rFunc.DeleteCells(ScRange(0,1,0,MAXCOL,1,0), &aMark, DEL_CELLSUP, true); pBC = m_pDoc->GetBroadcaster(ScAddress(0,3,0)); CPPUNIT_ASSERT_MESSAGE("Broadcaster at A5 should have shifted to A4.", pBC); @@ -5176,7 +5176,7 @@ void Test::testFormulaDepTrackingDeleteCol() ScDocFunc& rFunc = getDocShell().GetDocFunc(); ScMarkData aMark; aMark.SelectOneTable(0); - rFunc.DeleteCells(ScRange(0,0,0,0,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + rFunc.DeleteCells(ScRange(0,0,0,0,MAXROW,0), &aMark, DEL_CELLSLEFT, true); { // Expected output table content. 0 = empty cell diff --git a/sc/qa/unit/ucalc_sharedformula.cxx b/sc/qa/unit/ucalc_sharedformula.cxx index d543deb8dc61..8ae2cf9ed83e 100644 --- a/sc/qa/unit/ucalc_sharedformula.cxx +++ b/sc/qa/unit/ucalc_sharedformula.cxx @@ -681,7 +681,7 @@ void Test::testSharedFormulasRefUpdateRangeDeleteRow() ScDocFunc& rFunc = getDocShell().GetDocFunc(); ScMarkData aMark; aMark.SelectOneTable(0); - rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_DELROWS, true, true); + rFunc.DeleteCells(ScRange(0,2,0,MAXCOL,2,0), &aMark, DEL_DELROWS, true); // Make sure C1:C4 belong to the same group. pFC = m_pDoc->GetFormulaCell(ScAddress(2,0,0)); @@ -787,7 +787,7 @@ void Test::testSharedFormulasRefUpdateExternal() ScDocFunc& rDocFunc = getDocShell().GetDocFunc(); ScMarkData aMark; aMark.SelectOneTable(0); - rDocFunc.DeleteCells(ScRange(0,0,0,MAXCOL,1,0), &aMark, DEL_CELLSUP, true, true); + rDocFunc.DeleteCells(ScRange(0,0,0,MAXCOL,1,0), &aMark, DEL_CELLSUP, true); // Check the shifted formula cells now in A5:A8. if (!checkFormula(*m_pDoc, ScAddress(0,4,0), "'file:///extdata.fake'#$Data.A1")) @@ -1049,7 +1049,7 @@ void Test::testSharedFormulasDeleteColumns() CPPUNIT_ASSERT_EQUAL(11.0, m_pDoc->GetValue(ScAddress(2,0,0))); // Delete column B. - rFunc.DeleteCells(ScRange(1,0,0,1,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + rFunc.DeleteCells(ScRange(1,0,0,1,MAXROW,0), &aMark, DEL_CELLSLEFT, true); CPPUNIT_ASSERT_EQUAL(OUString("#REF!"), m_pDoc->GetString(ScAddress(1,0,0))); // The reference should still point to row 1 but the column status should be set to 'deleted'. @@ -1092,7 +1092,7 @@ void Test::testSharedFormulasDeleteColumns() } // Delete column B. - rFunc.DeleteCells(ScRange(1,0,0,1,MAXROW,0), &aMark, DEL_CELLSLEFT, true, true); + rFunc.DeleteCells(ScRange(1,0,0,1,MAXROW,0), &aMark, DEL_CELLSLEFT, true); for (SCROW i = 0; i <= 1; ++i) { diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx index f9387c7e449d..828baec42d78 100644 --- a/sc/source/core/data/dociter.cxx +++ b/sc/source/core/data/dociter.cxx @@ -2169,14 +2169,14 @@ void ScHorizontalCellIterator::SkipInvalid() } ScHorizontalValueIterator::ScHorizontalValueIterator( ScDocument* pDocument, - const ScRange& rRange, bool bTextZero ) : + const ScRange& rRange ) : pDoc( pDocument ), nNumFmtIndex(0), nEndTab( rRange.aEnd.Tab() ), nNumFmtType( css::util::NumberFormat::UNDEFINED ), bNumValid( false ), bCalcAsShown( pDocument->GetDocOptions().IsCalcAsShown() ), - bTextAsZero( bTextZero ) + bTextAsZero( false ) { SCCOL nStartCol = rRange.aStart.Col(); SCROW nStartRow = rRange.aStart.Row(); diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx index fd8c5cd3fb7f..971ae283827c 100644 --- a/sc/source/core/data/documen2.cxx +++ b/sc/source/core/data/documen2.cxx @@ -898,7 +898,7 @@ bool ScDocument::CopyTab( SCTAB nOldPos, SCTAB nNewPos, const ScMarkData* pOnlyM SetAllFormulasDirty(aFormulaDirtyCxt); if (pDrawLayer) // Skip cloning Note caption object - DrawCopyPage( static_cast<sal_uInt16>(nOldPos), static_cast<sal_uInt16>(nNewPos), true ); + DrawCopyPage( static_cast<sal_uInt16>(nOldPos), static_cast<sal_uInt16>(nNewPos) ); if (pDPCollection) pDPCollection->CopyToTab(nOldPos, nNewPos); diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx index 4374d7b32981..79b4733a3e1f 100644 --- a/sc/source/core/data/documen3.cxx +++ b/sc/source/core/data/documen3.cxx @@ -1488,7 +1488,7 @@ void ScDocument::GetFilterSelCount( SCCOL nCol, SCROW nRow, SCTAB nTab, SCSIZE& * Entries for AutoFilter listbox */ void ScDocument::GetFilterEntries( - SCCOL nCol, SCROW nRow, SCTAB nTab, bool bFilter, std::vector<ScTypedStrData>& rStrings, bool& rHasDates) + SCCOL nCol, SCROW nRow, SCTAB nTab, std::vector<ScTypedStrData>& rStrings, bool& rHasDates) { if ( ValidTab(nTab) && nTab < static_cast<SCTAB>(maTabs.size()) && maTabs[nTab] && pDBCollection ) { @@ -1510,17 +1510,15 @@ void ScDocument::GetFilterEntries( pDBData->GetQueryParam( aParam ); // Return all filter entries, if a filter condition is connected with a boolean OR - if ( bFilter ) + bool bFilter = true; + SCSIZE nEntryCount = aParam.GetEntryCount(); + for ( SCSIZE i = 0; i < nEntryCount && aParam.GetEntry(i).bDoQuery; ++i ) { - SCSIZE nEntryCount = aParam.GetEntryCount(); - for ( SCSIZE i = 0; i < nEntryCount && aParam.GetEntry(i).bDoQuery; ++i ) + ScQueryEntry& rEntry = aParam.GetEntry(i); + if ( rEntry.eConnect != SC_AND ) { - ScQueryEntry& rEntry = aParam.GetEntry(i); - if ( rEntry.eConnect != SC_AND ) - { - bFilter = false; - break; - } + bFilter = false; + break; } } diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx index adf38d32d657..e17fada2fe5c 100644 --- a/sc/source/core/data/documen4.cxx +++ b/sc/source/core/data/documen4.cxx @@ -259,8 +259,7 @@ void ScDocument::InsertMatrixFormula(SCCOL nCol1, SCROW nRow1, const ScMarkData& rMark, const OUString& rFormula, const ScTokenArray* pArr, - const formula::FormulaGrammar::Grammar eGram, - bool bDirtyFlag ) + const formula::FormulaGrammar::Grammar eGram ) { PutInOrder(nCol1, nCol2); PutInOrder(nRow1, nRow2); @@ -280,7 +279,7 @@ void ScDocument::InsertMatrixFormula(SCCOL nCol1, SCROW nRow1, pCell = new ScFormulaCell(this, aPos, *pArr, eGram, MM_FORMULA); else pCell = new ScFormulaCell( this, aPos, rFormula, eGram, MM_FORMULA ); - pCell->SetMatColsRows( nCol2 - nCol1 + 1, nRow2 - nRow1 + 1, bDirtyFlag ); + pCell->SetMatColsRows( nCol2 - nCol1 + 1, nRow2 - nRow1 + 1 ); ScMarkData::const_iterator itr = rMark.begin(), itrEnd = rMark.end(); SCTAB nMax = static_cast<SCTAB>(maTabs.size()); for (; itr != itrEnd && *itr < nMax; ++itr) diff --git a/sc/source/core/data/documen9.cxx b/sc/source/core/data/documen9.cxx index 3185a2d68e02..5d643078aea7 100644 --- a/sc/source/core/data/documen9.cxx +++ b/sc/source/core/data/documen9.cxx @@ -261,10 +261,10 @@ void ScDocument::DrawMovePage( sal_uInt16 nOldPos, sal_uInt16 nNewPos ) pDrawLayer->ScMovePage(nOldPos,nNewPos); } -void ScDocument::DrawCopyPage( sal_uInt16 nOldPos, sal_uInt16 nNewPos, bool bSkipNotes ) +void ScDocument::DrawCopyPage( sal_uInt16 nOldPos, sal_uInt16 nNewPos ) { // page is already created in ScTable ctor - pDrawLayer->ScCopyPage( nOldPos, nNewPos, bSkipNotes ); + pDrawLayer->ScCopyPage( nOldPos, nNewPos, true/*bSkipNotes*/ ); } void ScDocument::DeleteObjectsInArea( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx index 53544c5bb073..af7ae4f286dc 100644 --- a/sc/source/core/data/document.cxx +++ b/sc/source/core/data/document.cxx @@ -4487,7 +4487,7 @@ SCCOL ScDocument::GetNextDifferentChangedCol( SCTAB nTab, SCCOL nStart) const return 0; } -SCROW ScDocument::GetNextDifferentChangedRow( SCTAB nTab, SCROW nStart, bool bCareManualSize) const +SCROW ScDocument::GetNextDifferentChangedRow( SCTAB nTab, SCROW nStart) const { if (!ValidTab(nTab) || nTab >= static_cast<SCTAB>(maTabs.size()) || !maTabs[nTab]) return 0; @@ -4522,8 +4522,7 @@ SCROW ScDocument::GetNextDifferentChangedRow( SCTAB nTab, SCROW nStart, bool bCa if (((nStartFlags & CR_MANUALBREAK) != (nFlags & CR_MANUALBREAK)) || ((nStartFlags & CR_MANUALSIZE) != (nFlags & CR_MANUALSIZE)) || (bStartHidden != bHidden) || - (bCareManualSize && (nStartFlags & CR_MANUALSIZE) && (nStartHeight != nHeight)) || - (!bCareManualSize && ((nStartHeight != nHeight)))) + (nStartHeight != nHeight)) return nRow; } @@ -4830,21 +4829,18 @@ void ScDocument::StyleSheetChanged( const SfxStyleSheetBase* pStyleSheet, bool b } } -bool ScDocument::IsStyleSheetUsed( const ScStyleSheet& rStyle, bool bGatherAllStyles ) const +bool ScDocument::IsStyleSheetUsed( const ScStyleSheet& rStyle ) const { if ( bStyleSheetUsageInvalid || rStyle.GetUsage() == ScStyleSheet::UNKNOWN ) { - if ( bGatherAllStyles ) - { - SfxStyleSheetIterator aIter( xPoolHelper->GetStylePool(), + SfxStyleSheetIterator aIter( xPoolHelper->GetStylePool(), SFX_STYLE_FAMILY_PARA ); - for ( const SfxStyleSheetBase* pStyle = aIter.First(); pStyle; - pStyle = aIter.Next() ) - { - const ScStyleSheet* pScStyle = dynamic_cast<const ScStyleSheet*>( pStyle ); - if ( pScStyle ) - pScStyle->SetUsage( ScStyleSheet::NOTUSED ); - } + for ( const SfxStyleSheetBase* pStyle = aIter.First(); pStyle; + pStyle = aIter.Next() ) + { + const ScStyleSheet* pScStyle = dynamic_cast<const ScStyleSheet*>( pStyle ); + if ( pScStyle ) + pScStyle->SetUsage( ScStyleSheet::NOTUSED ); } bool bIsUsed = false; @@ -4853,16 +4849,13 @@ bool ScDocument::IsStyleSheetUsed( const ScStyleSheet& rStyle, bool bGatherAllSt for (; it != maTabs.end(); ++it) if (*it) { - if ( (*it)->IsStyleSheetUsed( rStyle, bGatherAllStyles ) ) + if ( (*it)->IsStyleSheetUsed( rStyle, true/*bGatherAllStyles*/ ) ) { - if ( !bGatherAllStyles ) - return true; bIsUsed = true; } } - if ( bGatherAllStyles ) - bStyleSheetUsageInvalid = false; + bStyleSheetUsageInvalid = false; return bIsUsed; } @@ -4892,20 +4885,18 @@ bool ScDocument::RemoveFlagsTab( SCCOL nStartCol, SCROW nStartRow, return false; } -void ScDocument::SetPattern( SCCOL nCol, SCROW nRow, SCTAB nTab, const ScPatternAttr& rAttr, - bool bPutToPool ) +void ScDocument::SetPattern( SCCOL nCol, SCROW nRow, SCTAB nTab, const ScPatternAttr& rAttr ) { if (ValidTab(nTab) && nTab < static_cast<SCTAB>(maTabs.size())) if (maTabs[nTab]) - maTabs[nTab]->SetPattern( nCol, nRow, rAttr, bPutToPool ); + maTabs[nTab]->SetPattern( nCol, nRow, rAttr, true/*bPutToPool*/ ); } -void ScDocument::SetPattern( const ScAddress& rPos, const ScPatternAttr& rAttr, - bool bPutToPool ) +void ScDocument::SetPattern( const ScAddress& rPos, const ScPatternAttr& rAttr ) { SCTAB nTab = rPos.Tab(); if ( nTab < static_cast<SCTAB>(maTabs.size()) && maTabs[nTab]) - maTabs[nTab]->SetPattern( rPos, rAttr, bPutToPool ); + maTabs[nTab]->SetPattern( rPos, rAttr, true/*bPutToPool*/ ); } ScPatternAttr* ScDocument::CreateSelectionPattern( const ScMarkData& rMark, bool bDeep ) @@ -6386,7 +6377,7 @@ ScPostIt* ScDocument::GetOrCreateNote(const ScAddress& rPos) } ScPostIt* ScDocument::CreateNote(const ScAddress& rPos) { - ScPostIt* pPostIt = new ScPostIt(*this, rPos, false); + ScPostIt* pPostIt = new ScPostIt(*this, rPos); SetNote(rPos, pPostIt); return pPostIt; } diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx index 5cda7a0bd88b..fdc7ecb5ca34 100644 --- a/sc/source/core/data/dpobject.cxx +++ b/sc/source/core/data/dpobject.cxx @@ -2189,7 +2189,7 @@ void lcl_FillOldFields( ScPivotFieldVector& rFields, } if (bAddData && !bDataFound) - aFields.push_back(ScPivotField(PIVOT_DATA_FIELD, 0)); + aFields.push_back(ScPivotField(PIVOT_DATA_FIELD)); rFields.swap(aFields); } diff --git a/sc/source/core/data/dptabres.cxx b/sc/source/core/data/dptabres.cxx index d1eecccf339c..136a5b69779c 100644 --- a/sc/source/core/data/dptabres.cxx +++ b/sc/source/core/data/dptabres.cxx @@ -915,13 +915,13 @@ ResultMembers* ScDPResultData::GetDimResultMembers(long nDim, ScDPDimension* pDi } ScDPResultMember::ScDPResultMember( - const ScDPResultData* pData, const ScDPParentDimData& rParentDimData, bool bForceSub ) : + const ScDPResultData* pData, const ScDPParentDimData& rParentDimData ) : pResultData( pData ), aParentDimData( rParentDimData ), pChildDimension( nullptr ), pDataRoot( nullptr ), bHasElements( false ), - bForceSubTotal( bForceSub ), + bForceSubTotal( false ), bHasHiddenDetails( false ), bInitialized( false ), bAutoHidden( false ), @@ -3953,7 +3953,7 @@ SCROW ScDPResultMember::GetDataId( ) const ScDPResultMember* ScDPResultDimension::AddMember(const ScDPParentDimData &aData ) { - ScDPResultMember* pMember = new ScDPResultMember( pResultData, aData, false ); + ScDPResultMember* pMember = new ScDPResultMember( pResultData, aData ); SCROW nDataIndex = pMember->GetDataId(); maMemberArray.push_back( pMember ); @@ -3967,7 +3967,7 @@ ScDPResultMember* ScDPResultDimension::InsertMember(ScDPParentDimData *pMemberDa SCROW nInsert = 0; if ( !lcl_SearchMember( maMemberArray, pMemberData->mnOrder , nInsert ) ) { - ScDPResultMember* pNew = new ScDPResultMember( pResultData, *pMemberData, false ); + ScDPResultMember* pNew = new ScDPResultMember( pResultData, *pMemberData ); maMemberArray.insert( maMemberArray.begin()+nInsert, pNew ); SCROW nDataIndex = pMemberData->mpMemberDesc->GetItemDataId(); @@ -4051,12 +4051,12 @@ ResultMembers::~ResultMembers() } LateInitParams::LateInitParams( - const vector<ScDPDimension*>& ppDim, const vector<ScDPLevel*>& ppLev, bool bRow, bool bInitChild, bool bAllChildren ) : + const vector<ScDPDimension*>& ppDim, const vector<ScDPLevel*>& ppLev, bool bRow ) : mppDim( ppDim ), mppLev( ppLev ), mbRow( bRow ), - mbInitChild( bInitChild ), - mbAllChildren( bAllChildren ) + mbInitChild( true ), + mbAllChildren( false ) { } diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index 4f602d642b07..00badf0d0966 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -1025,9 +1025,9 @@ ScFormulaCell* ScFormulaCell::Clone() const return new ScFormulaCell(*this, *pDocument, aPos); } -ScFormulaCell* ScFormulaCell::Clone( const ScAddress& rPos, int nCloneFlags ) const +ScFormulaCell* ScFormulaCell::Clone( const ScAddress& rPos ) const { - return new ScFormulaCell(*this, *pDocument, rPos, nCloneFlags); + return new ScFormulaCell(*this, *pDocument, rPos, SC_CLONECELL_DEFAULT); } size_t ScFormulaCell::GetHash() const diff --git a/sc/source/core/data/olinetab.cxx b/sc/source/core/data/olinetab.cxx index 1d94b7925f52..5cd71f82f54c 100644 --- a/sc/source/core/data/olinetab.cxx +++ b/sc/source/core/data/olinetab.cxx @@ -184,7 +184,7 @@ void ScOutlineArray::FindEntry( } bool ScOutlineArray::Insert( - SCCOLROW nStartCol, SCCOLROW nEndCol, bool& rSizeChanged, bool bHidden, bool bVisible ) + SCCOLROW nStartCol, SCCOLROW nEndCol, bool& rSizeChanged, bool bHidden ) { rSizeChanged = false; @@ -283,7 +283,7 @@ bool ScOutlineArray::Insert( } ScOutlineEntry aNewEntry(nStartCol, nEndCol+1-nStartCol, bHidden); - aNewEntry.SetVisible( bVisible ); + aNewEntry.SetVisible( true ); aCollections[nLevel].insert(aNewEntry); return true; @@ -769,7 +769,7 @@ void ScOutlineArray::RemoveAll() nDepth = 0; } -void ScOutlineArray::finalizeImport(ScTable& rTable, bool bCol) +void ScOutlineArray::finalizeImport(ScTable& rTable) { ScSubOutlineIterator aIter( this ); ScOutlineEntry* pEntry; @@ -781,7 +781,7 @@ void ScOutlineArray::finalizeImport(ScTable& rTable, bool bCol) SCCOLROW nEntryStart = pEntry->GetStart(); SCCOLROW nEntryEnd = pEntry->GetEnd(); - SCCOLROW nEnd = rTable.LastHiddenColRow(nEntryStart, bCol); + SCCOLROW nEnd = rTable.LastHiddenColRow(nEntryStart, false/*bCol*/); bool bAllHidden = (nEntryEnd <= nEnd && nEnd < ::std::numeric_limits<SCCOLROW>::max()); diff --git a/sc/source/core/data/pivot2.cxx b/sc/source/core/data/pivot2.cxx index 67204735cf53..6c06c69cca3e 100644 --- a/sc/source/core/data/pivot2.cxx +++ b/sc/source/core/data/pivot2.cxx @@ -95,10 +95,10 @@ OUString ScDPLabelData::getDisplayName() const // ScPivotField -ScPivotField::ScPivotField(SCCOL nNewCol, sal_uInt16 nNewFuncMask) : +ScPivotField::ScPivotField(SCCOL nNewCol) : nCol(nNewCol), mnOriginalDim(-1), - nFuncMask(nNewFuncMask), + nFuncMask(0), mnDupCount(0) {} diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx index efcf23ef4caf..8eb8331ac227 100644 --- a/sc/source/core/data/postit.cxx +++ b/sc/source/core/data/postit.cxx @@ -159,7 +159,7 @@ class ScCaptionCreator { public: /** Create a new caption. The caption will not be inserted into the document. */ - explicit ScCaptionCreator( ScDocument& rDoc, const ScAddress& rPos, bool bShown, bool bTailFront ); + explicit ScCaptionCreator( ScDocument& rDoc, const ScAddress& rPos, bool bTailFront ); /** Manipulate an existing caption. */ explicit ScCaptionCreator( ScDocument& rDoc, const ScAddress& rPos, SdrCaptionObj& rCaption ); @@ -199,13 +199,13 @@ private: bool mbNegPage; }; -ScCaptionCreator::ScCaptionCreator( ScDocument& rDoc, const ScAddress& rPos, bool bShown, bool bTailFront ) : +ScCaptionCreator::ScCaptionCreator( ScDocument& rDoc, const ScAddress& rPos, bool bTailFront ) : mrDoc( rDoc ), maPos( rPos ), mpCaption( nullptr ) { Initialize(); - CreateCaption( bShown, bTailFront ); + CreateCaption( true/*bShown*/, bTailFront ); } ScCaptionCreator::ScCaptionCreator( ScDocument& rDoc, const ScAddress& rPos, SdrCaptionObj& rCaption ) : @@ -475,9 +475,9 @@ ScNoteData::~ScNoteData() { } -ScPostIt::ScPostIt( ScDocument& rDoc, const ScAddress& rPos, bool bShown ) : +ScPostIt::ScPostIt( ScDocument& rDoc, const ScAddress& rPos ) : mrDoc( rDoc ), - maNoteData( bShown ) + maNoteData( false ) { AutoStamp(); CreateCaption( rPos ); @@ -775,7 +775,7 @@ SdrCaptionObj* ScNoteUtil::CreateTempCaption( rVisRect.Bottom() - SC_NOTECAPTION_BORDERDIST_TEMP ); // create the caption object - ScCaptionCreator aCreator( rDoc, rPos, true, bTailFront ); + ScCaptionCreator aCreator( rDoc, rPos, bTailFront ); SdrCaptionObj* pCaption = aCreator.GetCaption(); // insert caption into page (needed to set caption text) diff --git a/sc/source/core/data/segmenttree.cxx b/sc/source/core/data/segmenttree.cxx index 563689aed885..d9e60bcc89f8 100644 --- a/sc/source/core/data/segmenttree.cxx +++ b/sc/source/core/data/segmenttree.cxx @@ -373,9 +373,9 @@ void ScFlatBoolRowSegments::removeSegment(SCROW nRow1, SCROW nRow2) mpImpl->removeSegment(static_cast<SCCOLROW>(nRow1), static_cast<SCCOLROW>(nRow2)); } -void ScFlatBoolRowSegments::insertSegment(SCROW nRow, SCROW nSize, bool bSkipStartBoundary) +void ScFlatBoolRowSegments::insertSegment(SCROW nRow, SCROW nSize) { - mpImpl->insertSegment(static_cast<SCCOLROW>(nRow), static_cast<SCCOLROW>(nSize), bSkipStartBoundary); + mpImpl->insertSegment(static_cast<SCCOLROW>(nRow), static_cast<SCCOLROW>(nSize), true/*bSkipStartBoundary*/); } SCROW ScFlatBoolRowSegments::findLastTrue() const @@ -424,9 +424,9 @@ void ScFlatBoolColSegments::removeSegment(SCCOL nCol1, SCCOL nCol2) mpImpl->removeSegment(static_cast<SCCOLROW>(nCol1), static_cast<SCCOLROW>(nCol2)); } -void ScFlatBoolColSegments::insertSegment(SCCOL nCol, SCCOL nSize, bool bSkipStartBoundary) +void ScFlatBoolColSegments::insertSegment(SCCOL nCol, SCCOL nSize) { - mpImpl->insertSegment(static_cast<SCCOLROW>(nCol), static_cast<SCCOLROW>(nSize), bSkipStartBoundary); + mpImpl->insertSegment(static_cast<SCCOLROW>(nCol), static_cast<SCCOLROW>(nSize), true/*bSkipStartBoundary*/); } ScFlatUInt16RowSegments::ForwardIterator::ForwardIterator(ScFlatUInt16RowSegments& rSegs) : @@ -501,9 +501,9 @@ void ScFlatUInt16RowSegments::removeSegment(SCROW nRow1, SCROW nRow2) mpImpl->removeSegment(static_cast<SCCOLROW>(nRow1), static_cast<SCCOLROW>(nRow2)); } -void ScFlatUInt16RowSegments::insertSegment(SCROW nRow, SCROW nSize, bool bSkipStartBoundary) +void ScFlatUInt16RowSegments::insertSegment(SCROW nRow, SCROW nSize) { - mpImpl->insertSegment(static_cast<SCCOLROW>(nRow), static_cast<SCCOLROW>(nSize), bSkipStartBoundary); + mpImpl->insertSegment(static_cast<SCCOLROW>(nRow), static_cast<SCCOLROW>(nSize), false/*bSkipStartBoundary*/); } SCROW ScFlatUInt16RowSegments::findLastTrue(sal_uInt16 nValue) const diff --git a/sc/source/core/data/stlsheet.cxx b/sc/source/core/data/stlsheet.cxx index d60979cbfccd..0c3a7e1381ad 100644 --- a/sc/source/core/data/stlsheet.cxx +++ b/sc/source/core/data/stlsheet.cxx @@ -255,7 +255,7 @@ bool ScStyleSheet::IsUsed() const // Always query the document to let it decide if a rescan is necessary, // and store the state. ScDocument* pDoc = static_cast<ScStyleSheetPool*>(pPool)->GetDocument(); - if ( pDoc && pDoc->IsStyleSheetUsed( *this, true ) ) + if ( pDoc && pDoc->IsStyleSheetUsed( *this ) ) eUsage = USED; else eUsage = NOTUSED; diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx index e5e7aef02d85..4a6536ac29ff 100644 --- a/sc/source/core/data/table2.cxx +++ b/sc/source/core/data/table2.cxx @@ -157,7 +157,7 @@ void ScTable::InsertRow( SCCOL nStartCol, SCCOL nEndCol, SCROW nStartRow, SCSIZE { if (mpRowHeights && pRowFlags) { - mpRowHeights->insertSegment(nStartRow, nSize, false); + mpRowHeights->insertSegment(nStartRow, nSize); sal_uInt8 nNewFlags = pRowFlags->Insert( nStartRow, nSize); // only copy manual size flag, clear all others if (nNewFlags && (nNewFlags != CR_MANUALSIZE)) @@ -168,8 +168,8 @@ void ScTable::InsertRow( SCCOL nStartCol, SCCOL nEndCol, SCROW nStartRow, SCSIZE if (pOutlineTable) pOutlineTable->InsertRow( nStartRow, nSize ); - mpFilteredRows->insertSegment(nStartRow, nSize, true); - mpHiddenRows->insertSegment(nStartRow, nSize, true); + mpFilteredRows->insertSegment(nStartRow, nSize); + mpHiddenRows->insertSegment(nStartRow, nSize); if (!maRowManualBreaks.empty()) { @@ -290,8 +290,8 @@ void ScTable::InsertCol( if (pOutlineTable) pOutlineTable->InsertCol( nStartCol, nSize ); - mpHiddenCols->insertSegment(nStartCol, static_cast<SCCOL>(nSize), true); - mpFilteredCols->insertSegment(nStartCol, static_cast<SCCOL>(nSize), true); + mpHiddenCols->insertSegment(nStartCol, static_cast<SCCOL>(nSize)); + mpFilteredCols->insertSegment(nStartCol, static_cast<SCCOL>(nSize)); if (!maColManualBreaks.empty()) { @@ -3549,7 +3549,7 @@ void ScTable::CopyData( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, SCROW n else { aCell.release(*pDocument, aDest); - pDocument->SetPattern( aDest, *GetPattern( nCol, nRow ), true ); + pDocument->SetPattern( aDest, *GetPattern( nCol, nRow ) ); } ++nDestX; diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 6cdeacefcac6..9c6171ad0cc9 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -749,7 +749,7 @@ void fillSortedColumnArray( assert(rCell.mpAttr); ScAddress aOldPos = rCell.maCell.mpFormula->aPos; - ScFormulaCell* pNew = rCell.maCell.mpFormula->Clone( aCellPos, SC_CLONECELL_DEFAULT); + ScFormulaCell* pNew = rCell.maCell.mpFormula->Clone( aCellPos ); if (pArray->IsUpdateRefs()) { pNew->CopyAllBroadcasters(*rCell.maCell.mpFormula); diff --git a/sc/source/core/data/table7.cxx b/sc/source/core/data/table7.cxx index c6f6f9f91a3f..067cbdcd648b 100644 --- a/sc/source/core/data/table7.cxx +++ b/sc/source/core/data/table7.cxx @@ -243,7 +243,7 @@ void ScTable::finalizeOutlineImport() { if (pOutlineTable && pRowFlags) { - pOutlineTable->GetRowArray().finalizeImport(*this, false); + pOutlineTable->GetRowArray().finalizeImport(*this); } } diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx index 278ae4ececa1..953af5c08fcb 100644 --- a/sc/source/core/data/validat.cxx +++ b/sc/source/core/data/validat.cxx @@ -555,8 +555,8 @@ namespace { class ScStringTokenIterator { public: - inline explicit ScStringTokenIterator( ScTokenArray& rTokArr, bool bSkipEmpty = true ) : - mrTokArr( rTokArr ), mbSkipEmpty( bSkipEmpty ), mbOk( true ) {} + inline explicit ScStringTokenIterator( ScTokenArray& rTokArr ) : + mrTokArr( rTokArr ), mbSkipEmpty( true ), mbOk( true ) {} /** Returns the string of the first string token or NULL on error or empty token array. */ rtl_uString* First(); diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx index b7d9a71fb08c..fb998b827051 100644 --- a/sc/source/core/inc/interpre.hxx +++ b/sc/source/core/inc/interpre.hxx @@ -628,11 +628,9 @@ void ScDebugVar(); If true, the date passed must be a valid Gregorian calendar date. No two-digit expanding or rollover is done. - @param bCheckGregorian - If true, date must be Gregorian, i.e. >= 1582-10-15. - If false, don't care, any valid date >= 0-1-1 will do. + Date must be Gregorian, i.e. >= 1582-10-15. */ -double GetDateSerial( sal_Int16 nYear, sal_Int16 nMonth, sal_Int16 nDay, bool bStrict, bool bCheckGregorian ); +double GetDateSerial( sal_Int16 nYear, sal_Int16 nMonth, sal_Int16 nDay, bool bStrict ); void ScGetActDate(); void ScGetActTime(); diff --git a/sc/source/core/tool/editutil.cxx b/sc/source/core/tool/editutil.cxx index 82dd082da091..d5a50ad0c10b 100644 --- a/sc/source/core/tool/editutil.cxx +++ b/sc/source/core/tool/editutil.cxx @@ -791,8 +791,8 @@ ScHeaderFieldData::ScHeaderFieldData() eNumType = SVX_ARABIC; } -ScHeaderEditEngine::ScHeaderEditEngine( SfxItemPool* pEnginePoolP, bool bDeleteEnginePoolP ) - : ScEditEngineDefaulter( pEnginePoolP, bDeleteEnginePoolP ) +ScHeaderEditEngine::ScHeaderEditEngine( SfxItemPool* pEnginePoolP ) + : ScEditEngineDefaulter( pEnginePoolP,true/*bDeleteEnginePoolP*/ ) { } @@ -883,8 +883,8 @@ void ScFieldEditEngine::FieldClicked( const SvxFieldItem& rField, sal_Int32, sal } ScNoteEditEngine::ScNoteEditEngine( SfxItemPool* pEnginePoolP, - SfxItemPool* pTextObjectPool, bool bDeleteEnginePoolP ) : - ScEditEngineDefaulter( pEnginePoolP, bDeleteEnginePoolP ) + SfxItemPool* pTextObjectPool ) : + ScEditEngineDefaulter( pEnginePoolP, false/*bDeleteEnginePoolP*/ ) { if ( pTextObjectPool ) SetEditTextObjectPool( pTextObjectPool ); diff --git a/sc/source/core/tool/interpr2.cxx b/sc/source/core/tool/interpr2.cxx index 8781b0bf889d..f25c14f3f622 100644 --- a/sc/source/core/tool/interpr2.cxx +++ b/sc/source/core/tool/interpr2.cxx @@ -60,7 +60,7 @@ using namespace formula; // Date and Time double ScInterpreter::GetDateSerial( sal_Int16 nYear, sal_Int16 nMonth, sal_Int16 nDay, - bool bStrict, bool bCheckGregorian ) + bool bStrict ) { if ( nYear < 100 && !bStrict ) nYear = pFormatter->ExpandTwoDigitYear( nYear ); @@ -90,7 +90,7 @@ double ScInterpreter::GetDateSerial( sal_Int16 nYear, sal_Int16 nMonth, sal_Int1 Date aDate( nD, nM, nY); if (!bStrict) aDate += nDay - 1; - if ((!bCheckGregorian && aDate.IsValidDate()) || (bCheckGregorian && aDate.IsValidAndGregorian())) + if (aDate.IsValidAndGregorian()) return (double) (aDate - *(pFormatter->GetNullDate())); else { @@ -303,7 +303,7 @@ void ScInterpreter::ScEasterSunday() O = H + L - 7 * M + 114; nDay = sal::static_int_cast<sal_Int16>( O % 31 + 1 ); nMonth = sal::static_int_cast<sal_Int16>( int(O / 31) ); - PushDouble( GetDateSerial( nYear, nMonth, nDay, true, true ) ); + PushDouble( GetDateSerial( nYear, nMonth, nDay, true ) ); } } @@ -553,7 +553,7 @@ void ScInterpreter::ScGetDate() PushIllegalArgument(); else { - PushDouble(GetDateSerial(nYear, nMonth, nDay, false, true)); + PushDouble(GetDateSerial(nYear, nMonth, nDay, false)); } } } diff --git a/sc/source/core/tool/rechead.cxx b/sc/source/core/tool/rechead.cxx index 4736e5db05ae..dbf3bffda443 100644 --- a/sc/source/core/tool/rechead.cxx +++ b/sc/source/core/tool/rechead.cxx @@ -105,11 +105,11 @@ sal_uLong ScMultipleReadHeader::BytesLeft() const return 0; } -ScMultipleWriteHeader::ScMultipleWriteHeader(SvStream& rNewStream, sal_uInt32 nDefault) : +ScMultipleWriteHeader::ScMultipleWriteHeader(SvStream& rNewStream) : rStream( rNewStream ), aMemStream( 4096, 4096 ) { - nDataSize = nDefault; + nDataSize = 0; rStream.WriteUInt32( nDataSize ); nDataPos = rStream.Tell(); diff --git a/sc/source/filter/excel/read.cxx b/sc/source/filter/excel/read.cxx index 93ed6df0a48d..96b8ebf0d8a9 100644 --- a/sc/source/filter/excel/read.cxx +++ b/sc/source/filter/excel/read.cxx @@ -875,7 +875,7 @@ FltError ImportExcel8::Read() if( maStrm.GetRecId() != EXC_ID_EOF ) XclTools::SkipSubStream( maStrm ); // #i29930# show warning box - GetAddressConverter().CheckScTab( nScTab, true ); + GetAddressConverter().CheckScTab( nScTab ); eAkt = EXC_STATE_END; } else diff --git a/sc/source/filter/excel/xechart.cxx b/sc/source/filter/excel/xechart.cxx index a4978a732232..c6da8e80da67 100644 --- a/sc/source/filter/excel/xechart.cxx +++ b/sc/source/filter/excel/xechart.cxx @@ -1112,11 +1112,11 @@ XclExpChFrLabelProps::XclExpChFrLabelProps( const XclExpChRoot& rRoot ) : { } -void XclExpChFrLabelProps::Convert( const ScfPropertySet& rPropSet, bool bShowSeries, +void XclExpChFrLabelProps::Convert( const ScfPropertySet& rPropSet, bool bShowCateg, bool bShowValue, bool bShowPercent, bool bShowBubble ) { // label value flags - ::set_flag( maData.mnFlags, EXC_CHFRLABELPROPS_SHOWSERIES, bShowSeries ); + ::set_flag( maData.mnFlags, EXC_CHFRLABELPROPS_SHOWSERIES, false ); ::set_flag( maData.mnFlags, EXC_CHFRLABELPROPS_SHOWCATEG, bShowCateg ); ::set_flag( maData.mnFlags, EXC_CHFRLABELPROPS_SHOWVALUE, bShowValue ); ::set_flag( maData.mnFlags, EXC_CHFRLABELPROPS_SHOWPERCENT, bShowPercent ); @@ -1282,7 +1282,7 @@ bool XclExpChText::ConvertDataLabel( const ScfPropertySet& rPropSet, if( bShowAny && (GetBiff() == EXC_BIFF8) ) { mxLabelProps.reset( new XclExpChFrLabelProps( GetChRoot() ) ); - mxLabelProps->Convert( rPropSet, false, bShowCateg, bShowValue, bShowPercent, bShowBubble ); + mxLabelProps->Convert( rPropSet, bShowCateg, bShowValue, bShowPercent, bShowBubble ); } // restrict to combinations allowed in CHTEXT diff --git a/sc/source/filter/excel/xeescher.cxx b/sc/source/filter/excel/xeescher.cxx index a835a43c7b97..44ec01ea653f 100644 --- a/sc/source/filter/excel/xeescher.cxx +++ b/sc/source/filter/excel/xeescher.cxx @@ -324,7 +324,7 @@ void XclExpDffEmbeddedAnchor::ImplSetFlags( const SdrObject& /*rSdrObj*/ ) void XclExpDffEmbeddedAnchor::ImplCalcAnchorRect( const Rectangle& rRect, MapUnit eMapUnit ) { - maAnchor.SetRect( maPageSize, mnScaleX, mnScaleY, rRect, eMapUnit, true ); + maAnchor.SetRect( maPageSize, mnScaleX, mnScaleY, rRect, eMapUnit ); } XclExpDffNoteAnchor::XclExpDffNoteAnchor( const XclExpRoot& rRoot, const Rectangle& rRect ) : diff --git a/sc/source/filter/excel/xename.cxx b/sc/source/filter/excel/xename.cxx index d49055578d64..56da620a4d59 100644 --- a/sc/source/filter/excel/xename.cxx +++ b/sc/source/filter/excel/xename.cxx @@ -156,7 +156,7 @@ private: /** Returns the index of an existing built-in NAME record with the passed definition, otherwise 0. */ sal_uInt16 FindBuiltInNameIdx( const OUString& rName, - const XclTokenArray& rTokArr, bool bDBRange ) const; + const XclTokenArray& rTokArr ) const; /** Returns an unused name for the passed name. */ OUString GetUnusedName( const OUString& rName ) const; @@ -471,12 +471,11 @@ sal_uInt16 XclExpNameManagerImpl::FindNamedExpIndex( SCTAB nTab, sal_uInt16 nScI } sal_uInt16 XclExpNameManagerImpl::FindBuiltInNameIdx( - const OUString& rName, const XclTokenArray& rTokArr, bool bDBRange ) const + const OUString& rName, const XclTokenArray& rTokArr ) const { /* Get built-in index from the name. Special case: the database range 'unnamed' will be mapped to Excel's built-in '_FilterDatabase' name. */ - sal_Unicode cBuiltIn = (bDBRange && (rName == STR_DB_LOCAL_NONAME)) ? - EXC_BUILTIN_FILTERDATABASE : XclTools::GetBuiltInDefNameIndex( rName ); + sal_Unicode cBuiltIn = XclTools::GetBuiltInDefNameIndex( rName ); if( cBuiltIn < EXC_BUILTIN_UNKNOWN ) { @@ -557,7 +556,7 @@ sal_uInt16 XclExpNameManagerImpl::CreateName( SCTAB nTab, const ScRangeData& rRa cannot be done earlier. If a built-in name is found, the created NAME record for this name and all following records in the list must be deleted, otherwise they may contain wrong name list indexes. */ - sal_uInt16 nBuiltInIdx = FindBuiltInNameIdx( rName, *xTokArr, false ); + sal_uInt16 nBuiltInIdx = FindBuiltInNameIdx( rName, *xTokArr ); if( nBuiltInIdx != 0 ) { // delete the new NAME records diff --git a/sc/source/filter/excel/xepivot.cxx b/sc/source/filter/excel/xepivot.cxx index 5b3fe07bf7b4..b72cd6e9941d 100644 --- a/sc/source/filter/excel/xepivot.cxx +++ b/sc/source/filter/excel/xepivot.cxx @@ -903,13 +903,13 @@ XclExpPTItem::XclExpPTItem( const XclExpPCField& rCacheField, sal_uInt16 nCacheI maItemInfo.maVisName.mbUseCache = mpCacheItem != nullptr; } -XclExpPTItem::XclExpPTItem( sal_uInt16 nItemType, sal_uInt16 nCacheIdx, bool bUseCache ) : +XclExpPTItem::XclExpPTItem( sal_uInt16 nItemType, sal_uInt16 nCacheIdx ) : XclExpRecord( EXC_ID_SXVI, 8 ), mpCacheItem( nullptr ) { maItemInfo.mnType = nItemType; maItemInfo.mnCacheIdx = nCacheIdx; - maItemInfo.maVisName.mbUseCache = bUseCache; + maItemInfo.maVisName.mbUseCache = true; } OUString XclExpPTItem::GetItemName() const @@ -1156,7 +1156,7 @@ XclExpPTItem* XclExpPTField::GetItemAcc( const OUString& rName ) void XclExpPTField::AppendSubtotalItem( sal_uInt16 nItemType ) { - maItemList.AppendNewRecord( new XclExpPTItem( nItemType, EXC_SXVI_DEFAULT_CACHE, true ) ); + maItemList.AppendNewRecord( new XclExpPTItem( nItemType, EXC_SXVI_DEFAULT_CACHE ) ); ++maFieldInfo.mnItemCount; } diff --git a/sc/source/filter/excel/xeroot.cxx b/sc/source/filter/excel/xeroot.cxx index d3762369d530..05d6fefa93b0 100644 --- a/sc/source/filter/excel/xeroot.cxx +++ b/sc/source/filter/excel/xeroot.cxx @@ -242,7 +242,7 @@ void XclExpRoot::InitializeGlobals() uno::Reference< lang::XMultiServiceFactory > xModelFactory( xComponent, uno::UNO_QUERY); // OOXML is also BIFF8 function-wise oox::xls::OpCodeProvider aOpCodeProvider( xModelFactory, - oox::xls::FILTER_OOXML, oox::xls::BIFF8, false, true); + oox::xls::FILTER_OOXML, oox::xls::BIFF8, false); // Compiler mocks about non-matching ctor or conversion from // Sequence<...> to Sequence<const ...> if directly created or passed, // conversion through Any works around. diff --git a/sc/source/filter/excel/xestyle.cxx b/sc/source/filter/excel/xestyle.cxx index e9197e224433..b0cc8dedb9b4 100644 --- a/sc/source/filter/excel/xestyle.cxx +++ b/sc/source/filter/excel/xestyle.cxx @@ -284,11 +284,11 @@ private: sal_uInt32 GetNearestListColor( sal_uInt32 nIndex ) const; /** Returns in rnIndex the palette index of the color nearest to rColor. - @param bDefaultOnly true = Searches for default colors only (colors never replaced). + Searches for default colors only (colors never replaced). @return The distance from passed color to found color. */ sal_Int32 GetNearestPaletteColor( sal_uInt32& rnIndex, - const Color& rColor, bool bDefaultOnly ) const; + const Color& rColor ) const; /** Returns in rnFirst and rnSecond the palette indexes of the two colors nearest to rColor. @return The minimum distance from passed color to found colors. */ sal_Int32 GetNearPaletteColors( @@ -380,7 +380,7 @@ void XclExpPaletteImpl::Finalize() // find nearest unused default color for each unprocessed list color for( nIndex = 0; nIndex < nCount; ++nIndex ) aNearestVec[ nIndex ].mnDist = aRemapVec[ nIndex ].mbProcessed ? SAL_MAX_INT32 : - GetNearestPaletteColor( aNearestVec[ nIndex ].mnPalIndex, mxColorList->at( nIndex )->GetColor(), true ); + GetNearestPaletteColor( aNearestVec[ nIndex ].mnPalIndex, mxColorList->at( nIndex )->GetColor() ); // find the list color which is nearest to a default color sal_uInt32 nFound = 0; for( nIndex = 1; nIndex < nCount; ++nIndex ) @@ -704,7 +704,7 @@ sal_uInt32 XclExpPaletteImpl::GetNearestListColor( sal_uInt32 nIndex ) const } sal_Int32 XclExpPaletteImpl::GetNearestPaletteColor( - sal_uInt32& rnIndex, const Color& rColor, bool bDefaultOnly ) const + sal_uInt32& rnIndex, const Color& rColor ) const { rnIndex = 0; sal_Int32 nDist = SAL_MAX_INT32; @@ -712,7 +712,7 @@ sal_Int32 XclExpPaletteImpl::GetNearestPaletteColor( for( XclPaletteColorVec::const_iterator aIt = maPalette.begin(), aEnd = maPalette.end(); aIt != aEnd; ++aIt ) { - if( !bDefaultOnly || !aIt->mbUsed ) + if( !aIt->mbUsed ) { sal_Int32 nCurrDist = lclGetColorDistance( rColor, aIt->maColor ); if( nCurrDist < nDist ) diff --git a/sc/source/filter/excel/xichart.cxx b/sc/source/filter/excel/xichart.cxx index cf1738c504bf..18d7afbaf5e1 100644 --- a/sc/source/filter/excel/xichart.cxx +++ b/sc/source/filter/excel/xichart.cxx @@ -1551,9 +1551,9 @@ void XclImpChDataFormat::ConvertLine( ScfPropertySet& rPropSet, XclChObjectType ConvertLineBase( GetChRoot(), rPropSet, eObjType ); } -void XclImpChDataFormat::ConvertArea( ScfPropertySet& rPropSet, sal_uInt16 nFormatIdx, bool bUsePicFmt ) const +void XclImpChDataFormat::ConvertArea( ScfPropertySet& rPropSet, sal_uInt16 nFormatIdx ) const { - ConvertAreaBase( GetChRoot(), rPropSet, EXC_CHOBJTYPE_FILLEDSERIES, nFormatIdx, bUsePicFmt ); + ConvertAreaBase( GetChRoot(), rPropSet, EXC_CHOBJTYPE_FILLEDSERIES, nFormatIdx ); } void XclImpChDataFormat::RemoveUnusedFormats( const XclChExtTypeInfo& rTypeInfo ) @@ -2070,7 +2070,7 @@ Reference< XDataSeries > XclImpChSeries::CreateDataSeries() const for( sal_uInt16 nPointIdx = 0, nPointCount = mxValueLink->GetCellCount(); nPointIdx < nPointCount; ++nPointIdx ) { ScfPropertySet aPointProp = lclGetPointPropSet( xDataSeries, nPointIdx ); - mxSeriesFmt->ConvertArea( aPointProp, bVarPointFmt ? nPointIdx : mnSeriesIdx, false ); + mxSeriesFmt->ConvertArea( aPointProp, bVarPointFmt ? nPointIdx : mnSeriesIdx ); } } diff --git a/sc/source/filter/excel/xistream.cxx b/sc/source/filter/excel/xistream.cxx index 1c9ab9cdbcf5..7873eef9c3f4 100644 --- a/sc/source/filter/excel/xistream.cxx +++ b/sc/source/filter/excel/xistream.cxx @@ -394,7 +394,7 @@ XclBiff XclImpStream::DetectBiffVersion( SvStream& rStrm ) return eBiff; } -XclImpStream::XclImpStream( SvStream& rInStrm, const XclImpRoot& rRoot, bool bContLookup ) : +XclImpStream::XclImpStream( SvStream& rInStrm, const XclImpRoot& rRoot ) : mrStrm( rInStrm ), mrRoot( rRoot ), mnGlobRecId( EXC_ID_UNKNOWN ), @@ -410,7 +410,7 @@ XclImpStream::XclImpStream( SvStream& rInStrm, const XclImpRoot& rRoot, bool bCo mnRawRecSize( 0 ), mnRawRecLeft( 0 ), mcNulSubst( '?' ), - mbCont( bContLookup ), + mbCont( true ), mbUseDecr( false ), mbValidRec( false ), mbValid( false ) diff --git a/sc/source/filter/excel/xladdress.cxx b/sc/source/filter/excel/xladdress.cxx index 145a08139ab8..df10c67230df 100644 --- a/sc/source/filter/excel/xladdress.cxx +++ b/sc/source/filter/excel/xladdress.cxx @@ -136,10 +136,10 @@ XclAddressConverterBase::~XclAddressConverterBase() { } -void XclAddressConverterBase::CheckScTab( SCTAB nScTab, bool bWarn ) +void XclAddressConverterBase::CheckScTab( SCTAB nScTab ) { bool bValid = (0 <= nScTab) && (nScTab <= maMaxPos.Tab()); - if( !bValid && bWarn ) + if( !bValid ) { mbTabTrunc |= (nScTab > maMaxPos.Tab()); // do not warn for deleted refs mrTracer.TraceInvalidTab( nScTab, maMaxPos.Tab() ); diff --git a/sc/source/filter/excel/xlescher.cxx b/sc/source/filter/excel/xlescher.cxx index 1f2227176e22..e13ff854c598 100644 --- a/sc/source/filter/excel/xlescher.cxx +++ b/sc/source/filter/excel/xlescher.cxx @@ -178,7 +178,7 @@ void XclObjAnchor::SetRect( const XclRoot& rRoot, SCTAB nScTab, const Rectangle& } void XclObjAnchor::SetRect( const Size& rPageSize, sal_Int32 nScaleX, sal_Int32 nScaleY, - const Rectangle& rRect, MapUnit eMapUnit, bool bDffAnchor ) + const Rectangle& rRect, MapUnit eMapUnit ) { double fScale = 1.0; switch( eMapUnit ) @@ -191,16 +191,13 @@ void XclObjAnchor::SetRect( const Size& rPageSize, sal_Int32 nScaleX, sal_Int32 /* In objects with DFF client anchor, the position of the shape is stored in the cell address components of the client anchor. In old BIFF3-BIFF5 objects, the position is stored in the offset components of the anchor. */ - (bDffAnchor ? maFirst.mnCol : mnLX) = lclGetEmbeddedScale( rPageSize.Width(), nScaleX, rRect.Left(), fScale ); - (bDffAnchor ? maFirst.mnRow : mnTY) = lclGetEmbeddedScale( rPageSize.Height(), nScaleY, rRect.Top(), fScale ); - (bDffAnchor ? maLast.mnCol : mnRX) = lclGetEmbeddedScale( rPageSize.Width(), nScaleX, rRect.Right(), fScale ); - (bDffAnchor ? maLast.mnRow : mnBY) = lclGetEmbeddedScale( rPageSize.Height(), nScaleY, rRect.Bottom(), fScale ); + maFirst.mnCol = lclGetEmbeddedScale( rPageSize.Width(), nScaleX, rRect.Left(), fScale ); + maFirst.mnRow = lclGetEmbeddedScale( rPageSize.Height(), nScaleY, rRect.Top(), fScale ); + maLast.mnCol = lclGetEmbeddedScale( rPageSize.Width(), nScaleX, rRect.Right(), fScale ); + maLast.mnRow = lclGetEmbeddedScale( rPageSize.Height(), nScaleY, rRect.Bottom(), fScale ); // for safety, clear the other members - if( bDffAnchor ) - mnLX = mnTY = mnRX = mnBY = 0; - else - Set( 0, 0, 0, 0 ); + mnLX = mnTY = mnRX = mnBY = 0; } XclObjLineData::XclObjLineData() : diff --git a/sc/source/filter/excel/xlroot.cxx b/sc/source/filter/excel/xlroot.cxx index 986050ee8624..4e9835de2ec4 100644 --- a/sc/source/filter/excel/xlroot.cxx +++ b/sc/source/filter/excel/xlroot.cxx @@ -360,7 +360,7 @@ ScHeaderEditEngine& XclRoot::GetHFEditEngine() const { if( !mrData.mxHFEditEngine.get() ) { - mrData.mxHFEditEngine.reset( new ScHeaderEditEngine( EditEngine::CreatePool(), true ) ); + mrData.mxHFEditEngine.reset( new ScHeaderEditEngine( EditEngine::CreatePool() ) ); ScHeaderEditEngine& rEE = *mrData.mxHFEditEngine; rEE.SetRefMapMode( MAP_TWIP ); // headers/footers use twips as default metric rEE.SetUpdateMode( false ); diff --git a/sc/source/filter/html/htmlimp.cxx b/sc/source/filter/html/htmlimp.cxx index 2be6faa5942a..3baae4fe6486 100644 --- a/sc/source/filter/html/htmlimp.cxx +++ b/sc/source/filter/html/htmlimp.cxx @@ -54,9 +54,9 @@ FltError ScFormatFilterPluginImpl::ScImportHTML( SvStream &rStream, const OUStri return nErr; } -ScEEAbsImport *ScFormatFilterPluginImpl::CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange, bool bCalcWidthHeight ) +ScEEAbsImport *ScFormatFilterPluginImpl::CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange ) { - return new ScHTMLImport( pDocP, rBaseURL, rRange, bCalcWidthHeight ); + return new ScHTMLImport( pDocP, rBaseURL, rRange, true/*bCalcWidthHeight*/ ); } ScHTMLImport::ScHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange, bool bCalcWidthHeight ) : diff --git a/sc/source/filter/inc/formulabase.hxx b/sc/source/filter/inc/formulabase.hxx index 1eee9bc9b845..daaecebe67fa 100644 --- a/sc/source/filter/inc/formulabase.hxx +++ b/sc/source/filter/inc/formulabase.hxx @@ -596,8 +596,7 @@ class OpCodeProvider : public FunctionProvider // not derived from WorkbookHelpe public: explicit OpCodeProvider( const css::uno::Reference< css::lang::XMultiServiceFactory >& rxModelFactory, - FilterType eFilter, BiffType eBiff, bool bImportFilter, - bool bCallerKnowsAboutMacroExport = false ); + FilterType eFilter, BiffType eBiff, bool bImportFilter ); virtual ~OpCodeProvider(); /** Returns the structure containing all token op-codes for operators and diff --git a/sc/source/filter/inc/ftools.hxx b/sc/source/filter/inc/ftools.hxx index bb6b1c1106ae..6a36b3d51929 100644 --- a/sc/source/filter/inc/ftools.hxx +++ b/sc/source/filter/inc/ftools.hxx @@ -283,7 +283,7 @@ public: SvNumberFormatter* pFormatter = nullptr, bool bConvertDate = true ) override; virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) override; - virtual ScEEAbsImport *CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange, bool bCalcWidthHeight ) override; + virtual ScEEAbsImport *CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange ) override; virtual OUString GetHTMLRangeNameList( ScDocument* pDoc, const OUString& rOrigName ) override; // various export filters diff --git a/sc/source/filter/inc/xechart.hxx b/sc/source/filter/inc/xechart.hxx index 11423c0307de..509ff0f808cb 100644 --- a/sc/source/filter/inc/xechart.hxx +++ b/sc/source/filter/inc/xechart.hxx @@ -449,7 +449,7 @@ public: /** Converts separator and the passed data label flags. */ void Convert( - const ScfPropertySet& rPropSet, bool bShowSeries, + const ScfPropertySet& rPropSet, bool bShowCateg, bool bShowValue, bool bShowPercent, bool bShowBubble ); diff --git a/sc/source/filter/inc/xepivot.hxx b/sc/source/filter/inc/xepivot.hxx index 1683f3f7ee15..f959991f4490 100644 --- a/sc/source/filter/inc/xepivot.hxx +++ b/sc/source/filter/inc/xepivot.hxx @@ -237,7 +237,7 @@ class XclExpPTItem : public XclExpRecord { public: explicit XclExpPTItem( const XclExpPCField& rCacheField, sal_uInt16 nCacheIdx ); - explicit XclExpPTItem( sal_uInt16 nItemType, sal_uInt16 nCacheIdx, bool bUseCache ); + explicit XclExpPTItem( sal_uInt16 nItemType, sal_uInt16 nCacheIdx ); /** Returns the internal name of this item. */ OUString GetItemName() const; diff --git a/sc/source/filter/inc/xichart.hxx b/sc/source/filter/inc/xichart.hxx index 9b0dd1933618..233a8d8f1185 100644 --- a/sc/source/filter/inc/xichart.hxx +++ b/sc/source/filter/inc/xichart.hxx @@ -669,7 +669,7 @@ public: /** Writes the line format only, e.g. for trend lines or error bars. */ void ConvertLine( ScfPropertySet& rPropSet, XclChObjectType eObjType ) const; /** Writes the area format only for the series or a data point. */ - void ConvertArea( ScfPropertySet& rPropSet, sal_uInt16 nFormatIdx, bool bUsePicFmt ) const; + void ConvertArea( ScfPropertySet& rPropSet, sal_uInt16 nFormatIdx ) const; private: /** Removes unused formatting (e.g. pie distance in a bar chart). */ diff --git a/sc/source/filter/inc/xistream.hxx b/sc/source/filter/inc/xistream.hxx index e498b745efa8..4fa50b0a9fde 100644 --- a/sc/source/filter/inc/xistream.hxx +++ b/sc/source/filter/inc/xistream.hxx @@ -240,12 +240,10 @@ public: /** Constructs the Excel record import stream using a TOOLS stream object. @param rInStrm The system input stream. Will be set to its start position. - Must exist as long as this object exists. - @param bContLookup Automatic CONTINUE lookup on/off. */ + Must exist as long as this object exists */ explicit XclImpStream( SvStream& rInStrm, - const XclImpRoot& rRoot, - bool bContLookup = true ); + const XclImpRoot& rRoot ); ~XclImpStream(); diff --git a/sc/source/filter/inc/xladdress.hxx b/sc/source/filter/inc/xladdress.hxx index 7021cbd60b4c..b0c65a375fc1 100644 --- a/sc/source/filter/inc/xladdress.hxx +++ b/sc/source/filter/inc/xladdress.hxx @@ -146,10 +146,10 @@ public: /** Checks if the passed sheet index is valid. @param nScTab The sheet index to check. - @param bWarn true = Sets the internal flag that produces a warning box + Sets the internal flag that produces a warning box after loading/saving the file, if the sheet index is not valid. */ - void CheckScTab( SCTAB nScTab, bool bWarn ); + void CheckScTab( SCTAB nScTab ); protected: XclTracer& mrTracer; /// Tracer for invalid addresses. diff --git a/sc/source/filter/inc/xlescher.hxx b/sc/source/filter/inc/xlescher.hxx index 07f7aa34f893..dd007ce66e8a 100644 --- a/sc/source/filter/inc/xlescher.hxx +++ b/sc/source/filter/inc/xlescher.hxx @@ -300,7 +300,7 @@ struct XclObjAnchor : public XclRange /** Initializes the anchor coordinates for an embedded draw page. */ void SetRect( const Size& rPageSize, sal_Int32 nScaleX, sal_Int32 nScaleY, - const Rectangle& rRect, MapUnit eMapUnit, bool bDffAnchor ); + const Rectangle& rRect, MapUnit eMapUnit ); }; inline SvStream& operator>>( SvStream& rStrm, XclObjAnchor& rAnchor ) diff --git a/sc/source/filter/oox/formulabase.cxx b/sc/source/filter/oox/formulabase.cxx index 2e1a4a9d5472..72470fc4c3c7 100644 --- a/sc/source/filter/oox/formulabase.cxx +++ b/sc/source/filter/oox/formulabase.cxx @@ -1471,8 +1471,8 @@ bool OpCodeProviderImpl::initFuncOpCodes( const ApiTokenMap& rIntFuncTokenMap, c } OpCodeProvider::OpCodeProvider( const Reference< XMultiServiceFactory >& rxModelFactory, - FilterType eFilter, BiffType eBiff, bool bImportFilter, bool bCallerKnowsAboutMacroExport ) : - FunctionProvider( eFilter, eBiff, bImportFilter, bCallerKnowsAboutMacroExport ), + FilterType eFilter, BiffType eBiff, bool bImportFilter ) : + FunctionProvider( eFilter, eBiff, bImportFilter, true/*bCallerKnowsAboutMacroExport*/ ), mxOpCodeImpl( new OpCodeProviderImpl( getFuncs(), rxModelFactory ) ) { } diff --git a/sc/source/filter/rtf/eeimpars.cxx b/sc/source/filter/rtf/eeimpars.cxx index e31c215b230e..8200745fb721 100644 --- a/sc/source/filter/rtf/eeimpars.cxx +++ b/sc/source/filter/rtf/eeimpars.cxx @@ -309,7 +309,7 @@ void ScEEImport::WriteToDocument( bool bSizeColsRows, double nOutputFactor, SvNu const ScStyleSheet* pStyleSheet = mpDoc->GetPattern( nCol, nRow, nTab )->GetStyleSheet(); aAttr.SetStyleSheet( const_cast<ScStyleSheet*>(pStyleSheet) ); - mpDoc->SetPattern( nCol, nRow, nTab, aAttr, true ); + mpDoc->SetPattern( nCol, nRow, nTab, aAttr ); // Add data if (bSimple) diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 350f3b6ecc97..e4e45c7e79a7 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -2569,7 +2569,7 @@ void ScXMLExport::_ExportAutoStyles() pRowStyles->AddFieldStyleName(nTable, nRow, nIndex); } sal_Int32 nOld(nRow); - nRow = pDoc->GetNextDifferentChangedRow(sal::static_int_cast<SCTAB>(nTable), static_cast<SCROW>(nRow), false); + nRow = pDoc->GetNextDifferentChangedRow(sal::static_int_cast<SCTAB>(nTable), static_cast<SCROW>(nRow)); if (nRow > nOld + 1) pRowStyles->AddFieldStyleName(nTable, nOld + 1, nIndex, nRow - 1); } diff --git a/sc/source/filter/xml/xmlstyli.cxx b/sc/source/filter/xml/xmlstyli.cxx index 55916f10e75a..7e39f25751aa 100644 --- a/sc/source/filter/xml/xmlstyli.cxx +++ b/sc/source/filter/xml/xmlstyli.cxx @@ -1050,8 +1050,8 @@ void ScMasterPageContext::Finish( bool bOverwrite ) ScCellTextStyleContext::ScCellTextStyleContext( SvXMLImport& rImport, sal_uInt16 nPrfx, const OUString& rLName, const uno::Reference<xml::sax::XAttributeList> & xAttrList, - SvXMLStylesContext& rStyles, sal_uInt16 nFamily, bool bDefaultStyle ) : - XMLTextStyleContext( rImport, nPrfx, rLName, xAttrList, rStyles, nFamily, bDefaultStyle ), + SvXMLStylesContext& rStyles, sal_uInt16 nFamily ) : + XMLTextStyleContext( rImport, nPrfx, rLName, xAttrList, rStyles, nFamily, false/*bDefaultStyle*/ ), nLastSheet(-1) { } diff --git a/sc/source/filter/xml/xmlstyli.hxx b/sc/source/filter/xml/xmlstyli.hxx index b76a5f5a379a..023dc0d20766 100644 --- a/sc/source/filter/xml/xmlstyli.hxx +++ b/sc/source/filter/xml/xmlstyli.hxx @@ -247,8 +247,7 @@ public: ScCellTextStyleContext( SvXMLImport& rImport, sal_uInt16 nPrfx, const OUString& rLName, const css::uno::Reference< css::xml::sax::XAttributeList > & xAttrList, - SvXMLStylesContext& rStyles, sal_uInt16 nFamily, - bool bDefaultStyle = false ); + SvXMLStylesContext& rStyles, sal_uInt16 nFamily ); virtual ~ScCellTextStyleContext(); // override FillPropertySet to store style information diff --git a/sc/source/ui/Accessibility/AccessibleText.cxx b/sc/source/ui/Accessibility/AccessibleText.cxx index 5ff874ef21bf..0ff33178fa42 100644 --- a/sc/source/ui/Accessibility/AccessibleText.cxx +++ b/sc/source/ui/Accessibility/AccessibleText.cxx @@ -1436,7 +1436,7 @@ SvxTextForwarder* ScAccessibleHeaderTextData::GetTextForwarder() { SfxItemPool* pEnginePool = EditEngine::CreatePool(); pEnginePool->FreezeIdRanges(); - ScHeaderEditEngine* pHdrEngine = new ScHeaderEditEngine( pEnginePool, true ); + ScHeaderEditEngine* pHdrEngine = new ScHeaderEditEngine( pEnginePool ); pHdrEngine->EnableUndo( false ); pHdrEngine->SetRefMapMode( MAP_TWIP ); diff --git a/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx b/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx index 96c004061ee9..d6b7d361988a 100644 --- a/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx +++ b/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx @@ -90,11 +90,11 @@ void FormulaTemplate::applyNumber(const OUString& aVariable, sal_Int32 aValue) mTemplate = mTemplate.replaceAll(aVariable, OUString::number(aValue)); } -AddressWalker::AddressWalker(ScAddress aInitialAddress, bool aTrackRange) : +AddressWalker::AddressWalker(ScAddress aInitialAddress) : mCurrentAddress(aInitialAddress), mMinimumAddress(aInitialAddress), mMaximumAddress(aInitialAddress), - mTrackRange(aTrackRange) + mTrackRange(true) { mAddressStack.push_back(mCurrentAddress); } @@ -157,7 +157,7 @@ void AddressWalker::push(SCCOL aRelativeCol, SCROW aRelativeRow, SCTAB aRelative AddressWalkerWriter::AddressWalkerWriter(ScAddress aInitialAddress, ScDocShell* pDocShell, ScDocument* pDocument, formula::FormulaGrammar::Grammar eGrammar ) : - AddressWalker(aInitialAddress, true), + AddressWalker(aInitialAddress), mpDocShell(pDocShell), mpDocument(pDocument), meGrammar(eGrammar) diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 5e0814b4b901..b8db1ee885b6 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -2891,7 +2891,7 @@ void ScInputHandler::EnterHandler( ScEnterMode nBlockMode ) if ( bOldMod && pExecuteSh && pCellAttrs && !bForget ) { // Combine with input? - pExecuteSh->ApplySelectionPattern( *pCellAttrs, true, true ); + pExecuteSh->ApplySelectionPattern( *pCellAttrs, true ); pExecuteSh->AdjustBlockHeight(); } @@ -3424,7 +3424,7 @@ bool ScInputHandler::KeyInput( const KeyEvent& rKEvt, bool bStartEdit /* = false return bUsed; } -void ScInputHandler::InputCommand( const CommandEvent& rCEvt, bool bForce ) +void ScInputHandler::InputCommand( const CommandEvent& rCEvt ) { if ( rCEvt.GetCommand() == CommandEventId::CursorPos ) { @@ -3458,77 +3458,74 @@ void ScInputHandler::InputCommand( const CommandEvent& rCEvt, bool bForce ) } else { - if ( bForce || eMode != SC_INPUT_NONE ) + if (!bOptLoaded) { - if (!bOptLoaded) - { - bAutoComplete = SC_MOD()->GetAppOptions().GetAutoComplete(); - bOptLoaded = true; - } + bAutoComplete = SC_MOD()->GetAppOptions().GetAutoComplete(); + bOptLoaded = true; + } - HideTip(); - HideTipBelow(); + HideTip(); + HideTipBelow(); - if ( bSelIsRef ) - { - RemoveSelection(); - bSelIsRef = false; - } + if ( bSelIsRef ) + { + RemoveSelection(); + bSelIsRef = false; + } - UpdateActiveView(); - bool bNewView = DataChanging( 0, true ); + UpdateActiveView(); + bool bNewView = DataChanging( 0, true ); - if (!bProtected) // changes allowed + if (!bProtected) // changes allowed + { + if (bNewView) // create new edit view { - if (bNewView) // create new edit view - { - if (pActiveViewSh) - pActiveViewSh->GetViewData().GetDocShell()->PostEditView( pEngine, aCursorPos ); - UpdateActiveView(); - if (eMode==SC_INPUT_NONE) - if (pTableView || pTopView) + if (pActiveViewSh) + pActiveViewSh->GetViewData().GetDocShell()->PostEditView( pEngine, aCursorPos ); + UpdateActiveView(); + if (eMode==SC_INPUT_NONE) + if (pTableView || pTopView) + { + OUString aStrLoP; + if (pTableView) { - OUString aStrLoP; - if (pTableView) - { - pTableView->GetEditEngine()->SetText( aStrLoP ); - pTableView->SetSelection( ESelection(0,0, 0,0) ); - } - if (pTopView) - { - pTopView->GetEditEngine()->SetText( aStrLoP ); - pTopView->SetSelection( ESelection(0,0, 0,0) ); - } + pTableView->GetEditEngine()->SetText( aStrLoP ); + pTableView->SetSelection( ESelection(0,0, 0,0) ); } - SyncViews(); - } + if (pTopView) + { + pTopView->GetEditEngine()->SetText( aStrLoP ); + pTopView->SetSelection( ESelection(0,0, 0,0) ); + } + } + SyncViews(); + } - if (pTableView || pTopView) - { - if (pTableView) - pTableView->Command( rCEvt ); - if (pTopView) - pTopView->Command( rCEvt ); + if (pTableView || pTopView) + { + if (pTableView) + pTableView->Command( rCEvt ); + if (pTopView) + pTopView->Command( rCEvt ); - if ( rCEvt.GetCommand() == CommandEventId::EndExtTextInput ) - { - // AutoInput after ext text input + if ( rCEvt.GetCommand() == CommandEventId::EndExtTextInput ) + { + // AutoInput after ext text input - if (pFormulaData) - miAutoPosFormula = pFormulaData->end(); - if (pColumnData) - miAutoPosColumn = pColumnData->end(); + if (pFormulaData) + miAutoPosFormula = pFormulaData->end(); + if (pColumnData) + miAutoPosColumn = pColumnData->end(); - if (bFormulaMode) - UseFormulaData(); - else - UseColData(); - } + if (bFormulaMode) + UseFormulaData(); + else + UseColData(); } - - DataChanged(); // calls UpdateParenthesis() - InvalidateAttribs(); //! in DataChanged ? } + + DataChanged(); // calls UpdateParenthesis() + InvalidateAttribs(); //! in DataChanged ? } if (pTopView && eMode != SC_INPUT_NONE) diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx b/sc/source/ui/attrdlg/scdlgfact.cxx index a77889463cff..9f6b7958a026 100644 --- a/sc/source/ui/attrdlg/scdlgfact.cxx +++ b/sc/source/ui/attrdlg/scdlgfact.cxx @@ -714,10 +714,9 @@ AbstractScFillSeriesDlg* ScAbstractDialogFactory_Impl::CreateScFillSeriesDlg( vc } AbstractScGroupDlg* ScAbstractDialogFactory_Impl::CreateAbstractScGroupDlg( vcl::Window* pParent, - bool bUnGroup, - bool bRows ) + bool bUnGroup ) { - VclPtr<ScGroupDlg> pDlg = VclPtr<ScGroupDlg>::Create( pParent, bUnGroup, bRows); + VclPtr<ScGroupDlg> pDlg = VclPtr<ScGroupDlg>::Create( pParent, bUnGroup, true/*bRows*/); return new AbstractScGroupDlg_Impl( pDlg ); } @@ -741,10 +740,9 @@ AbstractScInsertCellDlg * ScAbstractDialogFactory_Impl::CreateScInsertCellDlg( v } AbstractScInsertContentsDlg * ScAbstractDialogFactory_Impl::CreateScInsertContentsDlg( vcl::Window* pParent, - InsertDeleteFlags nCheckDefaults, const OUString* pStrTitle ) { - VclPtr<ScInsertContentsDlg> pDlg = VclPtr<ScInsertContentsDlg>::Create(pParent, nCheckDefaults, pStrTitle); + VclPtr<ScInsertContentsDlg> pDlg = VclPtr<ScInsertContentsDlg>::Create(pParent, InsertDeleteFlags::NONE, pStrTitle); return new AbstractScInsertContentsDlg_Impl( pDlg ); } @@ -823,10 +821,9 @@ AbstractScDPSubtotalDlg * ScAbstractDialogFactory_Impl::CreateScDPSubtotalDlg ( ScDPObject& rDPObj, const ScDPLabelData& rLabelData, const ScPivotFuncData& rFuncData, - const ScDPNameVec& rDataFields, - bool bEnableLayout ) + const ScDPNameVec& rDataFields ) { - VclPtr<ScDPSubtotalDlg> pDlg = VclPtr<ScDPSubtotalDlg>::Create( pParent, rDPObj, rLabelData, rFuncData, rDataFields, bEnableLayout ); + VclPtr<ScDPSubtotalDlg> pDlg = VclPtr<ScDPSubtotalDlg>::Create( pParent, rDPObj, rLabelData, rFuncData, rDataFields, true/*bEnableLayout*/ ); return new AbstractScDPSubtotalDlg_Impl( pDlg ); } diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx b/sc/source/ui/attrdlg/scdlgfact.hxx index 9c459527f20f..7a84d7366b0b 100644 --- a/sc/source/ui/attrdlg/scdlgfact.hxx +++ b/sc/source/ui/attrdlg/scdlgfact.hxx @@ -437,15 +437,13 @@ public: double fMax, sal_uInt16 nPossDir) override; virtual AbstractScGroupDlg * CreateAbstractScGroupDlg( vcl::Window* pParent, - bool bUnGroup = false, - bool bRows = true) override; + bool bUnGroup = false) override; virtual AbstractScInsertCellDlg * CreateScInsertCellDlg( vcl::Window* pParent, int nId, bool bDisallowCellMove = false ) override; virtual AbstractScInsertContentsDlg * CreateScInsertContentsDlg( vcl::Window* pParent, - InsertDeleteFlags nCheckDefaults = InsertDeleteFlags::NONE, const OUString* pStrTitle = nullptr ) override; virtual AbstractScInsertTableDlg * CreateScInsertTableDlg(vcl::Window* pParent, ScViewData& rViewData, @@ -487,8 +485,7 @@ public: ScDPObject& rDPObj, const ScDPLabelData& rLabelData, const ScPivotFuncData& rFuncData, - const ScDPNameVec& rDataFields, - bool bEnableLayout ) override; + const ScDPNameVec& rDataFields ) override; virtual AbstractScDPNumGroupDlg * CreateScDPNumGroupDlg( vcl::Window* pParent, int nId, diff --git a/sc/source/ui/cctrl/cbuttonw.cxx b/sc/source/ui/cctrl/cbuttonw.cxx index 436aa4ecd426..ad22426020e5 100644 --- a/sc/source/ui/cctrl/cbuttonw.cxx +++ b/sc/source/ui/cctrl/cbuttonw.cxx @@ -49,8 +49,7 @@ void ScDDComboBoxButton::SetOptSizePixel() } void ScDDComboBoxButton::Draw( const Point& rAt, - const Size& rSize, - bool bState ) + const Size& rSize ) { if ( rSize.Width() == 0 || rSize.Height() == 0 ) return; @@ -82,7 +81,7 @@ void ScDDComboBoxButton::Draw( const Point& rAt, aInnerRect.Top() = aInnerCenter.Y() - (aInnerSize.Width()>>1); aInnerRect.Bottom()= aInnerCenter.Y() + (aInnerSize.Width()>>1); - ImpDrawArrow( aInnerRect, bState ); + ImpDrawArrow( aInnerRect, false/*bState*/ ); // restore old state pOut->EnableMapMode( bOldEnable ); diff --git a/sc/source/ui/cctrl/checklistmenu.cxx b/sc/source/ui/cctrl/checklistmenu.cxx index 88d466932696..be5f3563dfd3 100644 --- a/sc/source/ui/cctrl/checklistmenu.cxx +++ b/sc/source/ui/cctrl/checklistmenu.cxx @@ -294,11 +294,11 @@ Reference<XAccessible> ScMenuFloatingWindow::CreateAccessible() return mxAccessible; } -void ScMenuFloatingWindow::addMenuItem(const OUString& rText, bool bEnabled, Action* pAction) +void ScMenuFloatingWindow::addMenuItem(const OUString& rText, Action* pAction) { MenuItemData aItem; aItem.maText = rText; - aItem.mbEnabled = bEnabled; + aItem.mbEnabled = true; aItem.mpAction.reset(pAction); maMenuItems.push_back(aItem); } diff --git a/sc/source/ui/cctrl/editfield.cxx b/sc/source/ui/cctrl/editfield.cxx index 13419e8a91b4..ea8f112a83d6 100644 --- a/sc/source/ui/cctrl/editfield.cxx +++ b/sc/source/ui/cctrl/editfield.cxx @@ -66,10 +66,10 @@ bool ScDoubleField::GetValue( double& rfValue ) const return bOk; } -void ScDoubleField::SetValue( double fValue, sal_Int32 nDecPlaces, bool bEraseTrailingDecZeros ) +void ScDoubleField::SetValue( double fValue, sal_Int32 nDecPlaces ) { SetText( ::rtl::math::doubleToUString( fValue, rtl_math_StringFormat_G, - nDecPlaces, lclGetDecSep(), bEraseTrailingDecZeros ) ); + nDecPlaces, lclGetDecSep(), true/*bEraseTrailingDecZeros*/ ) ); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx index a4173e9cadca..c53590d73db2 100644 --- a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx +++ b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx @@ -57,7 +57,7 @@ bool ScPivotLayoutTreeList::DoubleClickHdl() mpParent->PushDataFieldNames(aDataFieldNames); std::unique_ptr<AbstractScDPSubtotalDlg> pDialog( - pFactory->CreateScDPSubtotalDlg(this, mpParent->maPivotTableObject, rCurrentLabelData, rCurrentFunctionData, aDataFieldNames, true)); + pFactory->CreateScDPSubtotalDlg(this, mpParent->maPivotTableObject, rCurrentLabelData, rCurrentFunctionData, aDataFieldNames)); if (pDialog->Execute() == RET_OK) { diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx index d3c7553bcb89..05ea76a84449 100644 --- a/sc/source/ui/docshell/dbdocfun.cxx +++ b/sc/source/ui/docshell/dbdocfun.cxx @@ -277,13 +277,14 @@ void ScDBDocFunc::ModifyAllDBData( const ScDBCollection& rNewColl, const std::ve } } -bool ScDBDocFunc::RepeatDB( const OUString& rDBName, bool bRecord, bool bApi, bool bIsUnnamed, SCTAB aTab ) +bool ScDBDocFunc::RepeatDB( const OUString& rDBName, bool bApi, bool bIsUnnamed, SCTAB aTab ) { //! auch fuer ScDBFunc::RepeatDB benutzen! bool bDone = false; ScDocument& rDoc = rDocShell.GetDocument(); - if (bRecord && !rDoc.IsUndoEnabled()) + bool bRecord = true; + if (!rDoc.IsUndoEnabled()) bRecord = false; ScDBData* pDBData = nullptr; if (bIsUnnamed) @@ -1627,7 +1628,7 @@ void ScDBDocFunc::UpdateImport( const OUString& rTarget, const svx::ODataAccessD aImportParam.nType = static_cast<sal_uInt8>( ( nCommandType == sdb::CommandType::QUERY ) ? ScDbQuery : ScDbTable ); aImportParam.bImport = true; - bool bContinue = DoImport( nTab, aImportParam, &rDescriptor, true ); + bool bContinue = DoImport( nTab, aImportParam, &rDescriptor ); // DB-Operationen wiederholen diff --git a/sc/source/ui/docshell/dbdocimp.cxx b/sc/source/ui/docshell/dbdocimp.cxx index e05b81fd14b9..52cb9ed931d9 100644 --- a/sc/source/ui/docshell/dbdocimp.cxx +++ b/sc/source/ui/docshell/dbdocimp.cxx @@ -116,13 +116,14 @@ bool ScDBDocFunc::DoImportUno( const ScAddress& rPos, } bool ScDBDocFunc::DoImport( SCTAB nTab, const ScImportParam& rParam, - const svx::ODataAccessDescriptor* pDescriptor, bool bRecord ) + const svx::ODataAccessDescriptor* pDescriptor ) { ScDocument& rDoc = rDocShell.GetDocument(); ScChangeTrack *pChangeTrack = nullptr; ScRange aChangedRange; - if (bRecord && !rDoc.IsUndoEnabled()) + bool bRecord = true; + if (!rDoc.IsUndoEnabled()) bRecord = false; ScDBData* pDBData = rDoc.GetDBAtArea( nTab, rParam.nCol1, rParam.nRow1, diff --git a/sc/source/ui/docshell/docfunc.cxx b/sc/source/ui/docshell/docfunc.cxx index c61141a34d8c..81e7caa26d8d 100644 --- a/sc/source/ui/docshell/docfunc.cxx +++ b/sc/source/ui/docshell/docfunc.cxx @@ -645,7 +645,7 @@ bool ScDocFunc::DeleteContents( } bool ScDocFunc::DeleteCell( - const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags nFlags, bool bRecord, bool bApi ) + const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags nFlags, bool bRecord ) { ScDocShellModificator aModificator(rDocShell); @@ -657,8 +657,7 @@ bool ScDocFunc::DeleteCell( ScEditableTester aTester(&rDoc, rPos.Col(), rPos.Row(), rPos.Col(), rPos.Row(), rMark); if (!aTester.IsEditable()) { - if (!bApi) - rDocShell.ErrorMessage(aTester.GetMessageId()); + rDocShell.ErrorMessage(aTester.GetMessageId()); return false; } @@ -713,11 +712,12 @@ bool ScDocFunc::DeleteCell( } bool ScDocFunc::TransliterateText( const ScMarkData& rMark, sal_Int32 nType, - bool bRecord, bool bApi ) + bool bApi ) { ScDocShellModificator aModificator( rDocShell ); ScDocument& rDoc = rDocShell.GetDocument(); + bool bRecord = true; if (bRecord && !rDoc.IsUndoEnabled()) bRecord = false; @@ -1146,7 +1146,7 @@ void ScDocFunc::PutData( const ScAddress& rPos, ScEditEngineDefaulter& rEngine, ScMarkData aMark; aMark.SelectTable( rPos.Tab(), true ); aMark.SetMarkArea( ScRange( rPos ) ); - ApplyAttributes( aMark, aPattern, true, bApi ); + ApplyAttributes( aMark, aPattern, bApi ); } } } @@ -1310,9 +1310,10 @@ void ScDocFunc::ReplaceNote( const ScAddress& rPos, const OUString& rNoteText, c } bool ScDocFunc::ApplyAttributes( const ScMarkData& rMark, const ScPatternAttr& rPattern, - bool bRecord, bool bApi ) + bool bApi ) { ScDocument& rDoc = rDocShell.GetDocument(); + bool bRecord = true; if ( bRecord && !rDoc.IsUndoEnabled() ) bRecord = false; @@ -1372,9 +1373,10 @@ bool ScDocFunc::ApplyAttributes( const ScMarkData& rMark, const ScPatternAttr& r } bool ScDocFunc::ApplyStyle( const ScMarkData& rMark, const OUString& rStyleName, - bool bRecord, bool bApi ) + bool bApi ) { ScDocument& rDoc = rDocShell.GetDocument(); + bool bRecord = true; if ( bRecord && !rDoc.IsUndoEnabled() ) bRecord = false; @@ -2076,7 +2078,7 @@ bool ScDocFunc::InsertCells( const ScRange& rRange, const ScMarkData* pTabMark, } bool ScDocFunc::DeleteCells( const ScRange& rRange, const ScMarkData* pTabMark, DelCellCmd eCmd, - bool bRecord, bool bApi ) + bool bApi ) { ScDocShellModificator aModificator( rDocShell ); @@ -2101,6 +2103,7 @@ bool ScDocFunc::DeleteCells( const ScRange& rRange, const ScMarkData* pTabMark, SCROW nPaintEndRow = nEndRow; sal_uInt16 nPaintFlags = PAINT_GRID; + bool bRecord = true; if (bRecord && !rDoc.IsUndoEnabled()) bRecord = false; @@ -3288,10 +3291,11 @@ bool ScDocFunc::SetTabBgColor( SCTAB nTab, const Color& rColor, bool bRecord, bo } bool ScDocFunc::SetTabBgColor( - ScUndoTabColorInfo::List& rUndoTabColorList, bool bRecord, bool bApi ) + ScUndoTabColorInfo::List& rUndoTabColorList, bool bApi ) { ScDocument& rDoc = rDocShell.GetDocument(); - if (bRecord && !rDoc.IsUndoEnabled()) + bool bRecord = true; + if (!rDoc.IsUndoEnabled()) bRecord = false; if ( !rDoc.IsDocEditable() ) @@ -3929,7 +3933,7 @@ bool ScDocFunc::ChangeIndent( const ScMarkData& rMark, bool bIncrement, bool bAp } bool ScDocFunc::AutoFormat( const ScRange& rRange, const ScMarkData* pTabMark, - sal_uInt16 nFormatNo, bool bRecord, bool bApi ) + sal_uInt16 nFormatNo, bool bApi ) { ScDocShellModificator aModificator( rDocShell ); @@ -3942,7 +3946,8 @@ bool ScDocFunc::AutoFormat( const ScRange& rRange, const ScMarkData* pTabMark, SCROW nEndRow = rRange.aEnd.Row(); SCTAB nEndTab = rRange.aEnd.Tab(); - if (bRecord && !rDoc.IsUndoEnabled()) + bool bRecord = true; + if (!rDoc.IsUndoEnabled()) bRecord = false; ScMarkData aMark; if (pTabMark) @@ -4259,7 +4264,7 @@ void adjustFillRangeForAdjacentCopy(ScRange& rRange, FillDir eDir) } bool ScDocFunc::FillSimple( const ScRange& rRange, const ScMarkData* pTabMark, - FillDir eDir, bool bRecord, bool bApi ) + FillDir eDir, bool bApi ) { ScDocShellModificator aModificator( rDocShell ); ScDocument& rDoc = rDocShell.GetDocument(); @@ -4275,7 +4280,8 @@ bool ScDocFunc::FillSimple( const ScRange& rRange, const ScMarkData* pTabMark, SCROW nEndRow = aRange.aEnd.Row(); SCTAB nEndTab = aRange.aEnd.Tab(); - if (bRecord && !rDoc.IsUndoEnabled()) + bool bRecord = true; + if (!rDoc.IsUndoEnabled()) bRecord = false; ScMarkData aMark; @@ -4370,7 +4376,7 @@ bool ScDocFunc::FillSimple( const ScRange& rRange, const ScMarkData* pTabMark, bool ScDocFunc::FillSeries( const ScRange& rRange, const ScMarkData* pTabMark, FillDir eDir, FillCmd eCmd, FillDateCmd eDateCmd, double fStart, double fStep, double fMax, - bool bRecord, bool bApi ) + bool bApi ) { ScDocShellModificator aModificator( rDocShell ); @@ -4383,7 +4389,8 @@ bool ScDocFunc::FillSeries( const ScRange& rRange, const ScMarkData* pTabMark, SCROW nEndRow = rRange.aEnd.Row(); SCTAB nEndTab = rRange.aEnd.Tab(); - if (bRecord && !rDoc.IsUndoEnabled()) + bool bRecord = true; + if (!rDoc.IsUndoEnabled()) bRecord = false; ScMarkData aMark; @@ -4495,11 +4502,11 @@ bool ScDocFunc::FillSeries( const ScRange& rRange, const ScMarkData* pTabMark, } bool ScDocFunc::FillAuto( ScRange& rRange, const ScMarkData* pTabMark, - FillDir eDir, sal_uLong nCount, bool bRecord, bool bApi ) + FillDir eDir, sal_uLong nCount, bool bApi ) { double fStep = 1.0; double fMax = MAXDOUBLE; - return FillAuto( rRange, pTabMark, eDir, FILL_AUTO, FILL_DAY, nCount, fStep, fMax, bRecord, bApi ); + return FillAuto( rRange, pTabMark, eDir, FILL_AUTO, FILL_DAY, nCount, fStep, fMax, true/*bRecord*/, bApi ); } bool ScDocFunc::FillAuto( ScRange& rRange, const ScMarkData* pTabMark, FillDir eDir, FillCmd eCmd, FillDateCmd eDateCmd, sal_uLong nCount, double fStep, double fMax, bool bRecord, bool bApi ) @@ -5154,7 +5161,7 @@ bool ScDocFunc::InsertNameList( const ScAddress& rStartPos, bool bApi ) return bDone; } -void ScDocFunc::ResizeMatrix( const ScRange& rOldRange, const ScAddress& rNewEnd, bool bApi ) +void ScDocFunc::ResizeMatrix( const ScRange& rOldRange, const ScAddress& rNewEnd ) { ScDocument& rDoc = rDocShell.GetDocument(); SCCOL nStartCol = rOldRange.aStart.Col(); @@ -5177,13 +5184,13 @@ void ScDocFunc::ResizeMatrix( const ScRange& rOldRange, const ScAddress& rNewEnd aMark.SelectTable( nTab, true ); ScRange aNewRange( rOldRange.aStart, rNewEnd ); - if ( DeleteContents( aMark, InsertDeleteFlags::CONTENTS, true, bApi ) ) + if ( DeleteContents( aMark, InsertDeleteFlags::CONTENTS, true, false/*bApi*/ ) ) { // GRAM_PODF_A1 for API compatibility. - if (!EnterMatrix( aNewRange, &aMark, nullptr, aFormula, bApi, false, EMPTY_OUSTRING, formula::FormulaGrammar::GRAM_PODF_A1 )) + if (!EnterMatrix( aNewRange, &aMark, nullptr, aFormula, false/*bApi*/, false, EMPTY_OUSTRING, formula::FormulaGrammar::GRAM_PODF_A1 )) { // versuchen, alten Zustand wiederherzustellen - EnterMatrix( rOldRange, &aMark, nullptr, aFormula, bApi, false, EMPTY_OUSTRING, formula::FormulaGrammar::GRAM_PODF_A1 ); + EnterMatrix( rOldRange, &aMark, nullptr, aFormula, false/*bApi*/, false, EMPTY_OUSTRING, formula::FormulaGrammar::GRAM_PODF_A1 ); } } @@ -5382,10 +5389,11 @@ void ScDocFunc::SetConditionalFormatList( ScConditionalFormatList* pList, SCTAB SfxGetpApp()->Broadcast(SfxSimpleHint(SC_HINT_AREAS_CHANGED)); } -void ScDocFunc::ConvertFormulaToValue( const ScRange& rRange, bool bRecord, bool bInteraction ) +void ScDocFunc::ConvertFormulaToValue( const ScRange& rRange, bool bInteraction ) { ScDocShellModificator aModificator(rDocShell); ScDocument& rDoc = rDocShell.GetDocument(); + bool bRecord = true; if (!rDoc.IsUndoEnabled()) bRecord = false; diff --git a/sc/source/ui/docshell/docsh2.cxx b/sc/source/ui/docshell/docsh2.cxx index fd8cc681bd46..429a3f5390fb 100644 --- a/sc/source/ui/docshell/docsh2.cxx +++ b/sc/source/ui/docshell/docsh2.cxx @@ -44,7 +44,7 @@ bool ScDocShell::InitNew( const uno::Reference < embed::XStorage >& xStor ) Size aSize( (long) ( STD_COL_WIDTH * HMM_PER_TWIPS * OLE_STD_CELLS_X ), (long) ( ScGlobal::nStdRowHeight * HMM_PER_TWIPS * OLE_STD_CELLS_Y ) ); // Also adjust start here - SetVisAreaOrSize( Rectangle( Point(), aSize ), true ); + SetVisAreaOrSize( Rectangle( Point(), aSize ) ); } // InitOptions sets the document languages, must be called before CreateStandardStyles diff --git a/sc/source/ui/docshell/docsh3.cxx b/sc/source/ui/docshell/docsh3.cxx index a805c0194e18..f9bb67114e8f 100644 --- a/sc/source/ui/docshell/docsh3.cxx +++ b/sc/source/ui/docshell/docsh3.cxx @@ -1035,7 +1035,7 @@ void ScDocShell::MergeDocument( ScDocument& rOtherDoc, bool bShared, bool bCheck if ( pDel->IsTopDelete() ) { aSourceRange = pDel->GetOverAllRange().MakeRange(); - GetDocFunc().DeleteCells( aSourceRange, nullptr, DEL_DELROWS, true, false ); + GetDocFunc().DeleteCells( aSourceRange, nullptr, DEL_DELROWS, false ); // #i101099# [Collaboration] Changes are not correctly shown if ( bShared ) @@ -1055,7 +1055,7 @@ void ScDocShell::MergeDocument( ScDocument& rOtherDoc, bool bShared, bool bCheck if ( pDel->IsTopDelete() && !pDel->IsTabDeleteCol() ) { // deleted Table enthaelt deleted Cols, die nicht aSourceRange = pDel->GetOverAllRange().MakeRange(); - GetDocFunc().DeleteCells( aSourceRange, nullptr, DEL_DELCOLS, true, false ); + GetDocFunc().DeleteCells( aSourceRange, nullptr, DEL_DELCOLS, false ); } } break; diff --git a/sc/source/ui/docshell/docsh5.cxx b/sc/source/ui/docshell/docsh5.cxx index a2d7dd018549..74ddbd84b480 100644 --- a/sc/source/ui/docshell/docsh5.cxx +++ b/sc/source/ui/docshell/docsh5.cxx @@ -1011,7 +1011,7 @@ IMPL_LINK_TYPED( ScDocShell, RefreshDBDataHdl, Timer*, pRefreshTimer, void ) { ScRange aRange; pDBData->GetArea( aRange ); - bool bContinue = aFunc.DoImport( aRange.aStart.Tab(), aImportParam, nullptr, true ); //! Api-Flag as parameter + bool bContinue = aFunc.DoImport( aRange.aStart.Tab(), aImportParam, nullptr ); //! Api-Flag as parameter // internal operations (sort, query, subtotal) only if no error if (bContinue) { diff --git a/sc/source/ui/docshell/docsh6.cxx b/sc/source/ui/docshell/docsh6.cxx index 5f9dc0cc7b10..8ef31acc47ee 100644 --- a/sc/source/ui/docshell/docsh6.cxx +++ b/sc/source/ui/docshell/docsh6.cxx @@ -70,7 +70,7 @@ void ScDocShell::SetVisArea( const Rectangle & rVisArea ) { // with the SnapVisArea call in SetVisAreaOrSize, it's safe to always // use both the size and position of the VisArea - SetVisAreaOrSize( rVisArea, true ); + SetVisAreaOrSize( rVisArea ); } static void lcl_SetTopRight( Rectangle& rRect, const Point& rPos ) @@ -82,45 +82,34 @@ static void lcl_SetTopRight( Rectangle& rRect, const Point& rPos ) rRect.Bottom() = rPos.Y() + aSize.Height() - 1; } -void ScDocShell::SetVisAreaOrSize( const Rectangle& rVisArea, bool bModifyStart ) +void ScDocShell::SetVisAreaOrSize( const Rectangle& rVisArea ) { bool bNegativePage = aDocument.IsNegativePage( aDocument.GetVisibleTab() ); Rectangle aArea = rVisArea; - if (bModifyStart) + // when loading, don't check for negative values, because the sheet orientation + // might be set later + if ( !aDocument.IsImportingXML() ) { - // when loading, don't check for negative values, because the sheet orientation - // might be set later - if ( !aDocument.IsImportingXML() ) + if ( ( bNegativePage ? (aArea.Right() > 0) : (aArea.Left() < 0) ) || aArea.Top() < 0 ) { - if ( ( bNegativePage ? (aArea.Right() > 0) : (aArea.Left() < 0) ) || aArea.Top() < 0 ) + // VisArea start position can't be negative. + // Move the VisArea, otherwise only the upper left position would + // be changed in SnapVisArea, and the size would be wrong. + + Point aNewPos( 0, std::max( aArea.Top(), (long) 0 ) ); + if ( bNegativePage ) + { + aNewPos.X() = std::min( aArea.Right(), (long) 0 ); + lcl_SetTopRight( aArea, aNewPos ); + } + else { - // VisArea start position can't be negative. - // Move the VisArea, otherwise only the upper left position would - // be changed in SnapVisArea, and the size would be wrong. - - Point aNewPos( 0, std::max( aArea.Top(), (long) 0 ) ); - if ( bNegativePage ) - { - aNewPos.X() = std::min( aArea.Right(), (long) 0 ); - lcl_SetTopRight( aArea, aNewPos ); - } - else - { - aNewPos.X() = std::max( aArea.Left(), (long) 0 ); - aArea.SetPos( aNewPos ); - } + aNewPos.X() = std::max( aArea.Left(), (long) 0 ); + aArea.SetPos( aNewPos ); } } } - else - { - Rectangle aOldVisArea = SfxObjectShell::GetVisArea(); - if ( bNegativePage ) - lcl_SetTopRight( aArea, aOldVisArea.TopRight() ); - else - aArea.SetPos( aOldVisArea.TopLeft() ); - } // hier Position anpassen! @@ -207,7 +196,7 @@ void ScDocShell::UpdateOle( const ScViewData* pViewData, bool bSnapSize ) } if (aNewArea != aOldArea) - SetVisAreaOrSize( aNewArea, true ); // hier muss auch der Start angepasst werden + SetVisAreaOrSize( aNewArea ); // hier muss auch der Start angepasst werden } // Style-Krempel fuer Organizer etc. diff --git a/sc/source/ui/docshell/externalrefmgr.cxx b/sc/source/ui/docshell/externalrefmgr.cxx index c2ace4a4e825..87d51ee52721 100644 --- a/sc/source/ui/docshell/externalrefmgr.cxx +++ b/sc/source/ui/docshell/externalrefmgr.cxx @@ -1050,7 +1050,7 @@ bool ScExternalRefCache::setCacheDocReferenced( sal_uInt16 nFileId ) return areAllCacheTablesReferenced(); } -bool ScExternalRefCache::setCacheTableReferenced( sal_uInt16 nFileId, const OUString& rTabName, size_t nSheets, bool bPermanent ) +bool ScExternalRefCache::setCacheTableReferenced( sal_uInt16 nFileId, const OUString& rTabName, size_t nSheets ) { DocItem* pDoc = getDocItem(nFileId); if (pDoc) @@ -1065,9 +1065,7 @@ bool ScExternalRefCache::setCacheTableReferenced( sal_uInt16 nFileId, const OUSt TableTypeRef pTab = pDoc->maTables[i]; if (pTab.get()) { - Table::ReferencedFlag eNewFlag = (bPermanent ? - Table::REFERENCED_PERMANENT : - Table::REFERENCED_MARKED); + Table::ReferencedFlag eNewFlag = Table::REFERENCED_MARKED; Table::ReferencedFlag eOldFlag = pTab->getReferencedFlag(); if (eOldFlag != Table::REFERENCED_PERMANENT && eNewFlag != eOldFlag) { @@ -1741,7 +1739,7 @@ void ScExternalRefManager::markUsedExternalRefCells() bool ScExternalRefManager::setCacheTableReferenced( sal_uInt16 nFileId, const OUString& rTabName, size_t nSheets ) { - return maRefCache.setCacheTableReferenced( nFileId, rTabName, nSheets, false); + return maRefCache.setCacheTableReferenced( nFileId, rTabName, nSheets); } void ScExternalRefManager::setAllCacheTableReferencedStati( bool bReferenced ) diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx index c018e1dcfc92..39cf5be29b0f 100644 --- a/sc/source/ui/docshell/impex.cxx +++ b/sc/source/ui/docshell/impex.cxx @@ -2164,7 +2164,7 @@ bool ScImportExport::RTF2Doc( SvStream& rStrm, const OUString& rBaseURL ) bool ScImportExport::HTML2Doc( SvStream& rStrm, const OUString& rBaseURL ) { - ScEEAbsImport *pImp = ScFormatFilter::Get().CreateHTMLImport( pDoc, rBaseURL, aRange, true); + ScEEAbsImport *pImp = ScFormatFilter::Get().CreateHTMLImport( pDoc, rBaseURL, aRange); if (!pImp) return false; pImp->Read( rStrm, rBaseURL ); @@ -2218,7 +2218,7 @@ class ScFormatFilterMissing : public ScFormatFilterPlugin { virtual FltError ScImportHTML( SvStream&, const OUString&, ScDocument*, ScRange&, double, bool, SvNumberFormatter*, bool ) override { return eERR_INTERN; } virtual ScEEAbsImport *CreateRTFImport( ScDocument*, const ScRange& ) override { return nullptr; } - virtual ScEEAbsImport *CreateHTMLImport( ScDocument*, const OUString&, const ScRange&, bool ) override { return nullptr; } + virtual ScEEAbsImport *CreateHTMLImport( ScDocument*, const OUString&, const ScRange& ) override { return nullptr; } virtual OUString GetHTMLRangeNameList( ScDocument*, const OUString& ) override { return OUString(); } virtual FltError ScExportExcel5( SfxMedium&, ScDocument*, ExportFormatExcel, rtl_TextEncoding ) override { return eERR_INTERN; } diff --git a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx index e1a1de7d5059..f1fe8e563243 100644 --- a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx +++ b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx @@ -62,7 +62,7 @@ public: ScAddress mMaximumAddress; bool mTrackRange; - AddressWalker(ScAddress aInitialAddress, bool aTrackRange = true); + AddressWalker(ScAddress aInitialAddress); ScAddress current(SCCOL aRelativeCol = 0, SCROW aRelativeRow = 0, SCTAB aRelativeTab = 0); diff --git a/sc/source/ui/inc/cbutton.hxx b/sc/source/ui/inc/cbutton.hxx index 4b6aaaedb99a..027dd786ee84 100644 --- a/sc/source/ui/inc/cbutton.hxx +++ b/sc/source/ui/inc/cbutton.hxx @@ -35,10 +35,9 @@ public: void SetOutputDevice( OutputDevice* pOutputDevice ); void Draw( const Point& rAt, - const Size& rSize, - bool bState ); + const Size& rSize ); void Draw() - { Draw( aBtnPos, aBtnSize, false ); } + { Draw( aBtnPos, aBtnSize ); } void SetOptSizePixel(); diff --git a/sc/source/ui/inc/checklistmenu.hxx b/sc/source/ui/inc/checklistmenu.hxx index 693de5ef957c..fa104edef031 100644 --- a/sc/source/ui/inc/checklistmenu.hxx +++ b/sc/source/ui/inc/checklistmenu.hxx @@ -58,7 +58,7 @@ public: virtual void Paint(vcl::RenderContext& rRenderContext, const Rectangle& rRect) override; virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override; - void addMenuItem(const OUString& rText, bool bEnabled, Action* pAction); + void addMenuItem(const OUString& rText, Action* pAction); void addSeparator(); ScMenuFloatingWindow* addSubMenuItem(const OUString& rText, bool bEnabled); diff --git a/sc/source/ui/inc/crdlg.hxx b/sc/source/ui/inc/crdlg.hxx index e818d0707ed8..66f644714ed9 100644 --- a/sc/source/ui/inc/crdlg.hxx +++ b/sc/source/ui/inc/crdlg.hxx @@ -29,7 +29,7 @@ class ScColOrRowDlg : public ModalDialog { public: ScColOrRowDlg(vcl::Window* pParent, const OUString& rStrTitle, - const OUString& rStrLabel, bool bColDefault = true); + const OUString& rStrLabel); virtual ~ScColOrRowDlg(); virtual void dispose() override; private: diff --git a/sc/source/ui/inc/dbdocfun.hxx b/sc/source/ui/inc/dbdocfun.hxx index f8e87b4d7224..ec404d4ef7b2 100644 --- a/sc/source/ui/inc/dbdocfun.hxx +++ b/sc/source/ui/inc/dbdocfun.hxx @@ -61,8 +61,7 @@ public: void UpdateImport( const OUString& rTarget, const svx::ODataAccessDescriptor& rDescriptor ); bool DoImport( SCTAB nTab, const ScImportParam& rParam, - const svx::ODataAccessDescriptor* pDescriptor, // used for selection an existing ResultSet - bool bRecord ); + const svx::ODataAccessDescriptor* pDescriptor); // used for selection an existing ResultSet bool DoImportUno( const ScAddress& rPos, const css::uno::Sequence<css::beans::PropertyValue>& aArgs ); @@ -86,7 +85,7 @@ public: void ModifyAllDBData( const ScDBCollection& rNewColl, const std::vector<ScRange>& rDelAreaList ); - bool RepeatDB( const OUString& rDBName, bool bRecord, bool bApi, bool bIsUnnamed=false, SCTAB aTab = 0); + bool RepeatDB( const OUString& rDBName, bool bApi, bool bIsUnnamed=false, SCTAB aTab = 0); bool DataPilotUpdate( ScDPObject* pOldObj, const ScDPObject* pNewObj, bool bRecord, bool bApi, bool bAllowMove = false ); diff --git a/sc/source/ui/inc/dbfunc.hxx b/sc/source/ui/inc/dbfunc.hxx index 6df004f9bb27..69325bd32356 100644 --- a/sc/source/ui/inc/dbfunc.hxx +++ b/sc/source/ui/inc/dbfunc.hxx @@ -102,7 +102,7 @@ public: void AutoOutline(); void SelectLevel( bool bColumns, sal_uInt16 nLevel, - bool bRecord = true, bool bPaint = true ); + bool bRecord = true ); void ShowOutline( bool bColumns, sal_uInt16 nLevel, sal_uInt16 nEntry, bool bRecord = true, bool bPaint = true ); void HideOutline( bool bColumns, sal_uInt16 nLevel, sal_uInt16 nEntry, diff --git a/sc/source/ui/inc/docfunc.hxx b/sc/source/ui/inc/docfunc.hxx index bf5788351311..b7709294b7c4 100644 --- a/sc/source/ui/inc/docfunc.hxx +++ b/sc/source/ui/inc/docfunc.hxx @@ -89,10 +89,10 @@ public: const ScMarkData& rMark, InsertDeleteFlags nFlags, bool bRecord, bool bApi ); bool DeleteCell( - const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags nFlags, bool bRecord, bool bApi ); + const ScAddress& rPos, const ScMarkData& rMark, InsertDeleteFlags nFlags, bool bRecord ); bool TransliterateText( const ScMarkData& rMark, sal_Int32 nType, - bool bRecord, bool bApi ); + bool bApi ); bool SetNormalString( bool& o_rbNumFmtSet, const ScAddress& rPos, const OUString& rText, bool bApi ); bool SetValueCell( const ScAddress& rPos, double fVal, bool bInteraction ); @@ -118,15 +118,15 @@ public: void ReplaceNote( const ScAddress& rPos, const OUString& rNoteText, const OUString* pAuthor, const OUString* pDate, bool bApi ); bool ApplyAttributes( const ScMarkData& rMark, const ScPatternAttr& rPattern, - bool bRecord, bool bApi ); + bool bApi ); bool ApplyStyle( const ScMarkData& rMark, const OUString& rStyleName, - bool bRecord, bool bApi ); + bool bApi ); bool InsertCells( const ScRange& rRange,const ScMarkData* pTabMark, InsCellCmd eCmd, bool bRecord, bool bApi, bool bPartOfPaste = false ); bool DeleteCells( const ScRange& rRange, const ScMarkData* pTabMark, - DelCellCmd eCmd, bool bRecord, bool bApi ); + DelCellCmd eCmd, bool bApi ); bool MoveBlock( const ScRange& rSource, const ScAddress& rDestPos, bool bCut, bool bRecord, bool bPaint, bool bApi ); @@ -136,7 +136,7 @@ public: bool DeleteTable( SCTAB nTab, bool bRecord, bool bApi ); bool SetTabBgColor( SCTAB nTab, const Color& rColor, bool bRecord, bool bApi ); - bool SetTabBgColor( ScUndoTabColorInfo::List& rUndoTabColorList, bool bRecord, bool bApi ); + bool SetTabBgColor( ScUndoTabColorInfo::List& rUndoTabColorList, bool bApi ); void SetTableVisible( SCTAB nTab, bool bVisible, bool bApi ); @@ -159,7 +159,7 @@ public: void ClearItems( const ScMarkData& rMark, const sal_uInt16* pWhich, bool bApi ); bool ChangeIndent( const ScMarkData& rMark, bool bIncrement, bool bApi ); bool AutoFormat( const ScRange& rRange, const ScMarkData* pTabMark, - sal_uInt16 nFormatNo, bool bRecord, bool bApi ); + sal_uInt16 nFormatNo, bool bApi ); SC_DLLPUBLIC bool EnterMatrix( const ScRange& rRange, const ScMarkData* pTabMark, @@ -172,20 +172,20 @@ public: const ScTabOpParam& rParam, bool bRecord, bool bApi ); bool FillSimple( const ScRange& rRange, const ScMarkData* pTabMark, - FillDir eDir, bool bRecord, bool bApi ); + FillDir eDir, bool bApi ); bool FillSeries( const ScRange& rRange, const ScMarkData* pTabMark, FillDir eDir, FillCmd eCmd, FillDateCmd eDateCmd, double fStart, double fStep, double fMax, - bool bRecord, bool bApi ); + bool bApi ); // FillAuto: rRange wird von Source-Range auf Dest-Range angepasst SC_DLLPUBLIC bool FillAuto( ScRange& rRange, const ScMarkData* pTabMark, FillDir eDir, FillCmd eCmd, FillDateCmd eDateCmd, sal_uLong nCount, double fStep, double fMax, bool bRecord, bool bApi ); bool FillAuto( ScRange& rRange, const ScMarkData* pTabMark, - FillDir eDir, sal_uLong nCount, bool bRecord, bool bApi ); + FillDir eDir, sal_uLong nCount, bool bApi ); - void ResizeMatrix( const ScRange& rOldRange, const ScAddress& rNewEnd, bool bApi ); + void ResizeMatrix( const ScRange& rOldRange, const ScAddress& rNewEnd ); bool MergeCells( const ScCellMergeOption& rOption, bool bContents, bool bRecord, bool bApi ); @@ -224,7 +224,7 @@ public: */ void SetConditionalFormatList( ScConditionalFormatList* pList, SCTAB nTab ); - void ConvertFormulaToValue( const ScRange& rRange, bool bRecord, bool bInteraction ); + void ConvertFormulaToValue( const ScRange& rRange, bool bInteraction ); }; class ScDocFuncDirect : public ScDocFunc diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx index 23755ba2ae28..69421be79811 100644 --- a/sc/source/ui/inc/docsh.hxx +++ b/sc/source/ui/inc/docsh.hxx @@ -218,7 +218,7 @@ public: virtual void SetModified( bool = true ) override; - void SetVisAreaOrSize( const Rectangle& rVisArea, bool bModifyStart ); + void SetVisAreaOrSize( const Rectangle& rVisArea ); virtual VclPtr<SfxDocumentInfoDialog> CreateDocumentInfoDialog( const SfxItemSet &rSet ) override; diff --git a/sc/source/ui/inc/editfield.hxx b/sc/source/ui/inc/editfield.hxx index 81c370bb1255..2020db572aae 100644 --- a/sc/source/ui/inc/editfield.hxx +++ b/sc/source/ui/inc/editfield.hxx @@ -30,8 +30,7 @@ public: bool GetValue( double& rfValue ) const; void SetValue( double fValue, - sal_Int32 nDecPlaces = 12, - bool bEraseTrailingDecZeros = true ); + sal_Int32 nDecPlaces = 12 ); }; #endif diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx index 6e4f83ba10b2..a8862538e5d2 100644 --- a/sc/source/ui/inc/gridwin.hxx +++ b/sc/source/ui/inc/gridwin.hxx @@ -354,7 +354,7 @@ public: void UpdateFormulas(); - void LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelect ); + void LaunchDataSelectMenu( SCCOL nCol, SCROW nRow ); void DoScenarioMenu( const ScRange& rScenRange ); void LaunchAutoFilterMenu(SCCOL nCol, SCROW nRow); diff --git a/sc/source/ui/inc/inputhdl.hxx b/sc/source/ui/inc/inputhdl.hxx index c41171c52033..ee2632ce93d7 100644 --- a/sc/source/ui/inc/inputhdl.hxx +++ b/sc/source/ui/inc/inputhdl.hxx @@ -185,7 +185,7 @@ public: void SetReference( const ScRange& rRef, ScDocument* pDoc ); void AddRefEntry(); - void InputCommand( const CommandEvent& rCEvt, bool bForce ); + void InputCommand( const CommandEvent& rCEvt ); void InsertFunction( const OUString& rFuncName, bool bAddPar = true ); void ClearText(); diff --git a/sc/source/ui/inc/olinewin.hxx b/sc/source/ui/inc/olinewin.hxx index 0c5def840aed..6b94819da135 100644 --- a/sc/source/ui/inc/olinewin.hxx +++ b/sc/source/ui/inc/olinewin.hxx @@ -162,9 +162,9 @@ private: @return true = focus wrapped from end to start or vice versa. */ bool ImplMoveFocusByLevel( bool bForward ); /** Calculates position of focus button in tab order. - @param bFindVisible true = repeats until a visible button has been found. + Repeats until a visible button has been found. @return true = focus wrapped from end to start or vice versa. */ - bool ImplMoveFocusByTabOrder( bool bForward, bool bFindVisible ); + bool ImplMoveFocusByTabOrder( bool bForward ); /** If the focused entry is invisible, tries to move to visible position. */ void ImplMoveFocusToVisible( bool bForward ); diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx index da55593698b0..fee9cf9780ef 100644 --- a/sc/source/ui/inc/tabview.hxx +++ b/sc/source/ui/inc/tabview.hxx @@ -515,7 +515,7 @@ public: void FreezeSplitters( bool bFreeze, SplitMethod eSplitMethod = SC_SPLIT_METHOD_CURSOR ); void RemoveSplit(); void SplitAtCursor(); - void SplitAtPixel( const Point& rPixel, bool bHor, bool bVer ); + void SplitAtPixel( const Point& rPixel ); void InvalidateSplit(); void ErrorMessage( sal_uInt16 nGlobStrId ); diff --git a/sc/source/ui/inc/undobase.hxx b/sc/source/ui/inc/undobase.hxx index b81af2091f3b..192f47e077a0 100644 --- a/sc/source/ui/inc/undobase.hxx +++ b/sc/source/ui/inc/undobase.hxx @@ -100,8 +100,7 @@ protected: class ScMultiBlockUndo: public ScSimpleUndo { public: - ScMultiBlockUndo(ScDocShell* pDocSh, const ScRangeList& rRanges, - ScBlockUndoMode eBlockMode); + ScMultiBlockUndo(ScDocShell* pDocSh, const ScRangeList& rRanges); virtual ~ScMultiBlockUndo(); protected: diff --git a/sc/source/ui/inc/undocell.hxx b/sc/source/ui/inc/undocell.hxx index 7de6d534c3d7..98157823cb38 100644 --- a/sc/source/ui/inc/undocell.hxx +++ b/sc/source/ui/inc/undocell.hxx @@ -48,7 +48,7 @@ public: ScUndoCursorAttr( ScDocShell* pNewDocShell, SCCOL nNewCol, SCROW nNewRow, SCTAB nNewTab, const ScPatternAttr* pOldPat, const ScPatternAttr* pNewPat, - const ScPatternAttr* pApplyPat, bool bAutomatic ); + const ScPatternAttr* pApplyPat ); virtual ~ScUndoCursorAttr(); virtual void Undo() override; diff --git a/sc/source/ui/inc/undodat.hxx b/sc/source/ui/inc/undodat.hxx index 98cc867b3eba..8270dda2568e 100644 --- a/sc/source/ui/inc/undodat.hxx +++ b/sc/source/ui/inc/undodat.hxx @@ -440,8 +440,7 @@ public: const ScMarkData& rMark, ScDocument* pNewUndoDoc, ScDocument* pNewRedoDoc, InsertDeleteFlags nNewFlags, - ScRefUndoData* pRefData, void* pFill1, void* pFill2, void* pFill3, - bool bRedoIsFilled = true + ScRefUndoData* pRefData, void* pFill1, void* pFill2, void* pFill3 ); virtual ~ScUndoDataForm(); diff --git a/sc/source/ui/inc/viewdata.hxx b/sc/source/ui/inc/viewdata.hxx index f6026fb863e5..7b190b5aba36 100644 --- a/sc/source/ui/inc/viewdata.hxx +++ b/sc/source/ui/inc/viewdata.hxx @@ -245,7 +245,7 @@ public: ScDrawView* GetScDrawView(); // from View bool IsMinimized(); // from View - void UpdateInputHandler( bool bForce = false, bool bStopEditing = true ); + void UpdateInputHandler( bool bForce = false ); void WriteUserData(OUString& rData); void ReadUserData(const OUString& rData); @@ -349,8 +349,7 @@ public: bool GetMergeSizePixel( SCCOL nX, SCROW nY, long& rSizeXPix, long& rSizeYPix ) const; void GetPosFromPixel( long nClickX, long nClickY, ScSplitPos eWhich, SCsCOL& rPosX, SCsROW& rPosY, - bool bTestMerge = true, bool bRepair = false, - bool bNextIfLarge = true ); + bool bTestMerge = true, bool bRepair = false ); void GetMouseQuadrant( const Point& rClickPos, ScSplitPos eWhich, SCsCOL nPosX, SCsROW nPosY, bool& rLeft, bool& rTop ); diff --git a/sc/source/ui/inc/viewfunc.hxx b/sc/source/ui/inc/viewfunc.hxx index 29fe7e482463..45ea187627b6 100644 --- a/sc/source/ui/inc/viewfunc.hxx +++ b/sc/source/ui/inc/viewfunc.hxx @@ -101,7 +101,7 @@ public: SC_DLLPUBLIC bool CopyToClip( ScDocument* pClipDoc = nullptr, bool bCut = false, bool bApi = false, bool bIncludeObjects = false, bool bStopEdit = true ); SC_DLLPUBLIC bool CopyToClip( ScDocument* pClipDoc, const ScRangeList& rRange, bool bCut = false, - bool bApi = false, bool bIncludeObjects = false, bool bStopEdit = true, bool bUseRangeForVBA = true ); + bool bApi = false, bool bIncludeObjects = false, bool bStopEdit = true ); ScTransferObj* CopyToTransferable(); SC_DLLPUBLIC bool PasteFromClip( InsertDeleteFlags nFlags, ScDocument* pClipDoc, ScPasteFunc nFunction = ScPasteFunc::NONE, bool bSkipEmpty = false, @@ -147,9 +147,9 @@ public: bool HasBookmarkAtCursor( SvxHyperlinkItem* pContent ); bool MoveBlockTo( const ScRange& rSource, const ScAddress& rDestPos, - bool bCut, bool bRecord, bool bPaint, bool bApi ); + bool bCut ); - bool LinkBlock( const ScRange& rSource, const ScAddress& rDestPos, bool bApi ); + bool LinkBlock( const ScRange& rSource, const ScAddress& rDestPos ); void CreateNames( sal_uInt16 nFlags ); sal_uInt16 GetCreateNameFlags(); @@ -160,8 +160,7 @@ public: void ApplyAttributes( const SfxItemSet* pDialogSet, const SfxItemSet* pOldSet ); void ApplyAttr( const SfxPoolItem& rAttrItem ); void ApplySelectionPattern( const ScPatternAttr& rAttr, - bool bRecord = true, - bool bCursorOnly = false ); + bool bCursorOnly = false); void ApplyPatternLines( const ScPatternAttr& rAttr, const SvxBoxItem* pNewOuter, const SvxBoxInfoItem* pNewInner ); @@ -195,7 +194,7 @@ public: void SetWidthOrHeight( bool bWidth, const std::vector<sc::ColRowSpan>& rRanges, ScSizeMode eMode, - sal_uInt16 nSizeTwips, bool bRecord = true, bool bPaint = true, ScMarkData* pMarkData = nullptr ); + sal_uInt16 nSizeTwips, bool bRecord = true, ScMarkData* pMarkData = nullptr ); void SetMarkedWidthOrHeight( bool bWidth, ScSizeMode eMode, sal_uInt16 nSizeTwips ); @@ -221,7 +220,7 @@ public: bool TestMergeCells(); bool TestRemoveMerge(); - bool MergeCells( bool bApi, bool& rDoContents, bool bRecord = true, bool bCenter = false ); + bool MergeCells( bool bApi, bool& rDoContents, bool bCenter = false ); bool RemoveMerge(); void FillSimple( FillDir eDir ); @@ -266,7 +265,7 @@ public: const OUString& rTabName ); void InsertAreaLink( const OUString& rFile, const OUString& rFilter, const OUString& rOptions, - const OUString& rSource, sal_uLong nRefresh ); + const OUString& rSource ); void ShowTable( const std::vector<OUString>& rNames ); void HideTable( const ScMarkData& rMark ); diff --git a/sc/source/ui/inc/warnbox.hxx b/sc/source/ui/inc/warnbox.hxx index 7ae2360e9efa..d8a49cf021c8 100644 --- a/sc/source/ui/inc/warnbox.hxx +++ b/sc/source/ui/inc/warnbox.hxx @@ -26,9 +26,8 @@ class ScCbWarningBox : public WarningBox { public: - /** @param rMsgStr Resource ID for the message text. - @param bDefYes true = "Yes" focused, false = "No" focused. */ - ScCbWarningBox( vcl::Window* pParent, const OUString& rMsgStr, bool bDefYes = true ); + /** @param rMsgStr Resource ID for the message text. */ + ScCbWarningBox( vcl::Window* pParent, const OUString& rMsgStr ); /** Opens dialog if IsDialogEnabled() returns true. @descr If after executing the dialog the checkbox "Do not show again" is set, diff --git a/sc/source/ui/miscdlgs/crdlg.cxx b/sc/source/ui/miscdlgs/crdlg.cxx index 2fc9fe903231..deff2906e5a7 100644 --- a/sc/source/ui/miscdlgs/crdlg.cxx +++ b/sc/source/ui/miscdlgs/crdlg.cxx @@ -24,7 +24,7 @@ #include "miscdlgs.hrc" ScColOrRowDlg::ScColOrRowDlg(vcl::Window* pParent, const OUString& rStrTitle, - const OUString& rStrLabel, bool bColDefault) + const OUString& rStrLabel) : ModalDialog(pParent, "ColOrRowDialog", "modules/scalc/ui/colorrowdialog.ui") { @@ -36,10 +36,7 @@ ScColOrRowDlg::ScColOrRowDlg(vcl::Window* pParent, const OUString& rStrTitle, SetText(rStrTitle); m_pFrame->set_label(rStrLabel); - if (bColDefault) - m_pBtnCols->Check(); - else - m_pBtnRows->Check(); + m_pBtnCols->Check(); m_pBtnOk->SetClickHdl( LINK( this, ScColOrRowDlg, OkHdl ) ); } diff --git a/sc/source/ui/miscdlgs/warnbox.cxx b/sc/source/ui/miscdlgs/warnbox.cxx index 75c7b6032bf6..8d500490f13c 100644 --- a/sc/source/ui/miscdlgs/warnbox.cxx +++ b/sc/source/ui/miscdlgs/warnbox.cxx @@ -24,8 +24,8 @@ #include "scresid.hxx" #include "sc.hrc" -ScCbWarningBox::ScCbWarningBox( vcl::Window* pParent, const OUString& rMsgStr, bool bDefYes ) : - WarningBox( pParent, WB_YES_NO | (bDefYes ? WB_DEF_YES : WB_DEF_NO), rMsgStr ) +ScCbWarningBox::ScCbWarningBox( vcl::Window* pParent, const OUString& rMsgStr ) : + WarningBox( pParent, WB_YES_NO | WB_DEF_YES, rMsgStr ) { // By default, the check box is ON, and the user needs to un-check it to // disable all future warnings. @@ -55,7 +55,7 @@ void ScCbWarningBox::DisableDialog() } ScReplaceWarnBox::ScReplaceWarnBox( vcl::Window* pParent ) : - ScCbWarningBox( pParent, OUString( ScResId( STR_REPLCELLSWARN ) ), true ) + ScCbWarningBox( pParent, OUString( ScResId( STR_REPLCELLSWARN ) ) ) { SetHelpId( HID_SC_REPLCELLSWARN ); } diff --git a/sc/source/ui/pagedlg/tphfedit.cxx b/sc/source/ui/pagedlg/tphfedit.cxx index 9a094d34d2d7..bd592eff4dc2 100644 --- a/sc/source/ui/pagedlg/tphfedit.cxx +++ b/sc/source/ui/pagedlg/tphfedit.cxx @@ -79,7 +79,7 @@ ScEditWindow::ScEditWindow( vcl::Window* pParent, WinBits nBits, ScEditWindowLoc Size aSize( GetOutputSize() ); aSize.Height() *= 4; - pEdEngine = new ScHeaderEditEngine( EditEngine::CreatePool(), true ); + pEdEngine = new ScHeaderEditEngine( EditEngine::CreatePool() ); pEdEngine->SetPaperSize( aSize ); pEdEngine->SetRefDevice( this ); diff --git a/sc/source/ui/undo/undobase.cxx b/sc/source/ui/undo/undobase.cxx index 753f8dbac39a..dfdd563ec162 100644 --- a/sc/source/ui/undo/undobase.cxx +++ b/sc/source/ui/undo/undobase.cxx @@ -305,10 +305,10 @@ void ScBlockUndo::ShowBlock() } ScMultiBlockUndo::ScMultiBlockUndo( - ScDocShell* pDocSh, const ScRangeList& rRanges, ScBlockUndoMode eBlockMode) : + ScDocShell* pDocSh, const ScRangeList& rRanges) : ScSimpleUndo(pDocSh), maBlockRanges(rRanges), - meMode(eBlockMode) + meMode(SC_UNDO_SIMPLE) { mpDrawUndo = GetSdrUndoAction( &pDocShell->GetDocument() ); } diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx index d86d6694de8b..270830de340d 100644 --- a/sc/source/ui/undo/undoblk.cxx +++ b/sc/source/ui/undo/undoblk.cxx @@ -830,7 +830,7 @@ ScUndoPaste::ScUndoPaste( ScDocShell* pNewDocShell, const ScRangeList& rRanges, InsertDeleteFlags nNewFlags, ScRefUndoData* pRefData, bool bRedoIsFilled, const ScUndoPasteOptions* pOptions ) : - ScMultiBlockUndo( pNewDocShell, rRanges, SC_UNDO_SIMPLE ), + ScMultiBlockUndo( pNewDocShell, rRanges ), aMarkData( rMark ), pUndoDoc( pNewUndoDoc ), pRedoDoc( pNewRedoDoc ), diff --git a/sc/source/ui/undo/undoblk2.cxx b/sc/source/ui/undo/undoblk2.cxx index 65012a67f17f..e4319494f534 100644 --- a/sc/source/ui/undo/undoblk2.cxx +++ b/sc/source/ui/undo/undoblk2.cxx @@ -150,7 +150,7 @@ void ScUndoWidthOrHeight::Redo() // SetWidthOrHeight changes current sheet! pViewShell->SetWidthOrHeight( - bWidth, maRanges, eMode, nNewSize, false, true, &aMarkData); + bWidth, maRanges, eMode, nNewSize, false, &aMarkData); } // paint grid if selection was changed directly at the MarkData diff --git a/sc/source/ui/undo/undocell.cxx b/sc/source/ui/undo/undocell.cxx index bacb10db6dee..2dbdb4da0ac0 100644 --- a/sc/source/ui/undo/undocell.cxx +++ b/sc/source/ui/undo/undocell.cxx @@ -70,14 +70,14 @@ namespace HelperNotifyChanges ScUndoCursorAttr::ScUndoCursorAttr( ScDocShell* pNewDocShell, SCCOL nNewCol, SCROW nNewRow, SCTAB nNewTab, const ScPatternAttr* pOldPat, const ScPatternAttr* pNewPat, - const ScPatternAttr* pApplyPat, bool bAutomatic ) : + const ScPatternAttr* pApplyPat ) : ScSimpleUndo( pNewDocShell ), nCol( nNewCol ), nRow( nNewRow ), nTab( nNewTab ), pOldEditData( static_cast<EditTextObject*>(nullptr) ), pNewEditData( static_cast<EditTextObject*>(nullptr) ), - bIsAutomatic( bAutomatic ) + bIsAutomatic( false ) { ScDocumentPool* pPool = pDocShell->GetDocument().GetPool(); pNewPattern = const_cast<ScPatternAttr*>(static_cast<const ScPatternAttr*>( &pPool->Put( *pNewPat ) )); @@ -111,7 +111,7 @@ void ScUndoCursorAttr::DoChange( const ScPatternAttr* pWhichPattern, const share { ScDocument& rDoc = pDocShell->GetDocument(); ScAddress aPos(nCol, nRow, nTab); - rDoc.SetPattern( nCol, nRow, nTab, *pWhichPattern, true ); + rDoc.SetPattern( nCol, nRow, nTab, *pWhichPattern ); if (rDoc.GetCellType(aPos) == CELLTYPE_EDIT && pEditData) rDoc.SetEditText(aPos, *pEditData, nullptr); @@ -255,7 +255,7 @@ void ScUndoEnterData::Undo() { ScPatternAttr aPattern(*rDoc.GetPattern(maPos.Col(), maPos.Row(), rVal.mnTab)); aPattern.GetItemSet().ClearItem( ATTR_VALUE_FORMAT ); - rDoc.SetPattern(maPos.Col(), maPos.Row(), rVal.mnTab, aPattern, true); + rDoc.SetPattern(maPos.Col(), maPos.Row(), rVal.mnTab, aPattern); } pDocShell->PostPaintCell(maPos.Col(), maPos.Row(), rVal.mnTab); } diff --git a/sc/source/ui/undo/undodat.cxx b/sc/source/ui/undo/undodat.cxx index 59c839e36f8e..ad4f4aeeb40d 100644 --- a/sc/source/ui/undo/undodat.cxx +++ b/sc/source/ui/undo/undodat.cxx @@ -1791,8 +1791,7 @@ ScUndoDataForm::ScUndoDataForm( ScDocShell* pNewDocShell, ScDocument* pNewUndoDoc, ScDocument* pNewRedoDoc, InsertDeleteFlags nNewFlags, ScRefUndoData* pRefData, - void* /*pFill1*/, void* /*pFill2*/, void* /*pFill3*/, - bool bRedoIsFilled ) : + void* /*pFill1*/, void* /*pFill2*/, void* /*pFill3*/ ) : ScBlockUndo( pNewDocShell, ScRange( nStartX, nStartY, nStartZ, nEndX, nEndY, nEndZ ), SC_UNDO_SIMPLE ), mpMarkData(new ScMarkData(rMark)), pUndoDoc( pNewUndoDoc ), @@ -1800,7 +1799,7 @@ ScUndoDataForm::ScUndoDataForm( ScDocShell* pNewDocShell, nFlags( nNewFlags ), pRefUndoData( pRefData ), pRefRedoData( nullptr ), - bRedoFilled( bRedoIsFilled ) + bRedoFilled( false ) { // pFill1,pFill2,pFill3 are there so the ctor calls for simple paste (without cutting) // don't have to be changed and branched for 641. diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx index 070514508e5a..2e262b44abfd 100644 --- a/sc/source/ui/unoobj/cellsuno.cxx +++ b/sc/source/ui/unoobj/cellsuno.cxx @@ -2012,7 +2012,7 @@ void SAL_CALL ScCellRangesBase::setPropertyToDefault( const OUString& aPropertyN else if ( pEntry->nWID == SC_WID_UNO_CELLSTYL ) { OUString aStyleName( ScGlobal::GetRscString( STR_STYLENAME_STANDARD ) ); - pDocShell->GetDocFunc().ApplyStyle( *GetMarkData(), aStyleName, true, true ); + pDocShell->GetDocFunc().ApplyStyle( *GetMarkData(), aStyleName, true ); } } } @@ -2293,7 +2293,7 @@ void ScCellRangesBase::SetOnePropertyValue( const SfxItemPropertySimpleEntry* pE if ( nWhich != nFirstItem && nWhich != nSecondItem ) rSet.ClearItem(nWhich); - pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), aPattern, true, true ); + pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), aPattern, true ); } } else // implemented here @@ -2351,7 +2351,7 @@ void ScCellRangesBase::SetOnePropertyValue( const SfxItemPropertySimpleEntry* pE aValue >>= aStrVal; OUString aString(ScStyleNameConversion::ProgrammaticToDisplayName( aStrVal, SFX_STYLE_FAMILY_PARA )); - pDocShell->GetDocFunc().ApplyStyle( *GetMarkData(), aString, true, true ); + pDocShell->GetDocFunc().ApplyStyle( *GetMarkData(), aString, true ); } break; case SC_WID_UNO_TBLBORD: @@ -2452,7 +2452,7 @@ void ScCellRangesBase::SetOnePropertyValue( const SfxItemPropertySimpleEntry* pE ScPatternAttr aPattern( rDoc.GetPool() ); aPattern.GetItemSet().Put( SfxUInt32Item( ATTR_VALIDDATA, nIndex ) ); - pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), aPattern, true, true ); + pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), aPattern, true ); } } } @@ -2751,7 +2751,7 @@ void SAL_CALL ScCellRangesBase::setPropertyValues( const uno::Sequence< OUString } if ( pNewPattern && !aRanges.empty() ) - pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), *pNewPattern, true, true ); + pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), *pNewPattern, true ); } } @@ -2918,7 +2918,7 @@ uno::Sequence< beans::SetPropertyTolerantFailed > SAL_CALL ScCellRangesBase::set } if ( pNewPattern && !aRanges.empty() ) - pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), *pNewPattern, true, true ); + pDocShell->GetDocFunc().ApplyAttributes( *GetMarkData(), *pNewPattern, true ); aReturns.realloc(nFailed); @@ -5455,7 +5455,7 @@ void SAL_CALL ScCellRangeObj::fillSeries( sheet::FillDirection nFillDirection, if (!bError) pDocSh->GetDocFunc().FillSeries( aRange, nullptr, eDir, eCmd, eDateCmd, - MAXDOUBLE, fStep, fEndValue, true, true ); + MAXDOUBLE, fStep, fEndValue, true ); } } @@ -5499,7 +5499,7 @@ void SAL_CALL ScCellRangeObj::fillAuto( sheet::FillDirection nFillDirection, bError = true; if (!bError) - pDocSh->GetDocFunc().FillAuto( aSourceRange, nullptr, eDir, nCount, true, true ); + pDocSh->GetDocFunc().FillAuto( aSourceRange, nullptr, eDir, nCount, true ); } } @@ -5518,7 +5518,7 @@ void SAL_CALL ScCellRangeObj::autoFormat( const OUString& aName ) { ScAutoFormat::const_iterator itBeg = pAutoFormat->begin(); size_t nIndex = std::distance(itBeg, it); - pDocSh->GetDocFunc().AutoFormat(aRange, nullptr, nIndex, true, true); + pDocSh->GetDocFunc().AutoFormat(aRange, nullptr, nIndex, true); } else throw lang::IllegalArgumentException(); @@ -5925,7 +5925,7 @@ void SAL_CALL ScCellRangeObj::doImport( const uno::Sequence<beans::PropertyValue pDocSh->GetDBData( aRange, SC_DB_MAKE, SC_DBSEL_FORCE_MARK ); // ggf. Bereich anlegen ScDBDocFunc aFunc(*pDocSh); // Bereich muss angelegt sein - aFunc.DoImport( nTab, aParam, nullptr, true ); //! Api-Flag as parameter + aFunc.DoImport( nTab, aParam, nullptr ); //! Api-Flag as parameter } } @@ -6242,7 +6242,7 @@ void ScCellObj::InputEnglishString( const OUString& rText ) ScPatternAttr aPattern( rDoc.GetPool() ); aPattern.GetItemSet().Put( SfxUInt32Item( ATTR_VALUE_FORMAT, nNewFormat ) ); // ATTR_LANGUAGE_FORMAT remains unchanged - rFunc.ApplyAttributes( *GetMarkData(), aPattern, true, true ); + rFunc.ApplyAttributes( *GetMarkData(), aPattern, true ); } } } @@ -7242,7 +7242,7 @@ void SAL_CALL ScTableSheetObj::removeRange( const table::CellRangeAddress& rRang OSL_ENSURE( rRangeAddress.Sheet == GetTab_Impl(), "falsche Tabelle in CellRangeAddress" ); ScRange aScRange; ScUnoConversion::FillScRange( aScRange, rRangeAddress ); - pDocSh->GetDocFunc().DeleteCells( aScRange, nullptr, eCmd, true, true ); + pDocSh->GetDocFunc().DeleteCells( aScRange, nullptr, eCmd, true ); } } } @@ -8009,7 +8009,7 @@ void SAL_CALL ScTableSheetObj::addRanges( const uno::Sequence<table::CellRangeAd ScPatternAttr aPattern( rDoc.GetPool() ); aPattern.GetItemSet().Put( ScMergeFlagAttr( SC_MF_SCENARIO ) ); aPattern.GetItemSet().Put( ScProtectionAttr( true ) ); - pDocSh->GetDocFunc().ApplyAttributes( aMarkData, aPattern, true, true ); + pDocSh->GetDocFunc().ApplyAttributes( aMarkData, aPattern, true ); } } } diff --git a/sc/source/ui/unoobj/datauno.cxx b/sc/source/ui/unoobj/datauno.cxx index ba4858f10903..342f956e371a 100644 --- a/sc/source/ui/unoobj/datauno.cxx +++ b/sc/source/ui/unoobj/datauno.cxx @@ -1915,12 +1915,12 @@ void SAL_CALL ScDatabaseRangeObj::refresh() throw(uno::RuntimeException, std::ex SCCOL nDummyCol; SCROW nDummyRow; pData->GetArea( nTab, nDummyCol,nDummyRow,nDummyCol,nDummyRow ); - bContinue = aFunc.DoImport( nTab, aImportParam, nullptr, true ); //! Api-Flag as parameter + bContinue = aFunc.DoImport( nTab, aImportParam, nullptr ); //! Api-Flag as parameter } // interne Operationen (sort, query, subtotal) nur, wenn kein Fehler if (bContinue) - aFunc.RepeatDB( pData->GetName(), true, true, bIsUnnamed, aTab ); + aFunc.RepeatDB( pData->GetName(), true, bIsUnnamed, aTab ); } } diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 4e12fe8fbd08..ead7061e9108 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -3568,7 +3568,7 @@ void SAL_CALL ScTableColumnsObj::removeByIndex( sal_Int32 nIndex, sal_Int32 nCou { ScRange aRange( (SCCOL)(nStartCol+nIndex), 0, nTab, (SCCOL)(nStartCol+nIndex+nCount-1), MAXROW, nTab ); - bDone = pDocShell->GetDocFunc().DeleteCells( aRange, nullptr, DEL_DELCOLS, true, true ); + bDone = pDocShell->GetDocFunc().DeleteCells( aRange, nullptr, DEL_DELCOLS, true ); } if (!bDone) throw uno::RuntimeException(); // no other exceptions specified @@ -3825,7 +3825,7 @@ void SAL_CALL ScTableRowsObj::removeByIndex( sal_Int32 nIndex, sal_Int32 nCount { ScRange aRange( 0, (SCROW)(nStartRow+nIndex), nTab, MAXCOL, (SCROW)(nStartRow+nIndex+nCount-1), nTab ); - bDone = pDocShell->GetDocFunc().DeleteCells( aRange, nullptr, DEL_DELROWS, true, true ); + bDone = pDocShell->GetDocFunc().DeleteCells( aRange, nullptr, DEL_DELROWS, true ); } if (!bDone) throw uno::RuntimeException(); // no other exceptions specified diff --git a/sc/source/ui/unoobj/textuno.cxx b/sc/source/ui/unoobj/textuno.cxx index f960d87c3e70..b5bdc0c05cda 100644 --- a/sc/source/ui/unoobj/textuno.cxx +++ b/sc/source/ui/unoobj/textuno.cxx @@ -206,7 +206,7 @@ SvxTextForwarder* ScHeaderFooterTextData::GetTextForwarder() { SfxItemPool* pEnginePool = EditEngine::CreatePool(); pEnginePool->FreezeIdRanges(); - ScHeaderEditEngine* pHdrEngine = new ScHeaderEditEngine( pEnginePool, true ); + ScHeaderEditEngine* pHdrEngine = new ScHeaderEditEngine( pEnginePool ); pHdrEngine->EnableUndo( false ); pHdrEngine->SetRefMapMode( MAP_TWIP ); @@ -337,7 +337,7 @@ OUString SAL_CALL ScHeaderFooterTextObj::getString() throw(uno::RuntimeException if (pData) { // for pure text, no font info is needed in pool defaults - ScHeaderEditEngine aEditEngine( EditEngine::CreatePool(), true ); + ScHeaderEditEngine aEditEngine( EditEngine::CreatePool() ); ScHeaderFieldData aData; FillDummyFieldData( aData ); @@ -355,7 +355,7 @@ void SAL_CALL ScHeaderFooterTextObj::setString( const OUString& aText ) throw(un OUString aString(aText); // for pure text, no font info is needed in pool defaults - ScHeaderEditEngine aEditEngine(EditEngine::CreatePool(), true); + ScHeaderEditEngine aEditEngine(EditEngine::CreatePool()); aEditEngine.SetText( aString ); aTextData.UpdateData(aEditEngine); } diff --git a/sc/source/ui/unoobj/viewuno.cxx b/sc/source/ui/unoobj/viewuno.cxx index f029710f9379..1a17d1a67a7b 100644 --- a/sc/source/ui/unoobj/viewuno.cxx +++ b/sc/source/ui/unoobj/viewuno.cxx @@ -1655,7 +1655,7 @@ void SAL_CALL ScTabViewObj::splitAtPosition( sal_Int32 nPixelX, sal_Int32 nPixel ScTabViewShell* pViewSh = GetViewShell(); if (pViewSh) { - pViewSh->SplitAtPixel( Point( nPixelX, nPixelY ), true, true ); + pViewSh->SplitAtPixel( Point( nPixelX, nPixelY ) ); pViewSh->FreezeSplitters( false ); pViewSh->InvalidateSplit(); } @@ -1681,7 +1681,7 @@ void SAL_CALL ScTabViewObj::freezeAtPosition( sal_Int32 nColumns, sal_Int32 nRow Point aSplit(rViewData.GetScrPos( (SCCOL)nColumns, (SCROW)nRows, SC_SPLIT_BOTTOMLEFT, true )); aSplit += aWinStart; - pViewSh->SplitAtPixel( aSplit, true, true ); + pViewSh->SplitAtPixel( aSplit ); pViewSh->FreezeSplitters( true ); pViewSh->InvalidateSplit(); } diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx index 16962802327f..0d21f00b8b33 100644 --- a/sc/source/ui/vba/vbarange.cxx +++ b/sc/source/ui/vba/vbarange.cxx @@ -1631,7 +1631,7 @@ ScVbaRange::ClearFormats() throw (uno::RuntimeException, std::exception) } void -ScVbaRange::setFormulaValue( const uno::Any& rFormula, formula::FormulaGrammar::Grammar eGram, bool bFireEvent ) throw (uno::RuntimeException) +ScVbaRange::setFormulaValue( const uno::Any& rFormula, formula::FormulaGrammar::Grammar eGram ) throw (uno::RuntimeException) { // If this is a multiple selection apply setFormula over all areas if ( m_Areas->getCount() > 1 ) @@ -1642,7 +1642,7 @@ ScVbaRange::setFormulaValue( const uno::Any& rFormula, formula::FormulaGrammar:: return; } CellFormulaValueSetter formulaValueSetter( rFormula, &getScDocument(), eGram ); - setValue( rFormula, formulaValueSetter, bFireEvent ); + setValue( rFormula, formulaValueSetter, true/*bFireEvent*/ ); } uno::Any @@ -1666,7 +1666,7 @@ void ScVbaRange::setFormula(const uno::Any &rFormula ) throw (uno::RuntimeException, std::exception) { // #FIXME converting "=$a$1" e.g. CONV_XL_A1 -> CONV_OOO // results in "=$a$1:a1", temporalily disable conversion - setFormulaValue( rFormula,formula::FormulaGrammar::GRAM_NATIVE_XL_A1, true ); + setFormulaValue( rFormula,formula::FormulaGrammar::GRAM_NATIVE_XL_A1 ); } uno::Any @@ -1678,7 +1678,7 @@ ScVbaRange::getFormulaR1C1() throw (css::uno::RuntimeException, std::exception) void ScVbaRange::setFormulaR1C1(const uno::Any& rFormula ) throw (uno::RuntimeException, std::exception) { - setFormulaValue( rFormula,formula::FormulaGrammar::GRAM_NATIVE_XL_R1C1, true ); + setFormulaValue( rFormula,formula::FormulaGrammar::GRAM_NATIVE_XL_R1C1 ); } uno::Any diff --git a/sc/source/ui/vba/vbarange.hxx b/sc/source/ui/vba/vbarange.hxx index ee715cfa4e0b..9c134c237b01 100644 --- a/sc/source/ui/vba/vbarange.hxx +++ b/sc/source/ui/vba/vbarange.hxx @@ -101,7 +101,7 @@ class ScVbaRange : public ScVbaRange_BASE void setValue( const css::uno::Any& aValue, ValueSetter& setter, bool bFireEvent ) throw ( css::uno::RuntimeException); css::uno::Any getFormulaValue( formula::FormulaGrammar::Grammar ) throw (css::uno::RuntimeException); - void setFormulaValue( const css::uno::Any& aValue, formula::FormulaGrammar::Grammar, bool bFireEvent ) throw ( css::uno::RuntimeException); + void setFormulaValue( const css::uno::Any& aValue, formula::FormulaGrammar::Grammar ) throw ( css::uno::RuntimeException); css::uno::Reference< ov::excel::XRange > getArea( sal_Int32 nIndex ) throw( css::uno::RuntimeException ); ScCellRangeObj* getCellRangeObj( ) throw ( css::uno::RuntimeException ); diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx index a372a52e7d8b..b97450bf8db7 100644 --- a/sc/source/ui/view/cellsh1.cxx +++ b/sc/source/ui/view/cellsh1.cxx @@ -482,7 +482,6 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq ) OSL_ENSURE(pFact, "ScAbstractFactory create fail!"); std::unique_ptr<AbstractScInsertContentsDlg> pDlg(pFact->CreateScInsertContentsDlg( pTabViewShell->GetDialogParent(), - InsertDeleteFlags::NONE, /* nCheckDefaults */ &ScGlobal::GetRscString(STR_FILL_TAB))); OSL_ENSURE(pDlg, "Dialog create fail!"); pDlg->SetFillMode(true); diff --git a/sc/source/ui/view/cellsh3.cxx b/sc/source/ui/view/cellsh3.cxx index ff6822f6b576..e85e70a68abc 100644 --- a/sc/source/ui/view/cellsh3.cxx +++ b/sc/source/ui/view/cellsh3.cxx @@ -749,7 +749,7 @@ void ScCellShell::Execute( SfxRequest& rReq ) bMoveContents = static_cast<const SfxBoolItem*>(pItem)->GetValue(); } - if (pTabViewShell->MergeCells( bApi, bMoveContents, true, bCenter )) + if (pTabViewShell->MergeCells( bApi, bMoveContents, bCenter )) { if (!bApi && bMoveContents) // "yes" clicked in dialog rReq.AppendItem( SfxBoolItem( nSlot, bMoveContents ) ); diff --git a/sc/source/ui/view/dbfunc.cxx b/sc/source/ui/view/dbfunc.cxx index faf6cabad06f..1e6aa67d4188 100644 --- a/sc/source/ui/view/dbfunc.cxx +++ b/sc/source/ui/view/dbfunc.cxx @@ -451,7 +451,7 @@ bool ScDBFunc::ImportData( const ScImportParam& rParam ) } ScDBDocFunc aDBDocFunc( *GetViewData().GetDocShell() ); - return aDBDocFunc.DoImport( GetViewData().GetTabNo(), rParam, nullptr, true/*bRecord*/ ); + return aDBDocFunc.DoImport( GetViewData().GetTabNo(), rParam, nullptr ); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx index 886b8cbde8cd..4e90c19531bf 100644 --- a/sc/source/ui/view/dbfunc3.cxx +++ b/sc/source/ui/view/dbfunc3.cxx @@ -207,13 +207,13 @@ void ScDBFunc::AutoOutline( ) // select outline level -void ScDBFunc::SelectLevel( bool bColumns, sal_uInt16 nLevel, bool bRecord, bool bPaint ) +void ScDBFunc::SelectLevel( bool bColumns, sal_uInt16 nLevel, bool bRecord ) { SCTAB nTab = GetViewData().GetTabNo(); ScDocShell* pDocSh = GetViewData().GetDocShell(); ScOutlineDocFunc aFunc(*pDocSh); - bool bOk = aFunc.SelectLevel( nTab, bColumns, nLevel, bRecord, bPaint ); + bool bOk = aFunc.SelectLevel( nTab, bColumns, nLevel, bRecord, true/*bPaint*/ ); if (bOk) UpdateScrollBars(); diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index d74fb713abc0..39c03f82e8f1 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -237,7 +237,6 @@ public: bool IsInInit() const { return bInit; } void SetCancelled() { bCancelled = true; } bool IsInSelect() const { return bInSelect; } - void SetListHasDates(bool b) { mbListHasDates = b; } bool HasDates() const { return mbListHasDates; } }; @@ -737,7 +736,7 @@ void ScGridWindow::LaunchAutoFilterMenu(SCCOL nCol, SCROW nRow) // Populate the check box list. bool bHasDates = false; std::vector<ScTypedStrData> aStrings; - pDoc->GetFilterEntries(nCol, nRow, nTab, true, aStrings, bHasDates); + pDoc->GetFilterEntries(nCol, nRow, nTab, aStrings, bHasDates); mpAutoFilterPopup->setMemberSize(aStrings.size()); std::vector<ScTypedStrData>::const_iterator it = aStrings.begin(), itEnd = aStrings.end(); @@ -757,20 +756,20 @@ void ScGridWindow::LaunchAutoFilterMenu(SCCOL nCol, SCROW nRow) // Populate the menu. mpAutoFilterPopup->addMenuItem( SC_STRLOAD(RID_POPUP_FILTER, STR_MENU_SORT_ASC), - true, new AutoFilterAction(this, SortAscending)); + new AutoFilterAction(this, SortAscending)); mpAutoFilterPopup->addMenuItem( SC_STRLOAD(RID_POPUP_FILTER, STR_MENU_SORT_DESC), - true, new AutoFilterAction(this, SortDescending)); + new AutoFilterAction(this, SortDescending)); mpAutoFilterPopup->addSeparator(); mpAutoFilterPopup->addMenuItem( - SC_RESSTR(SCSTR_TOP10FILTER), true, new AutoFilterAction(this, Top10)); + SC_RESSTR(SCSTR_TOP10FILTER), new AutoFilterAction(this, Top10)); mpAutoFilterPopup->addMenuItem( - SC_RESSTR(SCSTR_FILTER_EMPTY), true, new AutoFilterAction(this, Empty)); + SC_RESSTR(SCSTR_FILTER_EMPTY), new AutoFilterAction(this, Empty)); mpAutoFilterPopup->addMenuItem( - SC_RESSTR(SCSTR_FILTER_NOTEMPTY), true, new AutoFilterAction(this, NonEmpty)); + SC_RESSTR(SCSTR_FILTER_NOTEMPTY), new AutoFilterAction(this, NonEmpty)); mpAutoFilterPopup->addSeparator(); mpAutoFilterPopup->addMenuItem( - SC_RESSTR(SCSTR_STDFILTER), true, new AutoFilterAction(this, Custom)); + SC_RESSTR(SCSTR_STDFILTER), new AutoFilterAction(this, Custom)); ScCheckListMenuWindow::Config aConfig; aConfig.mbAllowEmptySet = false; @@ -1092,12 +1091,11 @@ void ScGridWindow::DoScenarioMenu( const ScRange& rScenRange ) CaptureMouse(); } -void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelect ) +void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow ) { mpFilterBox.disposeAndClear(); mpFilterFloat.disposeAndClear(); - sal_uInt16 i; ScDocument* pDoc = pViewData->GetDocument(); SCTAB nTab = pViewData->GetTabNo(); bool bLayoutRTL = pDoc->IsLayoutRTL( nTab ); @@ -1117,7 +1115,7 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec mpFilterFloat.reset(VclPtr<ScFilterFloatingWindow>::Create(this, WinBits(WB_BORDER))); mpFilterFloat->SetPopupModeEndHdl(LINK( this, ScGridWindow, PopupModeEndHdl)); - ScFilterBoxMode eFilterMode = bDataSelect ? SC_FILTERBOX_DATASELECT : SC_FILTERBOX_FILTER; + ScFilterBoxMode eFilterMode = SC_FILTERBOX_DATASELECT; mpFilterBox.reset(VclPtr<ScFilterListBox>::Create(mpFilterFloat.get(), this, nCol, nRow, eFilterMode)); // Fix for bug fdo#44925 if (AllSettings::GetLayoutRTL() != bLayoutRTL) @@ -1142,62 +1140,10 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec bool bEmpty = false; std::vector<ScTypedStrData> aStrings; // case sensitive - if ( bDataSelect ) // selection List - { - // Fill List - pDoc->GetDataEntries(nCol, nRow, nTab, true, aStrings); - if (aStrings.empty()) - bEmpty = true; - } - else // AutoFilter - { - //! Will the Titel be evaluated ??? - OUString aString = pDoc->GetString(nCol, nRow, nTab); - mpFilterBox->SetText(aString); - - long nMaxText = 0; - - // default entries - static const sal_uInt16 nDefIDs[] = { SCSTR_TOP10FILTER, SCSTR_STDFILTER, SCSTR_FILTER_EMPTY, SCSTR_FILTER_NOTEMPTY }; - const size_t nDefCount = SAL_N_ELEMENTS(nDefIDs); - for (i=0; i<nDefCount; i++) - { - OUString aEntry( static_cast<ScResId>(nDefIDs[i]) ); - mpFilterBox->InsertEntry(aEntry); - long nTextWidth = mpFilterBox->GetTextWidth(aEntry); - if ( nTextWidth > nMaxText ) - nMaxText = nTextWidth; - } - mpFilterBox->SetSeparatorPos(nDefCount - 1); - - // get list entries - bool bHasDates = false; - pDoc->GetFilterEntries( nCol, nRow, nTab, true, aStrings, bHasDates); - mpFilterBox->SetListHasDates(bHasDates); - - // check widths of numerical entries (string entries are not included) - // so all numbers are completely visible - std::vector<ScTypedStrData>::const_iterator it = aStrings.begin(), itEnd = aStrings.end(); - for (; it != itEnd; ++it) - { - if (!it->IsStrData()) // only numerical entries - { - long nTextWidth = mpFilterBox->GetTextWidth(it->GetString()); - if ( nTextWidth > nMaxText ) - nMaxText = nTextWidth; - } - } - - // add scrollbar width if needed (string entries are counted here) - // (scrollbar is shown if the box is exactly full?) - if (aStrings.size() + nDefCount >= SC_FILTERLISTBOX_LINES) - nMaxText += GetSettings().GetStyleSettings().GetScrollBarSize(); - - nMaxText += 4; // for borders - - if ( nMaxText > nSizeX ) - nSizeX = nMaxText; // just modify width - starting position is unchanged - } + // Fill List + pDoc->GetDataEntries(nCol, nRow, nTab, true, aStrings); + if (aStrings.empty()) + bEmpty = true; if (!bEmpty) { @@ -1237,95 +1183,47 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec sal_Int32 nSelPos = LISTBOX_ENTRY_NOTFOUND; - if (!bDataSelect) // AutoFilter: Select active entry - { - ScDBData* pDBData = pDoc->GetDBAtCursor( nCol, nRow, nTab, ScDBDataPortion::AREA ); - if (pDBData) - { - ScQueryParam aParam; - pDBData->GetQueryParam( aParam ); // Can only result in MAXQUERY entries - - bool bValid = true; - SCSIZE nCount = aParam.GetEntryCount(); - for (SCSIZE j = 0; j < nCount && bValid; ++j) // Current Filter settings - if (aParam.GetEntry(j).bDoQuery) - { - //! Summarises DrawButtons queries! - - ScQueryEntry& rEntry = aParam.GetEntry(j); - if (j>0) - if (rEntry.eConnect != SC_AND) - bValid = false; - if (rEntry.nField == nCol) - { - OUString aQueryStr = rEntry.GetQueryItem().maString.getString(); - if (rEntry.eOp == SC_EQUAL) - { - if (!aQueryStr.isEmpty()) - { - nSelPos = mpFilterBox->GetEntryPos(aQueryStr); - } - } - else if ( rEntry.eOp == SC_TOPVAL && aQueryStr == "10" ) - nSelPos = SC_AUTOFILTER_TOP10; - else - nSelPos = SC_AUTOFILTER_CUSTOM; - } - } - - if (!bValid) - nSelPos = SC_AUTOFILTER_CUSTOM; - } - } - else + sal_uLong nIndex = static_cast<const SfxUInt32Item*>(pDoc->GetAttr( + nCol, nRow, nTab, ATTR_VALIDDATA ))->GetValue(); + if ( nIndex ) { - - sal_uLong nIndex = static_cast<const SfxUInt32Item*>(pDoc->GetAttr( - nCol, nRow, nTab, ATTR_VALIDDATA ))->GetValue(); - if ( nIndex ) + const ScValidationData* pData = pDoc->GetValidationEntry( nIndex ); + if (pData) { - const ScValidationData* pData = pDoc->GetValidationEntry( nIndex ); - if (pData) + std::unique_ptr<ScTypedStrData> pNew; + OUString aDocStr = pDoc->GetString(nCol, nRow, nTab); + if ( pDoc->HasValueData( nCol, nRow, nTab ) ) { - std::unique_ptr<ScTypedStrData> pNew; - OUString aDocStr = pDoc->GetString(nCol, nRow, nTab); - if ( pDoc->HasValueData( nCol, nRow, nTab ) ) - { - double fVal = pDoc->GetValue(ScAddress(nCol, nRow, nTab)); - pNew.reset(new ScTypedStrData(aDocStr, fVal, ScTypedStrData::Value)); - } - else - pNew.reset(new ScTypedStrData(aDocStr, 0.0, ScTypedStrData::Standard)); + double fVal = pDoc->GetValue(ScAddress(nCol, nRow, nTab)); + pNew.reset(new ScTypedStrData(aDocStr, fVal, ScTypedStrData::Value)); + } + else + pNew.reset(new ScTypedStrData(aDocStr, 0.0, ScTypedStrData::Standard)); - bool bSortList = ( pData->GetListType() == css::sheet::TableValidationVisibility::SORTEDASCENDING); - if ( bSortList ) + bool bSortList = ( pData->GetListType() == css::sheet::TableValidationVisibility::SORTEDASCENDING); + if ( bSortList ) + { + std::vector<ScTypedStrData>::const_iterator itBeg = aStrings.begin(), itEnd = aStrings.end(); + std::vector<ScTypedStrData>::const_iterator it = + std::find_if(itBeg, itEnd, FindTypedStrData(*pNew, true)); + if (it != itEnd) + // Found! + nSelPos = std::distance(itBeg, it); + } + else + { + ScTypedStrData::EqualCaseSensitive aHdl; + std::vector<ScTypedStrData>::const_iterator itBeg = aStrings.begin(), itEnd = aStrings.end(); + std::vector<ScTypedStrData>::const_iterator it = itBeg; + for (; it != itEnd && LISTBOX_ENTRY_NOTFOUND == nSelPos; ++it) { - std::vector<ScTypedStrData>::const_iterator itBeg = aStrings.begin(), itEnd = aStrings.end(); - std::vector<ScTypedStrData>::const_iterator it = - std::find_if(itBeg, itEnd, FindTypedStrData(*pNew, true)); - if (it != itEnd) - // Found! + if (aHdl(*it, *pNew)) nSelPos = std::distance(itBeg, it); } - else - { - ScTypedStrData::EqualCaseSensitive aHdl; - std::vector<ScTypedStrData>::const_iterator itBeg = aStrings.begin(), itEnd = aStrings.end(); - std::vector<ScTypedStrData>::const_iterator it = itBeg; - for (; it != itEnd && LISTBOX_ENTRY_NOTFOUND == nSelPos; ++it) - { - if (aHdl(*it, *pNew)) - nSelPos = std::distance(itBeg, it); - } - } } } } - // new (309): Something must always be selected - if (LISTBOX_ENTRY_NOTFOUND == nSelPos && mpFilterBox->GetEntryCount() > 0 && !bDataSelect) - nSelPos = 0; - // Do not show an empty selection List: if ( bEmpty ) @@ -1342,19 +1240,10 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec mpFilterBox->SelectEntryPos(nSelPos); else { - if (bDataSelect) - mpFilterBox->SetNoSelection(); + mpFilterBox->SetNoSelection(); } mpFilterBox->EndInit(); - - if (!bDataSelect) - { - // AutoFilter (from MouseButtonDown): - // The next MouseMove on the FilterBox is like a ButtonDown - nMouseStatus = SC_GM_FILTER; - CaptureMouse(); - } } } @@ -2019,7 +1908,7 @@ void ScGridWindow::HandleMouseButtonDown( const MouseEvent& rMEvt, MouseEventSta Rectangle aButtonRect = GetListValButtonRect( aListValPos ); if ( aButtonRect.IsInside( aPos ) ) { - LaunchDataSelectMenu( aListValPos.Col(), aListValPos.Row(), true ); + LaunchDataSelectMenu( aListValPos.Col(), aListValPos.Row() ); nMouseStatus = SC_GM_FILTER; // not set in DoAutoFilterMenue for bDataSelect CaptureMouse(); @@ -2265,7 +2154,7 @@ void ScGridWindow::MouseButtonUp( const MouseEvent& rMEvt ) if ( aEndPos != aBlockRange.aEnd ) { - pViewData->GetDocShell()->GetDocFunc().ResizeMatrix( aBlockRange, aEndPos, false ); + pViewData->GetDocShell()->GetDocFunc().ResizeMatrix( aBlockRange, aEndPos ); pViewData->GetView()->MarkRange( ScRange( aBlockRange.aStart, aEndPos ) ); } } @@ -3012,7 +2901,7 @@ void ScGridWindow::Command( const CommandEvent& rCEvt ) ScInputHandler* pHdl = pScMod->GetInputHdl( pViewData->GetViewShell() ); if ( pHdl ) { - pHdl->InputCommand( rCEvt, true ); + pHdl->InputCommand( rCEvt ); return; // done } @@ -4287,13 +4176,11 @@ sal_Int8 ScGridWindow::DropTransferObj( ScTransferObj* pTransObj, SCCOL nDestPos { if ( bIsLink ) { - // call with bApi = sal_True to avoid error messages in drop handler - bDone = pView->LinkBlock( aSource, aDest.aStart, true /*bApi*/ ); + bDone = pView->LinkBlock( aSource, aDest.aStart ); } else { - // call with bApi = sal_True to avoid error messages in drop handler - bDone = pView->MoveBlockTo( aSource, aDest.aStart, bIsMove, true /*bRecord*/, true /*bPaint*/, true /*bApi*/ ); + bDone = pView->MoveBlockTo( aSource, aDest.aStart, bIsMove ); } } @@ -4313,7 +4200,7 @@ sal_Int8 ScGridWindow::DropTransferObj( ScTransferObj* pTransObj, SCCOL nDestPos ( eCmd == DEL_CELLSLEFT && nDestPosY == aSource.aStart.Row() ) ) { // call with bApi = sal_True to avoid error messages in drop handler - bDone = pDocSh->GetDocFunc().DeleteCells( aSource, nullptr, eCmd, true /*bRecord*/, true /*bApi*/ ); + bDone = pDocSh->GetDocFunc().DeleteCells( aSource, nullptr, eCmd, true /*bApi*/ ); if ( bDone ) { if ( eCmd == DEL_CELLSUP && nDestPosY > aSource.aEnd.Row() ) @@ -4529,7 +4416,7 @@ sal_Int8 ScGridWindow::ExecuteDrop( const ExecuteDropEvent& rEvt ) pView->MoveCursorAbs( nPosX, nPosY, SC_FOLLOW_NONE, false, false ); pView->InsertAreaLink( rData.aLinkDoc, EMPTY_OUSTRING, EMPTY_OUSTRING, - rData.aLinkArea, 0 ); + rData.aLinkArea ); } else { diff --git a/sc/source/ui/view/gridwin2.cxx b/sc/source/ui/view/gridwin2.cxx index 2ee209254548..3b829ad0aeba 100644 --- a/sc/source/ui/view/gridwin2.cxx +++ b/sc/source/ui/view/gridwin2.cxx @@ -494,10 +494,10 @@ void ScGridWindow::DPLaunchFieldPopupMenu( // Populate the menus. ScTabViewShell* pViewShell = pViewData->GetViewShell(); mpDPFieldPopup->addMenuItem( - SC_STRLOAD(RID_POPUP_FILTER, STR_MENU_SORT_ASC), true, + SC_STRLOAD(RID_POPUP_FILTER, STR_MENU_SORT_ASC), new PopupSortAction(rPos, PopupSortAction::ASCENDING, 0, pViewShell)); mpDPFieldPopup->addMenuItem( - SC_STRLOAD(RID_POPUP_FILTER, STR_MENU_SORT_DESC), true, + SC_STRLOAD(RID_POPUP_FILTER, STR_MENU_SORT_DESC), new PopupSortAction(rPos, PopupSortAction::DESCENDING, 0, pViewShell)); ScMenuFloatingWindow* pSubMenu = mpDPFieldPopup->addSubMenuItem( SC_STRLOAD(RID_POPUP_FILTER, STR_MENU_SORT_CUSTOM), !aUserSortNames.empty()); @@ -508,7 +508,7 @@ void ScGridWindow::DPLaunchFieldPopupMenu( for (size_t i = 0; i < n; ++i) { pSubMenu->addMenuItem( - aUserSortNames[i], true, + aUserSortNames[i], new PopupSortAction(rPos, PopupSortAction::CUSTOM, static_cast<sal_uInt16>(i), pViewShell)); } } diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx index 95b6dfea8b66..71ad2e55a8be 100644 --- a/sc/source/ui/view/gridwin4.cxx +++ b/sc/source/ui/view/gridwin4.cxx @@ -138,7 +138,7 @@ static void lcl_DrawOneFrame( vcl::RenderContext* pDev, const Rectangle& rInnerP long nBHeight = nVer + aTextSize.Height() + 1; Size aButSize( nBWidth, nBHeight ); long nButtonPos = bLayoutRTL ? aOuter.Left() : aOuter.Right()-nBWidth+1; - aComboButton.Draw( Point(nButtonPos, nButtonY), aButSize, false ); + aComboButton.Draw( Point(nButtonPos, nButtonY), aButSize ); if (pButtonViewData) pButtonViewData->SetScenButSize( aButSize ); diff --git a/sc/source/ui/view/olinewin.cxx b/sc/source/ui/view/olinewin.cxx index bf2e3910477e..721f7285d68b 100644 --- a/sc/source/ui/view/olinewin.cxx +++ b/sc/source/ui/view/olinewin.cxx @@ -838,7 +838,7 @@ bool ScOutlineWindow::ImplMoveFocusByLevel( bool bForward ) return bWrapped; } -bool ScOutlineWindow::ImplMoveFocusByTabOrder( bool bForward, bool bFindVisible ) +bool ScOutlineWindow::ImplMoveFocusByTabOrder( bool bForward ) { bool bRet = false; size_t nOldLevel = mnFocusLevel; @@ -858,7 +858,7 @@ bool ScOutlineWindow::ImplMoveFocusByTabOrder( bool bForward, bool bFindVisible if ( bForward && bWrapInLevel ) bRet |= ImplMoveFocusByLevel( bForward ); } - while ( bFindVisible && !IsFocusButtonVisible() && ((nOldLevel != mnFocusLevel) || (nOldEntry != mnFocusEntry)) ); + while ( !IsFocusButtonVisible() && ((nOldLevel != mnFocusLevel) || (nOldEntry != mnFocusEntry)) ); return bRet; } @@ -870,7 +870,7 @@ void ScOutlineWindow::ImplMoveFocusToVisible( bool bForward ) ImplMoveFocusByEntry( bForward, true ); // then try to find any other entry if ( !IsFocusButtonVisible() ) - ImplMoveFocusByTabOrder( bForward, true ); + ImplMoveFocusByTabOrder( bForward ); } void ScOutlineWindow::MoveFocusByEntry( bool bForward ) @@ -890,7 +890,7 @@ void ScOutlineWindow::MoveFocusByLevel( bool bForward ) void ScOutlineWindow::MoveFocusByTabOrder( bool bForward ) { HideFocus(); - ImplMoveFocusByTabOrder( bForward, true ); + ImplMoveFocusByTabOrder( bForward ); ShowFocus(); } diff --git a/sc/source/ui/view/printfun.cxx b/sc/source/ui/view/printfun.cxx index 439a5b8375cd..f9bfa0127e02 100644 --- a/sc/source/ui/view/printfun.cxx +++ b/sc/source/ui/view/printfun.cxx @@ -1665,7 +1665,7 @@ void ScPrintFunc::MakeEditEngine() { // can't use document's edit engine pool here, // because pool must have twips as default metric - pEditEngine = new ScHeaderEditEngine( EditEngine::CreatePool(), true ); + pEditEngine = new ScHeaderEditEngine( EditEngine::CreatePool() ); pEditEngine->EnableUndo(false); //fdo#45869 we want text to be positioned as it would be for the diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx index 9f5d69928057..1b015d9c37a1 100644 --- a/sc/source/ui/view/tabview.cxx +++ b/sc/source/ui/view/tabview.cxx @@ -2108,24 +2108,18 @@ void ScTabView::SplitAtCursor() RepeatResize(); } -void ScTabView::SplitAtPixel( const Point& rPixel, bool bHor, bool bVer ) +void ScTabView::SplitAtPixel( const Point& rPixel ) { // pixel is relative to the entire View, not to the first GridWin - if (bHor) - { - if ( rPixel.X() > 0 ) - DoHSplit( rPixel.X() ); - else - DoHSplit( 0 ); - } - if (bVer) - { - if ( rPixel.Y() > 0 ) - DoVSplit( rPixel.Y() ); - else - DoVSplit( 0 ); - } + if ( rPixel.X() > 0 ) + DoHSplit( rPixel.X() ); + else + DoHSplit( 0 ); + if ( rPixel.Y() > 0 ) + DoVSplit( rPixel.Y() ); + else + DoVSplit( 0 ); RepeatResize(); } @@ -2234,7 +2228,7 @@ void ScTabView::StartDataSelect() if (pAttr->HasAutoFilter()) pWin->LaunchAutoFilterMenu(nCol, nRow); else - pWin->LaunchDataSelectMenu(nCol, nRow, true); + pWin->LaunchDataSelectMenu(nCol, nRow); } void ScTabView::EnableRefInput(bool bFlag) diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx index 74cf5a315475..c7b7b2e39843 100644 --- a/sc/source/ui/view/viewdata.cxx +++ b/sc/source/ui/view/viewdata.cxx @@ -1744,7 +1744,7 @@ bool ScViewData::GetMergeSizePixel( SCCOL nX, SCROW nY, long& rSizeXPix, long& r void ScViewData::GetPosFromPixel( long nClickX, long nClickY, ScSplitPos eWhich, SCsCOL& rPosX, SCsROW& rPosY, - bool bTestMerge, bool bRepair, bool bNextIfLarge ) + bool bTestMerge, bool bRepair ) { // special handling of 0 is now in ScViewFunctionSet::SetCursorAtPoint @@ -1796,22 +1796,20 @@ void ScViewData::GetPosFromPixel( long nClickX, long nClickY, ScSplitPos eWhich, } } - if (bNextIfLarge) // cells to big? + // cells to big? + if ( rPosX == nStartPosX && nClickX > 0 ) { - if ( rPosX == nStartPosX && nClickX > 0 ) - { - if (pView) - aScrSize.Width() = pView->GetGridWidth(eHWhich); - if ( nClickX > aScrSize.Width() ) - ++rPosX; - } - if ( rPosY == nStartPosY && nClickY > 0 ) - { - if (pView) - aScrSize.Height() = pView->GetGridHeight(eVWhich); - if ( nClickY > aScrSize.Height() ) - ++rPosY; - } + if (pView) + aScrSize.Width() = pView->GetGridWidth(eHWhich); + if ( nClickX > aScrSize.Width() ) + ++rPosX; + } + if ( rPosY == nStartPosY && nClickY > 0 ) + { + if (pView) + aScrSize.Height() = pView->GetGridHeight(eVWhich); + if ( nClickY > aScrSize.Height() ) + ++rPosY; } if (rPosX<0) rPosX=0; @@ -2931,10 +2929,10 @@ Point ScViewData::GetMousePosPixel() return pView->GetMousePosPixel(); } -void ScViewData::UpdateInputHandler( bool bForce, bool bStopEditing ) +void ScViewData::UpdateInputHandler( bool bForce ) { if (pViewShell) - pViewShell->UpdateInputHandler( bForce, bStopEditing ); + pViewShell->UpdateInputHandler( bForce ); } bool ScViewData::IsOle() diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx index 54c019aae01c..b455fb9fe2f7 100644 --- a/sc/source/ui/view/viewfun2.cxx +++ b/sc/source/ui/view/viewfun2.cxx @@ -1011,7 +1011,7 @@ bool ScViewFunc::TestMergeCells() // pre-test (for menu) return false; } -bool ScViewFunc::MergeCells( bool bApi, bool& rDoContents, bool bRecord, bool bCenter ) +bool ScViewFunc::MergeCells( bool bApi, bool& rDoContents, bool bCenter ) { // Editable- and Being-Nested- test must be at the beginning (in DocFunc too), // so that the Contents-QueryBox won't appear @@ -1089,7 +1089,7 @@ bool ScViewFunc::MergeCells( bool bApi, bool& rDoContents, bool bRecord, bool bC if (bOk) { - bOk = pDocSh->GetDocFunc().MergeCells( aMergeOption, rDoContents, bRecord, bApi ); + bOk = pDocSh->GetDocFunc().MergeCells( aMergeOption, rDoContents, true/*bRecord*/, bApi ); if (bOk) { @@ -1199,7 +1199,7 @@ void ScViewFunc::FillSimple( FillDir eDir ) { ScDocShell* pDocSh = GetViewData().GetDocShell(); const ScMarkData& rMark = GetViewData().GetMarkData(); - bool bSuccess = pDocSh->GetDocFunc().FillSimple( aRange, &rMark, eDir, true/*bRecord*/, false ); + bool bSuccess = pDocSh->GetDocFunc().FillSimple( aRange, &rMark, eDir, false ); if (bSuccess) { pDocSh->UpdateOle(&GetViewData()); @@ -1224,7 +1224,7 @@ void ScViewFunc::FillSeries( FillDir eDir, FillCmd eCmd, FillDateCmd eDateCmd, const ScMarkData& rMark = GetViewData().GetMarkData(); bool bSuccess = pDocSh->GetDocFunc(). FillSeries( aRange, &rMark, eDir, eCmd, eDateCmd, - fStart, fStep, fMax, true/*bRecord*/, false ); + fStart, fStep, fMax, false ); if (bSuccess) { pDocSh->UpdateOle(&GetViewData()); @@ -1246,7 +1246,7 @@ void ScViewFunc::FillAuto( FillDir eDir, SCCOL nStartCol, SCROW nStartRow, ScDocShell* pDocSh = GetViewData().GetDocShell(); const ScMarkData& rMark = GetViewData().GetMarkData(); bool bSuccess = pDocSh->GetDocFunc(). - FillAuto( aRange, &rMark, eDir, nCount, true/*bRecord*/, false ); + FillAuto( aRange, &rMark, eDir, nCount, false ); if (bSuccess) { MarkRange( aRange, false ); // aRange was modified in FillAuto @@ -1564,7 +1564,7 @@ void ScViewFunc::ConvertFormulaToValue() aRange.PutInOrder(); ScDocShell* pDocSh = GetViewData().GetDocShell(); - pDocSh->GetDocFunc().ConvertFormulaToValue(aRange, true, true); + pDocSh->GetDocFunc().ConvertFormulaToValue(aRange, true); pDocSh->PostPaint(aRange, PAINT_GRID); } @@ -1580,7 +1580,7 @@ void ScViewFunc::TransliterateText( sal_Int32 nType ) } bool bSuccess = GetViewData().GetDocShell()->GetDocFunc(). - TransliterateText( aFuncMark, nType, true, false ); + TransliterateText( aFuncMark, nType, false ); if (bSuccess) { GetViewData().GetViewShell()->UpdateInputHandler(); @@ -1618,7 +1618,7 @@ void ScViewFunc::AutoFormat( sal_uInt16 nFormatNo ) ScDocShell* pDocSh = GetViewData().GetDocShell(); ScMarkData& rMark = GetViewData().GetMarkData(); - bool bSuccess = pDocSh->GetDocFunc().AutoFormat( aRange, &rMark, nFormatNo, true/*bRecord*/, false ); + bool bSuccess = pDocSh->GetDocFunc().AutoFormat( aRange, &rMark, nFormatNo, false ); if (bSuccess) pDocSh->UpdateOle(&GetViewData()); } @@ -2353,7 +2353,7 @@ bool ScViewFunc::SetTabBgColor( const Color& rColor, SCTAB nTab ) bool ScViewFunc::SetTabBgColor( ScUndoTabColorInfo::List& rUndoSetTabBgColorInfoList ) { - bool bSuccess = GetViewData().GetDocShell()->GetDocFunc().SetTabBgColor( rUndoSetTabBgColorInfoList, true, false ); + bool bSuccess = GetViewData().GetDocShell()->GetDocFunc().SetTabBgColor( rUndoSetTabBgColorInfoList, false ); if (bSuccess) { GetViewData().GetViewShell()->UpdateInputHandler(); @@ -2363,7 +2363,7 @@ bool ScViewFunc::SetTabBgColor( ScUndoTabColorInfo::List& rUndoSetTabBgColorInfo void ScViewFunc::InsertAreaLink( const OUString& rFile, const OUString& rFilter, const OUString& rOptions, - const OUString& rSource, sal_uLong nRefresh ) + const OUString& rSource ) { ScDocShell* pDocSh = GetViewData().GetDocShell(); SCCOL nPosX = GetViewData().GetCurX(); @@ -2371,7 +2371,7 @@ void ScViewFunc::InsertAreaLink( const OUString& rFile, SCTAB nTab = GetViewData().GetTabNo(); ScAddress aPos( nPosX, nPosY, nTab ); - pDocSh->GetDocFunc().InsertAreaLink( rFile, rFilter, rOptions, rSource, aPos, nRefresh, false, false ); + pDocSh->GetDocFunc().InsertAreaLink( rFile, rFilter, rOptions, rSource, aPos, 0/*nRefresh*/, false, false ); } void ScViewFunc::InsertTableLink( const OUString& rFile, diff --git a/sc/source/ui/view/viewfun3.cxx b/sc/source/ui/view/viewfun3.cxx index 1acbd4d54c68..c08b20a5e10b 100644 --- a/sc/source/ui/view/viewfun3.cxx +++ b/sc/source/ui/view/viewfun3.cxx @@ -161,14 +161,14 @@ bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, bool bCut, bool bApi, bool bI { ScRangeList aRangeList; aRangeList.Append( aRange ); - bDone = CopyToClip( pClipDoc, aRangeList, bCut, bApi, bIncludeObjects, bStopEdit, false ); + bDone = CopyToClip( pClipDoc, aRangeList, bCut, bApi, bIncludeObjects, bStopEdit ); } else if (eMarkType == SC_MARK_MULTI) { ScRangeList aRangeList; rMark.MarkToSimple(); rMark.FillRangeListWithMarks(&aRangeList, false); - bDone = CopyToClip( pClipDoc, aRangeList, bCut, bApi, bIncludeObjects, bStopEdit, false ); + bDone = CopyToClip( pClipDoc, aRangeList, bCut, bApi, bIncludeObjects, bStopEdit ); } else { @@ -180,7 +180,7 @@ bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, bool bCut, bool bApi, bool bI } // Copy the content of the Range into clipboard. -bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, const ScRangeList& rRanges, bool bCut, bool bApi, bool bIncludeObjects, bool bStopEdit, bool bUseRangeForVBA ) +bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, const ScRangeList& rRanges, bool bCut, bool bApi, bool bIncludeObjects, bool bStopEdit ) { if ( rRanges.empty() ) return false; @@ -220,11 +220,10 @@ bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, const ScRangeList& rRanges, b ScDrawLayer::SetGlobalDrawPersist( ScTransferObj::SetDrawClipDoc( bAnyOle ) ); } - if ( !bUseRangeForVBA ) - // is this necessary?, will setting the doc id upset the - // following paste operation with range? would be nicer to just set this always - // and lose the 'if' above - aClipParam.setSourceDocID( pDoc->GetDocumentID() ); + // is this necessary?, will setting the doc id upset the + // following paste operation with range? would be nicer to just set this always + // and lose the 'if' above + aClipParam.setSourceDocID( pDoc->GetDocumentID() ); if (SfxObjectShell* pObjectShell = pDoc->GetDocumentShell()) { @@ -236,8 +235,8 @@ bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, const ScRangeList& rRanges, b pClipDoc->SetClipOptions(aOptions); } - pDoc->CopyToClip( aClipParam, pClipDoc, &rMark, false, false, bIncludeObjects, true, bUseRangeForVBA ); - if ( !bUseRangeForVBA && pDoc && pClipDoc ) + pDoc->CopyToClip( aClipParam, pClipDoc, &rMark, false, false, bIncludeObjects ); + if ( pDoc && pClipDoc ) { ScDrawLayer* pDrawLayer = pClipDoc->GetDrawLayer(); if ( pDrawLayer ) @@ -366,7 +365,7 @@ bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, const ScRangeList& rRanges, b } if (!bValidRanges) break; - pDoc->CopyToClip(aClipParam, pDocClip.get(), &rMark, false, false, bIncludeObjects, true, bUseRangeForVBA ); + pDoc->CopyToClip(aClipParam, pDocClip.get(), &rMark, false, false, bIncludeObjects ); ScChangeTrack* pChangeTrack = pDoc->GetChangeTrack(); if ( pChangeTrack ) @@ -1796,7 +1795,7 @@ void ScViewFunc::PostPasteFromClip(const ScRangeList& rPasteRanges, const ScMark // inside the doc bool ScViewFunc::MoveBlockTo( const ScRange& rSource, const ScAddress& rDestPos, - bool bCut, bool bRecord, bool bPaint, bool bApi ) + bool bCut ) { ScDocShell* pDocSh = GetViewData().GetDocShell(); HideAllCursors(); @@ -1808,11 +1807,8 @@ bool ScViewFunc::MoveBlockTo( const ScRange& rSource, const ScAddress& rDestPos, { // moving within one table and several tables selected -> apply to all selected tables - if ( bRecord ) - { - OUString aUndo = ScGlobal::GetRscString( bCut ? STR_UNDO_MOVE : STR_UNDO_COPY ); - pDocSh->GetUndoManager()->EnterListAction( aUndo, aUndo ); - } + OUString aUndo = ScGlobal::GetRscString( bCut ? STR_UNDO_MOVE : STR_UNDO_COPY ); + pDocSh->GetUndoManager()->EnterListAction( aUndo, aUndo ); // collect ranges of consecutive selected tables @@ -1835,20 +1831,19 @@ bool ScViewFunc::MoveBlockTo( const ScRange& rSource, const ScAddress& rDestPos, aLocalDest.SetTab( nStartTab ); bSuccess = pDocSh->GetDocFunc().MoveBlock( - aLocalSource, aLocalDest, bCut, bRecord, bPaint, bApi ); + aLocalSource, aLocalDest, bCut, true/*bRecord*/, true/*bPaint*/, true/*bApi*/ ); nStartTab = nEndTab + 1; } } - if ( bRecord ) - pDocSh->GetUndoManager()->LeaveListAction(); + pDocSh->GetUndoManager()->LeaveListAction(); } else { // move the block as specified bSuccess = pDocSh->GetDocFunc().MoveBlock( - rSource, rDestPos, bCut, bRecord, bPaint, bApi ); + rSource, rDestPos, bCut, true/*bRecord*/, true/*bPaint*/, true/*bApi*/ ); } ShowAllCursors(); @@ -1883,7 +1878,7 @@ bool ScViewFunc::MoveBlockTo( const ScRange& rSource, const ScAddress& rDestPos, // link inside the doc -bool ScViewFunc::LinkBlock( const ScRange& rSource, const ScAddress& rDestPos, bool bApi ) +bool ScViewFunc::LinkBlock( const ScRange& rSource, const ScAddress& rDestPos ) { // check overlapping @@ -1895,8 +1890,6 @@ bool ScViewFunc::LinkBlock( const ScRange& rSource, const ScAddress& rDestPos, b if ( rSource.aStart.Col() <= nDestEndCol && rDestPos.Col() <= rSource.aEnd.Col() && rSource.aStart.Row() <= nDestEndRow && rDestPos.Row() <= rSource.aEnd.Row() ) { - if (!bApi) - ErrorMessage( STR_ERR_LINKOVERLAP ); return false; } } @@ -1979,8 +1972,7 @@ void ScViewFunc::DataFormPutData( SCROW nCurrentRow , nStartCol, nCurrentRow, nStartTab, nUndoEndCol, nUndoEndRow, nEndTab, rMark, pUndoDoc, pRedoDoc, nUndoFlags, - pUndoData, nullptr, nullptr, nullptr, - false ); // FALSE = Redo data not yet copied + pUndoData, nullptr, nullptr, nullptr ); pUndoMgr->AddUndoAction( new ScUndoWrapper( pUndo ), true ); sal_uInt16 nPaint = PAINT_GRID; diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx index 7c46a85e8df8..f43695d3c971 100644 --- a/sc/source/ui/view/viewfunc.cxx +++ b/sc/source/ui/view/viewfunc.cxx @@ -209,9 +209,9 @@ void ScViewFunc::DoAutoAttributes( SCCOL nCol, SCROW nRow, SCTAB nTab, const ScPatternAttr* pOldPattern = rDoc.GetPattern( nCol, nRow, nTab ); const ScStyleSheet* pSrcStyle = pSource->GetStyleSheet(); if ( pSrcStyle && pSrcStyle != pOldPattern->GetStyleSheet() ) - rFunc.ApplyStyle( aMark, pSrcStyle->GetName(), true, false ); + rFunc.ApplyStyle( aMark, pSrcStyle->GetName(), false ); - rFunc.ApplyAttributes( aMark, *pSource, true, false ); + rFunc.ApplyAttributes( aMark, *pSource, false ); } if ( bAttrChanged ) // value entered with number format? @@ -949,7 +949,7 @@ void ScViewFunc::ApplyAttributes( const SfxItemSet* pDialogSet, bFrame = false; if (!bFrame) - ApplySelectionPattern( aNewAttrs ); // standard only + ApplySelectionPattern( aNewAttrs ); // standard only else { // if new items are default-items, overwrite the old items: @@ -1082,8 +1082,7 @@ void ScViewFunc::ApplyPatternLines( const ScPatternAttr& rAttr, const SvxBoxItem // pattern only -void ScViewFunc::ApplySelectionPattern( const ScPatternAttr& rAttr, - bool bRecord, bool bCursorOnly ) +void ScViewFunc::ApplySelectionPattern( const ScPatternAttr& rAttr, bool bCursorOnly ) { ScViewData& rViewData = GetViewData(); ScDocShell* pDocSh = rViewData.GetDocShell(); @@ -1091,7 +1090,8 @@ void ScViewFunc::ApplySelectionPattern( const ScPatternAttr& rAttr, ScMarkData aFuncMark( rViewData.GetMarkData() ); // local copy for UnmarkFiltered ScViewUtil::UnmarkFiltered( aFuncMark, &rDoc ); - if (bRecord && !rDoc.IsUndoEnabled()) + bool bRecord = true; + if (!rDoc.IsUndoEnabled()) bRecord = false; // State from old ItemSet doesn't matter for paint flags, as any change will be @@ -1208,7 +1208,7 @@ void ScViewFunc::ApplySelectionPattern( const ScPatternAttr& rAttr, if (bRecord) { ScUndoCursorAttr* pUndo = new ScUndoCursorAttr( - pDocSh, nCol, nRow, nTab, pOldPat.get(), pNewPat, &rAttr, false ); + pDocSh, nCol, nRow, nTab, pOldPat.get(), pNewPat, &rAttr ); pUndo->SetEditData(pOldEditData, pNewEditData); pDocSh->GetUndoManager()->AddUndoAction(pUndo); } @@ -1503,14 +1503,14 @@ void ScViewFunc::DeleteCells( DelCellCmd eCmd ) } while ( nCount > 0 ) { - pDocSh->GetDocFunc().DeleteCells( aDelRange, &rMark, eCmd, true/*bRecord*/, false ); + pDocSh->GetDocFunc().DeleteCells( aDelRange, &rMark, eCmd, false ); --nCount; } } else #endif { - pDocSh->GetDocFunc().DeleteCells( aRange, &rMark, eCmd, true/*bRecord*/, false ); + pDocSh->GetDocFunc().DeleteCells( aRange, &rMark, eCmd, false ); } pDocSh->UpdateOle(&GetViewData()); @@ -1784,7 +1784,7 @@ void ScViewFunc::DeleteContents( InsertDeleteFlags nFlags ) ScDocFunc& rDocFunc = pDocSh->GetDocFunc(); if (bSimple) - rDocFunc.DeleteCell(aMarkRange.aStart, aFuncMark, nFlags, bRecord, false); + rDocFunc.DeleteCell(aMarkRange.aStart, aFuncMark, nFlags, bRecord); else rDocFunc.DeleteContents(aFuncMark, nFlags, bRecord, false); @@ -1820,7 +1820,7 @@ void ScViewFunc::DeleteContents( InsertDeleteFlags nFlags ) void ScViewFunc::SetWidthOrHeight( bool bWidth, const std::vector<sc::ColRowSpan>& rRanges, ScSizeMode eMode, - sal_uInt16 nSizeTwips, bool bRecord, bool bPaint, ScMarkData* pMarkData ) + sal_uInt16 nSizeTwips, bool bRecord, ScMarkData* pMarkData ) { if (rRanges.empty()) return; @@ -2051,7 +2051,6 @@ void ScViewFunc::SetWidthOrHeight( GetViewData().GetView()->UpdateScrollBars(); - if (bPaint) { itr = aMarkData.begin(); for (; itr != itrEnd; ++itr) |