loplugin:unnecessaryvirtual

Change-Id: I15633651aaa914918f1e7739c4f3d4793f7d800a
Reviewed-on: https://gerrit.libreoffice.org/64831
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 47 insertions, 57 deletions

diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results b/compilerplugins/clang/unnecessaryvirtual-dead.results
index 2dffa1efdc68..b282b717406d 100644
--- a/compilerplugins/clang/unnecessaryvirtual-dead.results
+++ b/compilerplugins/clang/unnecessaryvirtual-dead.results
@@ -8,6 +8,8 @@ include/canvas/base/graphicdevicebase.hxx:302
     void canvas::GraphicDeviceBase::removePropertyChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertyChangeListener> &,)
 include/canvas/base/graphicdevicebase.hxx:315
     void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,)
+sc/source/core/opencl/formulagroupcl.cxx:1059
+    void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
 slideshow/source/engine/animationfactory.cxx:443
     void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
 vcl/inc/salframe.hxx:135
diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results
index d9fb3f6e502e..107bd14a2105 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -20,6 +20,8 @@ basic/source/comp/codegen.cxx:524
     _Bool BufferTransformer::processParams()
 chart2/source/inc/WeakListenerAdapter.hxx:57
     void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
+cppcanvas/source/inc/implrenderer.hxx:69
+    void cppcanvas::internal::EMFPObject::~EMFPObject()
 extensions/source/dbpilots/unoautopilot.hxx:99
     class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const
 extensions/source/propctrlr/commoncontrol.hxx:127
@@ -74,16 +76,6 @@ include/comphelper/weakeventlistener.hxx:120
     void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
 include/cppcanvas/font.hxx:38
     void cppcanvas::Font::~Font()
-include/sfx2/basedlgs.hxx:137
-    void SfxModelessDialogController::FillInfo(struct SfxChildWinInfo &,)const
-include/sfx2/basedlgs.hxx:238
-    class weld::Container * SfxSingleTabDialogController::get_content_area()
-include/sfx2/controlwrapper.hxx:215
-    type-parameter-0-0 sfx::ListBoxWrapper::GetControlValue()const
-include/sfx2/controlwrapper.hxx:216
-    void sfx::ListBoxWrapper::SetControlValue(type-parameter-0-0,)
-include/sfx2/tabdlg.hxx:106
-    void SfxTabDialog::RefreshInputSet()
 include/svl/svdde.hxx:237
     class DdeData * DdeTopic::Get(enum SotClipboardFormatId,)
 include/svl/svdde.hxx:238
@@ -96,8 +88,6 @@ include/svl/svdde.hxx:244
     _Bool DdeTopic::StartAdviseLoop()
 include/svl/svdde.hxx:300
     void DdeService::~DdeService()
-include/svtools/valueset.hxx:492
-    void SvtValueSet::Select()
 include/toolkit/controls/geometrycontrolmodel.hxx:191
     void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,)const
 include/vbahelper/vbacollectionimpl.hxx:290
@@ -122,67 +112,75 @@ include/vbahelper/vbareturntypes.hxx:40
     void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,)
 include/vbahelper/vbareturntypes.hxx:41
     type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
-sc/source/core/opencl/formulagroupcl.cxx:914
-    void sc::opencl::DynamicKernelMixedArgument::GenNumDeclRef(class std::__cxx11::basic_stringstream<char> &,)const
+include/vcl/tabctrl.hxx:113
+    _Bool TabControl::DeactivatePage()
+sc/source/core/opencl/formulagroupcl.cxx:1051
+    _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const
+sc/source/core/opencl/formulagroupcl.cxx:1059
+    void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
+sc/source/core/opencl/formulagroupcl.cxx:1338
+    void sc::opencl::ParallelReductionVectorRef::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
+sc/source/core/opencl/formulagroupcl.cxx:1518
+    class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > sc::opencl::ParallelReductionVectorRef::GenSlidingWindowDeclRef(_Bool,)const
+sc/source/core/opencl/formulagroupcl.cxx:1553
+    unsigned long sc::opencl::ParallelReductionVectorRef::Marshal(struct _cl_kernel *,int,int,struct _cl_program *,)
 sc/source/ui/inc/anyrefdg.hxx:208
     void ScRefHdlrImpl::dispose()
-sc/source/ui/inc/condformatdlgentry.hxx:82
-    void ScCondFrmtEntry::SetPos(const class ScAddress &,)
-sc/source/ui/vba/vbacondition.hxx:39
+sc/source/ui/vba/vbacondition.hxx:41
     class rtl::OUString ScVbaCondition::Formula1()
-sc/source/ui/vba/vbacondition.hxx:40
-    class rtl::OUString ScVbaCondition::Formula2()
 sc/source/ui/vba/vbacondition.hxx:42
+    class rtl::OUString ScVbaCondition::Formula2()
+sc/source/ui/vba/vbacondition.hxx:44
     int ScVbaCondition::Operator(_Bool,)
-sc/source/ui/vba/vbaformat.hxx:73
+sc/source/ui/vba/vbaformat.hxx:74
     class com::sun::star::uno::Any ScVbaFormat::Borders(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:76
+sc/source/ui/vba/vbaformat.hxx:77
     class com::sun::star::uno::Reference<class ooo::vba::excel::XFont> ScVbaFormat::Font()
-sc/source/ui/vba/vbaformat.hxx:79
+sc/source/ui/vba/vbaformat.hxx:80
     class com::sun::star::uno::Reference<class ooo::vba::excel::XInterior> ScVbaFormat::Interior()
-sc/source/ui/vba/vbaformat.hxx:82
+sc/source/ui/vba/vbaformat.hxx:83
     void ScVbaFormat::setNumberFormat(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:85
+sc/source/ui/vba/vbaformat.hxx:86
     class com::sun::star::uno::Any ScVbaFormat::getNumberFormat()
-sc/source/ui/vba/vbaformat.hxx:88
+sc/source/ui/vba/vbaformat.hxx:89
     void ScVbaFormat::setNumberFormatLocal(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:91
+sc/source/ui/vba/vbaformat.hxx:92
     class com::sun::star::uno::Any ScVbaFormat::getNumberFormatLocal()
-sc/source/ui/vba/vbaformat.hxx:94
+sc/source/ui/vba/vbaformat.hxx:95
     void ScVbaFormat::setIndentLevel(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:97
+sc/source/ui/vba/vbaformat.hxx:98
     class com::sun::star::uno::Any ScVbaFormat::getIndentLevel()
-sc/source/ui/vba/vbaformat.hxx:100
+sc/source/ui/vba/vbaformat.hxx:101
     void ScVbaFormat::setHorizontalAlignment(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:103
+sc/source/ui/vba/vbaformat.hxx:104
     class com::sun::star::uno::Any ScVbaFormat::getHorizontalAlignment()
-sc/source/ui/vba/vbaformat.hxx:106
+sc/source/ui/vba/vbaformat.hxx:107
     void ScVbaFormat::setVerticalAlignment(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:109
+sc/source/ui/vba/vbaformat.hxx:110
     class com::sun::star::uno::Any ScVbaFormat::getVerticalAlignment()
-sc/source/ui/vba/vbaformat.hxx:112
+sc/source/ui/vba/vbaformat.hxx:113
     void ScVbaFormat::setOrientation(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:115
+sc/source/ui/vba/vbaformat.hxx:116
     class com::sun::star::uno::Any ScVbaFormat::getOrientation()
-sc/source/ui/vba/vbaformat.hxx:118
+sc/source/ui/vba/vbaformat.hxx:119
     void ScVbaFormat::setShrinkToFit(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:121
+sc/source/ui/vba/vbaformat.hxx:122
     class com::sun::star::uno::Any ScVbaFormat::getShrinkToFit()
-sc/source/ui/vba/vbaformat.hxx:124
+sc/source/ui/vba/vbaformat.hxx:125
     void ScVbaFormat::setWrapText(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:127
+sc/source/ui/vba/vbaformat.hxx:128
     class com::sun::star::uno::Any ScVbaFormat::getWrapText()
-sc/source/ui/vba/vbaformat.hxx:130
+sc/source/ui/vba/vbaformat.hxx:131
     void ScVbaFormat::setLocked(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:133
+sc/source/ui/vba/vbaformat.hxx:134
     class com::sun::star::uno::Any ScVbaFormat::getLocked()
-sc/source/ui/vba/vbaformat.hxx:136
+sc/source/ui/vba/vbaformat.hxx:137
     void ScVbaFormat::setFormulaHidden(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:139
+sc/source/ui/vba/vbaformat.hxx:140
     class com::sun::star::uno::Any ScVbaFormat::getFormulaHidden()
-sc/source/ui/vba/vbaformat.hxx:148
+sc/source/ui/vba/vbaformat.hxx:149
     void ScVbaFormat::setReadingOrder(const class com::sun::star::uno::Any &,)
-sc/source/ui/vba/vbaformat.hxx:151
+sc/source/ui/vba/vbaformat.hxx:152
     class com::sun::star::uno::Any ScVbaFormat::getReadingOrder()
 sc/source/ui/vba/vbapagebreak.hxx:45
     int ScVbaPageBreak::getType()
@@ -192,8 +190,6 @@ sc/source/ui/vba/vbapagebreak.hxx:48
     void ScVbaPageBreak::Delete()
 sc/source/ui/vba/vbapagebreak.hxx:49
     class com::sun::star::uno::Reference<class ooo::vba::excel::XRange> ScVbaPageBreak::Location()
-sd/source/ui/animations/CustomAnimationList.hxx:102
-    void sd::CustomAnimationList::ReorderEffectsInUiDuringDragOver(class SvTreeListEntry *,)
 slideshow/source/engine/activities/activitiesfactory.cxx:173
     void slideshow::internal::(anonymous namespace)::FromToByActivity::startAnimation()
 slideshow/source/engine/activities/activitiesfactory.cxx:242
@@ -226,9 +222,9 @@ vcl/inc/salmenu.hxx:92
     class tools::Rectangle SalMenu::GetMenuBarButtonRectPixel(unsigned short,class SalFrame *,)
 vcl/inc/salobj.hxx:48
     void SalObject::Enable(_Bool,)
-vcl/inc/salprn.hxx:115
+vcl/inc/salprn.hxx:116
     enum SalPrinterError SalPrinter::GetErrorCode()
-vcl/inc/unx/glyphcache.hxx:56
+vcl/inc/unx/glyphcache.hxx:57
     void GlyphCache::~GlyphCache()
 vcl/inc/unx/gtk/gtkdata.hxx:164
     int GtkSalDisplay::CaptureMouse(class SalFrame *,)
diff --git a/cppcanvas/source/inc/implrenderer.hxx b/cppcanvas/source/inc/implrenderer.hxx
index 7cb0bb9b12aa..e02b45d20a1a 100644
--- a/cppcanvas/source/inc/implrenderer.hxx
+++ b/cppcanvas/source/inc/implrenderer.hxx
@@ -64,11 +64,6 @@ namespace cppcanvas
         struct ActionFactoryParameters;
         struct XForm;
 
-        struct EMFPObject
-        {
-            virtual ~EMFPObject() {}
-        };
-
         // state stack of OutputDevice, to correctly handle
         // push/pop actions
         class VectorOfOutDevStates
@@ -218,7 +213,6 @@ namespace cppcanvas
 
             /* EMF+ */
             XForm           aBaseTransform;
-            std::unique_ptr<EMFPObject> aObjects [256];
             /* EMF+ emf header info */
             sal_Int32       nFrameLeft;
             sal_Int32       nFrameTop;
diff --git a/cppcanvas/source/mtfrenderer/implrenderer.cxx b/cppcanvas/source/mtfrenderer/implrenderer.cxx
index 9a41900a6208..9a88ea81a216 100644
--- a/cppcanvas/source/mtfrenderer/implrenderer.cxx
+++ b/cppcanvas/source/mtfrenderer/implrenderer.cxx
@@ -2861,8 +2861,6 @@ namespace cppcanvas
             , nMmX(0)
             , nMmY(0)
         {
-            memset (aObjects, 0, sizeof (aObjects));
-
             SAL_INFO( "cppcanvas.emf", "::cppcanvas::internal::ImplRenderer::ImplRenderer(mtf)" );
 
             OSL_ENSURE( rCanvas.get() != nullptr && rCanvas->getUNOCanvas().is(),
diff --git a/include/vcl/tabctrl.hxx b/include/vcl/tabctrl.hxx
index 6a7b3d13e17a..dbb82b3594ec 100644
--- a/include/vcl/tabctrl.hxx
+++ b/include/vcl/tabctrl.hxx
@@ -110,7 +110,7 @@ public:
     virtual bool        PreNotify( NotifyEvent& rNEvt ) override;
 
     virtual void        ActivatePage();
-    virtual bool        DeactivatePage();
+    bool                DeactivatePage();
 
     virtual Size GetOptimalSize() const override;