diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2021-09-09 16:18:02 +0200 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-09-13 21:31:26 +0200 |
| commit | 877aa28e981349480844a995334367dd9c3ab72b (patch) | |
| tree | 88605a2ce85dcdb7f1fccd2c49a4834193fdd072 | |
| parent | 7d2219c06c69e35785282c4183029286f17c3f11 (diff) | |
do not intern a temporary cell error string
Interning is way more work than a simple text comparison done once.
Change-Id: If18c478fc62d1fb09ce2141fdb77b46a6bc46c08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121855
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit d0316985db22efd6708dffa173eaabb430f6b9a8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121985
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | sc/source/core/data/table3.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 48c05bcaa40d..20e16b455c29 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -2433,8 +2433,8 @@ public: if (rCell.meType == CELLTYPE_FORMULA && rCell.mpFormula->GetErrCode() != FormulaError::NONE) { // Error cell is evaluated as string (for now). - const svl::SharedString aCellStr = mrStrPool.intern(ScGlobal::GetErrorString(rCell.mpFormula->GetErrCode())); - return compareByStringComparator(rEntry, rItem, &aCellStr, nullptr); + const OUString aCellStr = ScGlobal::GetErrorString(rCell.mpFormula->GetErrCode()); + return compareByStringComparator(rEntry, rItem, nullptr, &aCellStr); } else if (rCell.meType == CELLTYPE_STRING) { |