diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-03-04 14:03:07 +0000 |
|---|---|---|
| committer | Michael Stahl <michael.stahl@allotropia.de> | 2022-03-07 12:08:32 +0100 |
| commit | d47e524aec31398d3af83563c546fef06ecb280c (patch) | |
| tree | 61870497868375e1484028e41cf87cba28d98567 | |
| parent | a11dcae70dd97b42213d9af2a9de22dccafe0820 (diff) | |
cid#1500690 Explicit null dereferenced
this may stem from:
commit fcc31cd0e0a6544a13dac0fdc66005d77f6f5cf9
Date: Fri Sep 7 18:41:58 2018 +0200
Revert "clang-tidy performance-move-const-arg"
This reverts commit 3d604d1cd6cc70ef96782ef769f0479b509987a8.
which didn't 100% revert 3d604d1cd6cc70ef96782ef769f0479b509987a8
so we went from:
LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pMasterPersistPtr)
: SlideFragmentHandler( rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout )
to
LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pMasterPersistPtr)
: SlideFragmentHandler(rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout)
Change-Id: I90cb437c467f88c75d248ed138d078bf56705a21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131007
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
| -rw-r--r-- | oox/source/ppt/layoutfragmenthandler.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/oox/source/ppt/layoutfragmenthandler.cxx b/oox/source/ppt/layoutfragmenthandler.cxx index f04a96bb4636..9d95b6ecc5b6 100644 --- a/oox/source/ppt/layoutfragmenthandler.cxx +++ b/oox/source/ppt/layoutfragmenthandler.cxx @@ -36,7 +36,7 @@ namespace oox::ppt { LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pMasterPersistPtr) - : SlideFragmentHandler(rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout) + : SlideFragmentHandler(rFilter, rFragmentPath, pMasterPersistPtr, Layout) { } |