diff options
author | Tor Lillqvist <tml@collabora.com> | 2015-06-09 08:33:15 +0300 |
---|---|---|
committer | Tor Lillqvist <tml@collabora.com> | 2015-06-09 08:57:21 +0300 |
commit | 1276bf033b11a71961cd3454bb44bf08f997ca62 (patch) | |
tree | 60dd61436e40eec08eedd0de1ece01cdd27dd6a0 | |
parent | d28102b1ed0c31500bbc68453a7b7613bd2bfa06 (diff) |
WaE: null passed to a callee that requires a non-null argument
But actually I strongly suspect that this is dead
code.
[AquaA11yTextWrapper rTFForRangeAttributeForElement:forParameter:] is
called only from [AquaA11yWrapper rTFForRangeAttributeForParameter:],
and that is not called from our code, nor do I see any mention of
either rTFForRangeAttributeForElement or
rTFForRangeAttributeForParameter in documentation or when googling.
The NSView documentation does talk about accessibilityRTFForRange,
though. Could this be some copy/paste error since initial commit, code
that has never been tested? Would not surprise me a bit.
Change-Id: Ia1351c293e51e0b75d8b222f78ea19f7801a7c18
-rw-r--r-- | vcl/osx/a11ytextwrapper.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcl/osx/a11ytextwrapper.mm b/vcl/osx/a11ytextwrapper.mm index 36fcb9c04a72..bfa67d1a91e6 100644 --- a/vcl/osx/a11ytextwrapper.mm +++ b/vcl/osx/a11ytextwrapper.mm @@ -270,7 +270,7 @@ using namespace ::com::sun::star::uno; NSAttributedString * attrString = (NSAttributedString *) [ AquaA11yTextWrapper attributedStringForRangeAttributeForElement: wrapper forParameter: range ]; if ( attrString != nil ) { @try { - rtfData = [ attrString RTFFromRange: [ range rangeValue ] documentAttributes: nil ]; + rtfData = [ attrString RTFFromRange: [ range rangeValue ] documentAttributes: @{NSDocumentTypeDocumentAttribute : NSRTFTextDocumentType} ]; } @catch ( NSException * e) { // emtpy } |