summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2015-11-11 17:37:29 +0000
committerMichael Stahl <mstahl@redhat.com>2015-11-13 10:42:44 +0000
commitb453342413fddbc808c39f5edd8b19ed49fff05d (patch)
treea54b74459aa5ee969e9e69ea919b46074f36c449
parent78f90a6db00b5dd69bb14178a8b31fc0f845d59c (diff)
coverity#1338592 Explicit null dereferenced
Change-Id: Ief5c2effbddebe29fc7a4d38ed0af4fed72de40e (cherry picked from commit e08fbe4c592b25fb88828157ff054431ac8e2d8b) Reviewed-on: https://gerrit.libreoffice.org/19915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
-rw-r--r--javaunohelper/source/javaunohelper.cxx6
1 files changed, 2 insertions, 4 deletions
diff --git a/javaunohelper/source/javaunohelper.cxx b/javaunohelper/source/javaunohelper.cxx
index d91a081781c1..145a753a9ddd 100644
--- a/javaunohelper/source/javaunohelper.cxx
+++ b/javaunohelper/source/javaunohelper.cxx
@@ -69,8 +69,6 @@ jboolean Java_com_sun_star_comp_helper_SharedLibraryLoader_component_1writeInfo(
osl::Module lib(aLibName, SAL_LOADMODULE_LAZY | SAL_LOADMODULE_GLOBAL);
if (lib.is())
{
- lib.release();
-
// ========================= LATEST VERSION =========================
OUString aGetEnvName( COMPONENT_GETENV );
oslGenericFunction pSym = lib.getFunctionSymbol(aGetEnvName);
@@ -126,6 +124,7 @@ jboolean Java_com_sun_star_comp_helper_SharedLibraryLoader_component_1writeInfo(
}
}
}
+ lib.release();
}
#endif
return bRet ? JNI_TRUE : JNI_FALSE;
@@ -161,8 +160,6 @@ jobject Java_com_sun_star_comp_helper_SharedLibraryLoader_component_1getFactory(
osl::Module lib(aLibName, SAL_LOADMODULE_LAZY | SAL_LOADMODULE_GLOBAL);
if (lib.is())
{
- lib.release();
-
// ========================= LATEST VERSION =========================
OUString aGetEnvName( COMPONENT_GETENV );
oslGenericFunction pSym = lib.getFunctionSymbol(aGetEnvName);
@@ -232,6 +229,7 @@ jobject Java_com_sun_star_comp_helper_SharedLibraryLoader_component_1getFactory(
}
}
}
+ lib.release();
}
#endif
return joSLL_cpp;