diff options
author | Noel Grandin <noel@peralex.com> | 2014-03-17 11:25:03 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-03-17 13:30:53 +0200 |
commit | 1d6fd96df71265730550e68878a1d2856761a2f3 (patch) | |
tree | c5328c6cac129ef678c755bd9387c8bbb11d87e7 | |
parent | 96b5d4f62709a7db0c1a85f35938abdedea578e3 (diff) |
framework: prefer passing OUString by reference
Change-Id: I23c2ac9ef6bfc3eedb8ad6cb199c12d42ed642c8
-rw-r--r-- | framework/inc/classes/fwktabwindow.hxx | 2 | ||||
-rw-r--r-- | framework/inc/services/layoutmanager.hxx | 2 | ||||
-rw-r--r-- | framework/source/dispatch/loaddispatcher.cxx | 6 | ||||
-rw-r--r-- | framework/source/fwe/classes/addonmenu.cxx | 2 | ||||
-rw-r--r-- | framework/source/fwe/classes/addonsoptions.cxx | 4 | ||||
-rw-r--r-- | framework/source/inc/dispatch/loaddispatcher.hxx | 4 | ||||
-rw-r--r-- | i18nlangtag/qa/cppunit/test_languagetag.cxx | 2 |
7 files changed, 11 insertions, 11 deletions
diff --git a/framework/inc/classes/fwktabwindow.hxx b/framework/inc/classes/fwktabwindow.hxx index 915ffa581974..9893c2f8171c 100644 --- a/framework/inc/classes/fwktabwindow.hxx +++ b/framework/inc/classes/fwktabwindow.hxx @@ -85,7 +85,7 @@ struct TabEntry TabEntry() : m_nIndex( -1 ), m_pPage( NULL ) {} - TabEntry( sal_Int32 nIndex, OUString sURL, const css::uno::Reference< css::awt::XContainerWindowEventHandler > & rEventHdl ) : + TabEntry( sal_Int32 nIndex, const OUString& sURL, const css::uno::Reference< css::awt::XContainerWindowEventHandler > & rEventHdl ) : m_nIndex( nIndex ), m_pPage( NULL ), m_sPageURL( sURL ), m_xEventHdl( rEventHdl ) {} ~TabEntry() { delete m_pPage; } diff --git a/framework/inc/services/layoutmanager.hxx b/framework/inc/services/layoutmanager.hxx index db8be46e50f9..6f5bef666b70 100644 --- a/framework/inc/services/layoutmanager.hxx +++ b/framework/inc/services/layoutmanager.hxx @@ -217,7 +217,7 @@ namespace framework ::com::sun::star::uno::Reference< ::com::sun::star::ui::XUIElement > implts_findElement( const OUString& aName ); - void implts_writeNewStateData( const OUString aName, const ::com::sun::star::uno::Reference< com::sun::star::awt::XWindow >& xWindow ); + void implts_writeNewStateData( const OUString& aName, const ::com::sun::star::uno::Reference< com::sun::star::awt::XWindow >& xWindow ); sal_Bool implts_readWindowStateData( const OUString& rName, UIElement& rElementData ); void implts_writeWindowStateData( const OUString& rName, const UIElement& rElementData ); void implts_setElementData( UIElement& rUIElement, const ::com::sun::star::uno::Reference< ::com::sun::star::awt::XDockableWindow >& rDockWindow ); diff --git a/framework/source/dispatch/loaddispatcher.cxx b/framework/source/dispatch/loaddispatcher.cxx index 68a6524fe4c6..b028e5fd9f80 100644 --- a/framework/source/dispatch/loaddispatcher.cxx +++ b/framework/source/dispatch/loaddispatcher.cxx @@ -25,10 +25,10 @@ namespace framework{ -LoadDispatcher::LoadDispatcher(const css::uno::Reference< css::uno::XComponentContext >& xContext , +LoadDispatcher::LoadDispatcher(const css::uno::Reference< css::uno::XComponentContext >& xContext , const css::uno::Reference< css::frame::XFrame >& xOwnerFrame , - const OUString sTargetName , - sal_Int32 nSearchFlags) + const OUString& sTargetName , + sal_Int32 nSearchFlags) : ThreadHelpBase( ) , m_xContext (xContext ) , m_xOwnerFrame (xOwnerFrame ) diff --git a/framework/source/fwe/classes/addonmenu.cxx b/framework/source/fwe/classes/addonmenu.cxx index 11c5685ca1c9..a165a29824b5 100644 --- a/framework/source/fwe/classes/addonmenu.cxx +++ b/framework/source/fwe/classes/addonmenu.cxx @@ -151,7 +151,7 @@ sal_uInt16 AddonMenuManager::GetNextPos( sal_uInt16 nPos ) } -static sal_uInt16 FindMenuId( Menu* pMenu, const OUString aCommand ) +static sal_uInt16 FindMenuId( Menu* pMenu, const OUString& aCommand ) { sal_uInt16 nPos = 0; OUString aCmd; diff --git a/framework/source/fwe/classes/addonsoptions.cxx b/framework/source/fwe/classes/addonsoptions.cxx index 2fc0bef59fcd..268eae102d33 100644 --- a/framework/source/fwe/classes/addonsoptions.cxx +++ b/framework/source/fwe/classes/addonsoptions.cxx @@ -328,7 +328,7 @@ class AddonsOptions_Impl : public ConfigItem sal_Bool ReadAddonMenuSet( Sequence< Sequence< PropertyValue > >& aAddonMenuSeq ); sal_Bool ReadOfficeMenuBarSet( Sequence< Sequence< PropertyValue > >& aAddonOfficeMenuBarSeq ); sal_Bool ReadOfficeToolBarSet( AddonToolBars& rAddonOfficeToolBars, std::vector< OUString >& rAddonOfficeToolBarResNames ); - sal_Bool ReadToolBarItemSet( const OUString rToolBarItemSetNodeName, Sequence< Sequence< PropertyValue > >& aAddonOfficeToolBarSeq ); + sal_Bool ReadToolBarItemSet( const OUString& rToolBarItemSetNodeName, Sequence< Sequence< PropertyValue > >& aAddonOfficeToolBarSeq ); sal_Bool ReadOfficeHelpSet( Sequence< Sequence< PropertyValue > >& aAddonOfficeHelpMenuSeq ); void ReadImages( ImageManager& aImageManager ); sal_Bool ReadMenuMergeInstructions( MergeMenuInstructionContainer& rContainer ); @@ -840,7 +840,7 @@ sal_Bool AddonsOptions_Impl::ReadOfficeToolBarSet( AddonToolBars& rAddonOfficeTo // private method -sal_Bool AddonsOptions_Impl::ReadToolBarItemSet( const OUString rToolBarItemSetNodeName, Sequence< Sequence< PropertyValue > >& rAddonOfficeToolBarSeq ) +sal_Bool AddonsOptions_Impl::ReadToolBarItemSet( const OUString& rToolBarItemSetNodeName, Sequence< Sequence< PropertyValue > >& rAddonOfficeToolBarSeq ) { sal_Bool bInsertSeparator = sal_False; sal_uInt32 nToolBarItemCount = rAddonOfficeToolBarSeq.getLength(); diff --git a/framework/source/inc/dispatch/loaddispatcher.hxx b/framework/source/inc/dispatch/loaddispatcher.hxx index 23b16ac9d9c9..c0384b250ae4 100644 --- a/framework/source/inc/dispatch/loaddispatcher.hxx +++ b/framework/source/inc/dispatch/loaddispatcher.hxx @@ -85,8 +85,8 @@ class LoadDispatcher : private ThreadHelpBase */ LoadDispatcher(const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::frame::XFrame >& xOwnerFrame , - const OUString sTargetName , - sal_Int32 nSearchFlags); + const OUString& sTargetName , + sal_Int32 nSearchFlags); diff --git a/i18nlangtag/qa/cppunit/test_languagetag.cxx b/i18nlangtag/qa/cppunit/test_languagetag.cxx index 8946969b2562..fb49ad864ca9 100644 --- a/i18nlangtag/qa/cppunit/test_languagetag.cxx +++ b/i18nlangtag/qa/cppunit/test_languagetag.cxx @@ -579,7 +579,7 @@ void TestLanguageTag::testAllTags() } } -static bool checkMapping( const OUString rStr1, const OUString& rStr2 ) +static bool checkMapping( const OUString& rStr1, const OUString& rStr2 ) { if (rStr1 == "la-Latn" ) return rStr2 == "la"; if (rStr1 == "tzm-Latn-DZ" ) return rStr2 == "kab-DZ"; |