Check number of cells referenced by group instead of group size

It's more relevant when deciding whether to use OpenCL or not.

Note that we won't use OpenCL for a single formula cell, no matter how large a
calculation it invokes (like =SUM(A1:A1000000), for instance), as a single
cell is not a group.

Change-Id: I66b03c197431c2b4cef96f46b010d99d3e0624fc
Reviewed-on: https://gerrit.libreoffice.org/13597
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

4 files changed, 42 insertions, 1 deletions

diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index 86b8045ee1d6..746ca5505c32 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -410,6 +410,10 @@ public:
     bool IsSharedTop() const;
     SCROW GetSharedTopRow() const;
     SCROW GetSharedLength() const;
+
+    // An estimate of the number of cells referenced by the formula
+    sal_Int32 GetWeight() const;
+
     ScTokenArray* GetSharedCode();
     const ScTokenArray* GetSharedCode() const;
 
diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx
index 07f344b5bfce..ad61ef3cdc87 100644
--- a/sc/inc/tokenarray.hxx
+++ b/sc/inc/tokenarray.hxx
@@ -59,6 +59,9 @@ public:
     virtual ~ScTokenArray();
     ScTokenArray* Clone() const;    /// True copy!
 
+    // An estimate of the number of cells referenced by the token array
+    sal_Int32 GetWeight() const;
+
     void GenHash();
     size_t GetHash() const { return mnHashValue;}
 
diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index bc9ffbe4940c..daefcc6ab2b7 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -3750,7 +3750,7 @@ bool ScFormulaCell::InterpretFormulaGroup()
     if (mxGroup->meCalcState == sc::GroupCalcDisabled)
         return false;
 
-    if (GetSharedLength() < ScInterpreter::GetGlobalConfig().mnOpenCLMinimumFormulaGroupSize)
+    if (GetWeight() < ScInterpreter::GetGlobalConfig().mnOpenCLMinimumFormulaGroupSize)
     {
         mxGroup->meCalcState = sc::GroupCalcDisabled;
         return false;
@@ -4128,6 +4128,13 @@ SCROW ScFormulaCell::GetSharedLength() const
     return mxGroup ? mxGroup->mnLength : 0;
 }
 
+sal_Int32 ScFormulaCell::GetWeight() const
+{
+    if (!mxGroup)
+        return pCode->GetWeight();
+    return GetSharedLength() * GetSharedCode()->GetWeight();
+}
+
 ScTokenArray* ScFormulaCell::GetSharedCode()
 {
     return mxGroup ? mxGroup->mpCode : NULL;
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 8816b87df833..89a33e6f2fce 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -1412,6 +1412,33 @@ bool ScTokenArray::ImplGetReference( ScRange& rRange, const ScAddress& rPos, boo
     return bIs;
 }
 
+sal_Int32 ScTokenArray::GetWeight() const
+{
+    sal_Int32 result(0);
+
+    FormulaToken** p = pCode;
+    FormulaToken** pEnd = p + static_cast<size_t>(nLen);
+    for (; p != pEnd; ++p)
+    {
+        switch ((*p)->GetType())
+        {
+        case svDoubleRef :
+        case svExternalDoubleRef:
+            {
+                const ScComplexRefData& rRef = *(*p)->GetDoubleRef();
+                result += ( (rRef.Ref2.Row() - rRef.Ref1.Row() + 1) * (rRef.Ref2.Col() - rRef.Ref1.Col() + 1) );
+            }
+            break;
+        default:
+            break;
+        }
+    }
+    // Just print out the this pointer. It turns out to be quite complicated to get
+    // a symbolic printout of the ScTokenArray here.
+    SAL_INFO("sc.token", "GetWeight(" << this << "): " << result);
+    return result;
+}
+
 namespace {
 
 // we want to compare for similar not identical formulae