diff options
| author | Arkadiusz Miśkiewicz <arekm@maven.pl> | 2014-10-09 23:40:29 +0200 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2014-10-10 16:27:40 +0000 |
| commit | 63ec7252a4c64b98a07408106d6d8054dde8710d (patch) | |
| tree | 1006a3463abe84f98f151cb00e01fa24e882cda5 | |
| parent | 71f16d92df4458a8130ad526545b795313821e33 (diff) | |
Avoid bashizm in AbsolutePath() function
&> is another bashizm. Avoid that since configure is run using POSIX
shell. Some POSIX compatible shells like mksh do not understand bash
syntax.
"cd - &> /dev/null" was causing "cd -" command to go into background
which means we never changed back to original directory thus fooling
configure script later:
config.status: error: cannot find input file: `config_host.mk.in'
"&>" was also redirecting stderr which we don't want to do anymore since
it hides real and interesting errors.
Change-Id: I286a32e6a200afca883b159d9196f606e0fe7063
Reviewed-on: https://gerrit.libreoffice.org/11896
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
(cherry picked from commit d5b0697cebd7d66ee90d12f7b893c193ae36eaa6)
Reviewed-on: https://gerrit.libreoffice.org/11897
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | configure.ac | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/configure.ac b/configure.ac index 331a1eef928b..74211a807edf 100644 --- a/configure.ac +++ b/configure.ac @@ -72,7 +72,7 @@ AbsolutePath() if test -d "$rel" ; then cd "$rel" || AC_MSG_ERROR([absolute path resolution failed for "$rel".]) absolute_path="$(pwd)" - cd - &> /dev/null + cd - > /dev/null else AC_MSG_ERROR([Failed to resolve absolute path. "$rel" does not exist or is not a directory.]) fi |