diff options
| author | Lionel Elie Mamane <lionel@mamane.lu> | 2014-01-06 16:40:59 +0100 |
|---|---|---|
| committer | David Tardon <dtardon@redhat.com> | 2014-01-08 15:18:41 +0000 |
| commit | 515c6cf7a3832bfc7a6eeed65704bc9eee96adc1 (patch) | |
| tree | 0aa055c2093cd1baec1026a121c48f1b1f6ac3da | |
| parent | 152b0dd43165106f9c01bab33017e23dadf91fb6 (diff) | |
fdo#37167 create statement before execute/wasNull/getBoolean
This populates "object" member variable.
The "createStatement" calls were removed in:
commit b9392a36645d8632b97ad79240f483b3a1683b61
Author: Ivo Hinkelmann <ihi@openoffice.org>
Date: Thu Apr 23 10:42:05 2009 +0000
CWS-TOOLING: integrate CWS dbaperf1
This was most probably in error since the call is not removed from the
other modified member functions in this commit and/or failed to
aaccount for the scenario of no parameter (and thus no setXXX call
before execute).
Change-Id: Ic0e7b7b64ea496791f32c1416aa7d4416f909616
Reviewed-on: https://gerrit.libreoffice.org/7280
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
| -rw-r--r-- | connectivity/source/drivers/jdbc/CallableStatement.cxx | 4 | ||||
| -rw-r--r-- | connectivity/source/drivers/jdbc/PreparedStatement.cxx | 5 |
2 files changed, 9 insertions, 0 deletions
diff --git a/connectivity/source/drivers/jdbc/CallableStatement.cxx b/connectivity/source/drivers/jdbc/CallableStatement.cxx index 7ab349f3e1fa..50cce64578f8 100644 --- a/connectivity/source/drivers/jdbc/CallableStatement.cxx +++ b/connectivity/source/drivers/jdbc/CallableStatement.cxx @@ -69,12 +69,16 @@ Any SAL_CALL java_sql_CallableStatement::queryInterface( const Type & rType ) th // ------------------------------------------------------------------------- sal_Bool SAL_CALL java_sql_CallableStatement::wasNull( ) throw(starsdbc::SQLException, RuntimeException) { + SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!"); + createStatement(t.pEnv); static jmethodID mID(NULL); return callBooleanMethod( "wasNull", mID ); } sal_Bool SAL_CALL java_sql_CallableStatement::getBoolean( sal_Int32 columnIndex ) throw(starsdbc::SQLException, RuntimeException) { + SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!"); + createStatement(t.pEnv); static jmethodID mID(NULL); return callBooleanMethodWithIntArg( "getBoolean", mID,columnIndex ); } diff --git a/connectivity/source/drivers/jdbc/PreparedStatement.cxx b/connectivity/source/drivers/jdbc/PreparedStatement.cxx index 0458ad7d5af4..5f9dafe0600e 100644 --- a/connectivity/source/drivers/jdbc/PreparedStatement.cxx +++ b/connectivity/source/drivers/jdbc/PreparedStatement.cxx @@ -96,6 +96,8 @@ sal_Bool SAL_CALL java_sql_PreparedStatement::execute( ) throw(::com::sun::star ::osl::MutexGuard aGuard( m_aMutex ); checkDisposed(java_sql_Statement_BASE::rBHelper.bDisposed); + SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!"); + createStatement(t.pEnv); static jmethodID mID(NULL); return callBooleanMethod( "execute", mID ); } @@ -106,6 +108,9 @@ sal_Int32 SAL_CALL java_sql_PreparedStatement::executeUpdate( ) throw(::com::su ::osl::MutexGuard aGuard( m_aMutex ); checkDisposed(java_sql_Statement_BASE::rBHelper.bDisposed); m_aLogger.log( LogLevel::FINE, STR_LOG_EXECUTING_PREPARED_UPDATE ); + + SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!"); + createStatement(t.pEnv); static jmethodID mID(NULL); return callIntMethod("executeUpdate",mID); } |