summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZolnai Tamás <tamas.zolnai@collabora.com>2014-01-03 00:41:56 +0100
committerZolnai Tamás <tamas.zolnai@collabora.com>2014-01-06 02:16:33 +0100
commit17f7655b6dedb7349c3ecd8445f119c4d14641b0 (patch)
treea5e604ccb8de0e4c749a22ebaf4ccd27e84e1dc3
parentd3a5776b00ee07ac371dd180a6d962d50da4baf5 (diff)
cp#2013101510000026: doc import of comments affecting more text nodes
Change-Id: I3932d82cb4cd640b19957b93cc7e59711af1b564 (cherry picked from commit f2945255df273404ee2457dcf761cb8f334b732b) (cherry picked from commit e0bd7b01f31bfbaeac3bce86403bf25929c61c84)
-rw-r--r--sw/qa/extras/ww8export/data/fdo59530.docbin9728 -> 10240 bytes
-rw-r--r--sw/qa/extras/ww8export/ww8export.cxx15
-rw-r--r--sw/source/filter/ww8/ww8par.cxx49
3 files changed, 58 insertions, 6 deletions
diff --git a/sw/qa/extras/ww8export/data/fdo59530.doc b/sw/qa/extras/ww8export/data/fdo59530.doc
index 60cfe840a787..921fbca7973d 100644
--- a/sw/qa/extras/ww8export/data/fdo59530.doc
+++ b/sw/qa/extras/ww8export/data/fdo59530.doc
Binary files differ
diff --git a/sw/qa/extras/ww8export/ww8export.cxx b/sw/qa/extras/ww8export/ww8export.cxx
index 29e2df5e734f..d34a46dfa4ee 100644
--- a/sw/qa/extras/ww8export/ww8export.cxx
+++ b/sw/qa/extras/ww8export/ww8export.cxx
@@ -164,7 +164,6 @@ void Test::testFdo59530()
uno::Reference<beans::XPropertySet> xPropertySet(xRunEnum->nextElement(), uno::UNO_QUERY);
CPPUNIT_ASSERT_EQUAL(OUString("TextFieldStart"), getProperty<OUString>(xPropertySet, "TextPortionType"));
xRunEnum->nextElement();
- xRunEnum->nextElement();
xPropertySet.set(xRunEnum->nextElement(), uno::UNO_QUERY);
CPPUNIT_ASSERT_EQUAL(OUString("TextFieldEnd"), getProperty<OUString>(xPropertySet, "TextPortionType"));
@@ -174,6 +173,20 @@ void Test::testFdo59530()
uno::Reference<container::XEnumeration> xFields(xFieldsAccess->createEnumeration());
xPropertySet.set(xFields->nextElement(), uno::UNO_QUERY);
CPPUNIT_ASSERT_EQUAL(OUString("M"), getProperty<OUString>(xPropertySet, "Initials"));
+
+ // Test commented text range which spans over more text nodes
+ // Comment starts in the second paragraph
+ xRunEnumAccess.set(xParaEnum->nextElement(), uno::UNO_QUERY);
+ xRunEnum = xRunEnumAccess->createEnumeration();
+ xRunEnum->nextElement();
+ xPropertySet.set(xRunEnum->nextElement(), uno::UNO_QUERY);
+ CPPUNIT_ASSERT_EQUAL(OUString("TextFieldStart"), getProperty<OUString>(xPropertySet, "TextPortionType"));
+ // Comment ends in the third paragraph
+ xRunEnumAccess.set(xParaEnum->nextElement(), uno::UNO_QUERY);
+ xRunEnum = xRunEnumAccess->createEnumeration();
+ xRunEnum->nextElement();
+ xPropertySet.set(xRunEnum->nextElement(), uno::UNO_QUERY);
+ CPPUNIT_ASSERT_EQUAL(OUString("TextFieldEnd"), getProperty<OUString>(xPropertySet, "TextPortionType"));
}
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 56040b7332ab..645d2466e7f4 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -1825,11 +1825,50 @@ long SwWW8ImplReader::Read_And(WW8PLCFManResult* pRes)
WW8_CP nStart = GetAnnotationStart(nAtnIndex);
WW8_CP nEnd = GetAnnotationEnd(nAtnIndex);
sal_Int32 nLen = nEnd - nStart;
- // Don't support ranges affecting multiple SwTxtNode for now.
- if (nLen && pPaM->GetPoint()->nContent.GetIndex() >= nLen)
- {
- pPaM->SetMark();
- pPaM->GetPoint()->nContent -= nLen;
+ if( nLen )
+ {
+ if (pPaM->GetPoint()->nContent.GetIndex() >= nLen)
+ {
+ pPaM->SetMark();
+ pPaM->GetPoint()->nContent -= nLen;
+ }
+ else if (pPaM->GetPoint()->nNode.GetNode().IsTxtNode() )
+ {
+ pPaM->SetMark();
+ nLen -= pPaM->GetPoint()->nContent.GetIndex();
+
+ SwTxtNode* pTxtNode = 0;
+ // Find first text node which affected by the comment
+ while( pPaM->GetPoint()->nNode >= 0 )
+ {
+ SwNode* pNode = 0;
+ // Find previous text node
+ do
+ {
+ pPaM->GetPoint()->nNode--;
+ nLen--; // End line character
+ pNode = &pPaM->GetPoint()->nNode.GetNode();
+ }
+ while( !pNode->IsTxtNode() && pPaM->GetPoint()->nNode >= 0 );
+
+ // Subtrackt previous text node's length
+ if( pNode && pNode->IsTxtNode() )
+ {
+ pTxtNode = pNode->GetTxtNode();
+ if( nLen < pTxtNode->Len() )
+ break;
+ else
+ nLen -= pTxtNode->Len();
+ }
+ }
+
+ // Set postion of the text range's first character
+ if( pTxtNode )
+ {
+ pTxtNode->MakeStartIndex(&pPaM->GetPoint()->nContent);
+ pPaM->GetPoint()->nContent += pTxtNode->Len() - nLen;
+ }
+ }
}
}
}