diff options
| author | Tor Lillqvist <tml@iki.fi> | 2020-05-28 12:53:16 +0300 |
|---|---|---|
| committer | Tor Lillqvist <tml@collabora.com> | 2020-06-25 17:23:56 +0200 |
| commit | a84adccbd8cda66fd4d84c8443b0715820afd1da (patch) | |
| tree | 1c84d8fff6c6d13bcb76f1a8ba94ea7894264d5e | |
| parent | b0da52d19ed40dd0871f208eb7387ec1d8252de4 (diff) | |
tdf#128502: Remove assertions that fire for gtktiledviewer on two docs
If you run gtktiledviewer so that it opens a spreadsheet and a text
document these assertions would fire.
In each case the assertion is followed by code that just returns if
the asserted condition doesn't hold, so it is unlikely that this
change will break anything.
There sure will be a lot of further changes needed to make such a use
case work. (For starters, editing either of the two documents does not
work.) But let's do it step by step.
Change-Id: I4063dbbcac7c77b57e1f4cb3f05bd5096c08c0fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95037
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95144
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
| -rw-r--r-- | sc/source/ui/view/gridwin.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index e30818c50c00..094fe1d7f456 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -5740,7 +5740,6 @@ void ScGridWindow::notifyKitCellViewCursor(const SfxViewShell* pForShell) const if (mpOOCursors) // cf. getCellCursor above { auto pForTabView = dynamic_cast<const ScTabViewShell *>(pForShell); - assert(pForTabView); if (!pForTabView) return; aCursor = pForTabView->GetViewData().describeCellCursorAt( @@ -5777,7 +5776,6 @@ void ScGridWindow::updateKitOtherCursors() const it = SfxViewShell::GetNext(*it)) { auto pOther = dynamic_cast<const ScTabViewShell *>(it); - assert(pOther); if (!pOther) continue; const ScGridWindow *pGrid = pOther->GetViewData().GetActiveWin(); @@ -6002,7 +6000,6 @@ void ScGridWindow::updateOtherKitSelections() const it = SfxViewShell::GetNext(*it)) { auto pOther = dynamic_cast<const ScTabViewShell *>(it); - assert(pOther); if (!pOther) return; |