diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2023-02-25 21:13:42 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2023-02-26 14:51:38 +0000 |
| commit | ee03f6453e6f11f3db0742b08c53ad2c6b4ebb63 (patch) | |
| tree | 31049bab667df8c188f67af4697e1b83770bd52f | |
| parent | 1b7ebea25fb94efa08160792c4eb6ae9e8a9147f (diff) | |
cid#1521509 Logically dead code
and
cid#1521507 Logically dead code
Change-Id: I1d2c9ee4a4099fadb5da7a6850b4124488e2ebe8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147687
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | sw/source/uibase/misc/redlndlg.cxx | 6 | ||||
| -rw-r--r-- | sw/source/uibase/utlui/content.cxx | 5 |
2 files changed, 3 insertions, 8 deletions
diff --git a/sw/source/uibase/misc/redlndlg.cxx b/sw/source/uibase/misc/redlndlg.cxx index 80e35dec095f..304c4d4a3a50 100644 --- a/sw/source/uibase/misc/redlndlg.cxx +++ b/sw/source/uibase/misc/redlndlg.cxx @@ -246,8 +246,6 @@ void SwRedlineAcceptDlg::InitAuthors() SwView *pView = ::GetActiveView(); SwWrtShell* pSh = pView ? pView->GetWrtShellPtr() : nullptr; - if (!pSh) - return; SvxTPFilter *pFilterPage = m_xTabPagesCTRL->GetFilterPage(); @@ -1131,12 +1129,12 @@ IMPL_LINK_NOARG(SwRedlineAcceptDlg, SelectHdl, weld::TreeView&, void) IMPL_LINK_NOARG(SwRedlineAcceptDlg, GotoHdl, Timer *, void) { + m_aSelectTimer.Stop(); + SwWrtShell* pSh = ::GetActiveView()->GetWrtShellPtr(); if (!pSh) return; - m_aSelectTimer.Stop(); - bool bIsNotFormated = false; bool bSel = false; diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index 29aac4eadee1..6b22c60dd2ed 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -3757,10 +3757,7 @@ IMPL_LINK_NOARG(SwContentTree, TimerUpdate, Timer *, void) // Query view because the Navigator is cleared too late. SwView* pView = GetParentWindow()->GetCreateView(); - if (!pView) - return; - - SwWrtShell* pActShell = pView->GetWrtShellPtr(); + SwWrtShell* pActShell = pView ? pView->GetWrtShellPtr() : nullptr; if(pActShell && pActShell->GetWin() && (pActShell->GetWin()->HasFocus() || m_bDocHasChanged || m_bViewHasChanged) && !IsInDrag() && !pActShell->ActionPend()) |