summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2016-08-17 10:14:45 +0200
committerStephan Bergmann <sbergman@redhat.com>2016-08-17 10:14:45 +0200
commit6be059453e243af45de6f5a3fa33d30b6dbf3d36 (patch)
tree3af8b3eaffd3727611d17f296c58afb29532dbf9
parenta88e8607800e68461c4f7fc5e1f72f5f802c53fd (diff)
Use full absolute URL in footer-contain-hyperlink.docx
What this binary change does is change in the contained word/_rels/footer1.xml.rels from Target="www.google.com" to Target="http://www.google.com/" because of: <sberg> vmiklos, do you know how sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx (introduced with 4654e9b113a66c800161d0ee82d587055fff4f8b ["fdo#74271: Added unit test & code changes for footer contains hyperlink."]) was created? It contains a word/_rels/footer1.xml.rels with a <Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink" Target="www.google.com" TargetMode="External"/>, where that Target="www.google.com" is not a proper URL, but the testFooterContainHyper link test in sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx expects it to end up as "http://www.google.com/" <vmiklos> sberg: [...] that sounds like a bug, MSO resolves that as a regular relative file reference, i.e. to file:///...\ooxmlexport\data\www.google.com <sberg> vmiklos, ah, that's good to know; I'm trying to fix tdf#86087 ["FILESAVE FILEOPEN VIEWING: Can't open or save relative links in docx"] by turning relative URLs into absolute ones when reading docx etc. in writerfilter/source/dmapper/DomainMapper_Impl.cxx, but that now caused that test to fail <sberg> vmiklos, so I guess it's best to modify sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx to contain <http://www.google.com/> instead of merely <www.google.com> <vmiklos> sberg: yes, i think so Change-Id: I7986acb66f260faaf8fe5398f3778cc35fb9930d
-rw-r--r--sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docxbin12150 -> 12196 bytes
1 files changed, 0 insertions, 0 deletions
diff --git a/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx b/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx
index 27b00ed37ecb..42c68d5e1f91 100644
--- a/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx
+++ b/sw/qa/extras/ooxmlexport/data/footer-contain-hyperlink.docx
Binary files differ