diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-05-14 16:50:30 +0100 |
|---|---|---|
| committer | Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> | 2019-11-29 07:51:42 +0100 |
| commit | 41c827b682def2725a2f06c2d8b6e75423b4e885 (patch) | |
| tree | c25572856cd3be5944481a94b06ca183464bdbba | |
| parent | 0f7c42121a0634d97dde1823add4a9255de1f416 (diff) | |
ofz#7322 lcl_MarkEqualByStart sort logic differs from that of operator==
when it encounters a SwPosition with a SwIndex nContent whose m_pIndexReg is
null and compares to one whose m_pIndexReg is not null, where both have an
m_nIndex of 0.
operator== considers them different, while lcl_MarkEqualByStart doesn't care
and sorts them as equal
Change-Id: I29920b98c9e6f395487de1b9cafa6b1282b2b1b6
Reviewed-on: https://gerrit.libreoffice.org/54342
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit b3aece104b886618552828c168a1b51b3290f38f)
| -rw-r--r-- | sw/qa/core/data/ww8/indeterminate/ofz7322-1.doc | bin | 0 -> 49544 bytes | |||
| -rw-r--r-- | sw/source/core/doc/docbm.cxx | 9 |
2 files changed, 8 insertions, 1 deletions
diff --git a/sw/qa/core/data/ww8/indeterminate/ofz7322-1.doc b/sw/qa/core/data/ww8/indeterminate/ofz7322-1.doc Binary files differnew file mode 100644 index 000000000000..5f4858849acf --- /dev/null +++ b/sw/qa/core/data/ww8/indeterminate/ofz7322-1.doc diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx index 0822d4e1bf0f..f648432aaadc 100644 --- a/sw/source/core/doc/docbm.cxx +++ b/sw/source/core/doc/docbm.cxx @@ -225,6 +225,13 @@ namespace return false; } + bool lcl_MarkEqualByStart(const IDocumentMarkAccess::pMark_t& rpFirst, + const IDocumentMarkAccess::pMark_t& rpSecond) + { + return !lcl_MarkOrderingByStart(rpFirst, rpSecond) && + !lcl_MarkOrderingByStart(rpSecond, rpFirst); + } + IDocumentMarkAccess::iterator_t lcl_FindMark( IDocumentMarkAccess::container_t& rMarks, const IDocumentMarkAccess::pMark_t& rpMarkToFind) @@ -235,7 +242,7 @@ namespace // since there are usually not too many marks on the same start // position, we are not doing a bisect search for the upper bound // but instead start to iterate from pMarkLow directly - while(ppCurrentMark != rMarks.end() && **ppCurrentMark == *rpMarkToFind) + while (ppCurrentMark != rMarks.end() && lcl_MarkEqualByStart(*ppCurrentMark, rpMarkToFind)) { if(ppCurrentMark->get() == rpMarkToFind.get()) { |