summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2018-04-07 20:24:40 +0100
committerSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>2019-11-29 07:51:39 +0100
commit38edc333f31aea5a853b6e4abba81a7789859d1c (patch)
tree641708482f2e1d187bc5a1954d423d157b645dbb
parentffae524ffafe06ce94a344ee24dbea64e6106bb5 (diff)
forcepoint#37 revert tdf#108572 let remove storage element
reverts commit 26957fc325c27cf61e8ef5555b380d627def4931 Date: Wed Sep 6 10:54:50 2017 +0200 tdf#108572 let remove storage element void OStorage_Impl::RemoveElement( SotElement_Impl* pElement ) expects that m_pAntiImpl will be nullptr, if not throws an exception. This caused that in case of deleting embedded database used for mail merge it wasn't fully removed and The problem is that by allowing the removal of the element, existing readonly accessors are left pointing to the deleted element which causes quite some problems as seen in this sample document Change-Id: Ie6ac36e6dea771b02637d77b78eb8026e3bb7ae8 Reviewed-on: https://gerrit.libreoffice.org/52600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 8182037871daf1d94f4beff63afeb56b20055480)
-rwxr-xr-xsw/qa/core/data/odt/fail/forcepoint-xstor-1.odtbin0 -> 144064 bytes
1 files changed, 0 insertions, 0 deletions
diff --git a/sw/qa/core/data/odt/fail/forcepoint-xstor-1.odt b/sw/qa/core/data/odt/fail/forcepoint-xstor-1.odt
new file mode 100755
index 000000000000..1844d7882ba9
--- /dev/null
+++ b/sw/qa/core/data/odt/fail/forcepoint-xstor-1.odt
Binary files differ