diff options
| author | Rafael Lima <rafael.palma.lima@gmail.com> | 2022-01-03 23:37:26 +0100 |
|---|---|---|
| committer | Adolfo Jayme Barrientos <fitojb@ubuntu.com> | 2022-01-22 04:47:02 +0100 |
| commit | 2db11ed1cdd0a7f7870230bb77519e5f9f4d054b (patch) | |
| tree | 7d047d9b03a9d717987b63f6213ac82eca32799f | |
| parent | 8bbe0eacd826f33f9cd4f1aec77220b29d4a4e7b (diff) | |
tdf#135935 Ensure help page is opened in chart creation Wizard dialog
Prior to this patch, if the user opens the Chart Wizard dialog (Insert > Chart) and clicks the Help button without clicking anywhere in the dialog, the help ID was not being applied. This problem happens on kf5 and gen, but not on gtk3.
With this patch, the expected behavior is achieved in gtk3, gen and kf5.
Change-Id: Ief7852fce00de45f65c21ea0ddc8e4d6477612d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127783
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 67e88d173fb56a2628a5464d56276134bf6f65a2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128681
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
| -rw-r--r-- | chart2/source/controller/dialogs/dlg_CreationWizard.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx index da073c2f9956..85b4e9db5a8b 100644 --- a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx +++ b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx @@ -72,7 +72,8 @@ CreationWizard::CreationWizard(weld::Window* pParent, const uno::Reference<frame declarePath(PATH_FULL, aPath); - SetRoadmapHelpId(HID_SCH_WIZARD_ROADMAP); + // tdf#135935 ensure help ID is set when no element is clicked in the dialog + m_xAssistant->set_help_id(HID_SCH_WIZARD_ROADMAP); if (!m_pDialogModel->getModel().isDataFromSpreadsheet()) { |